Re: RFR: JDK-8214710 Fix hg log in update_copyright_year.sh
Looks good. /Erik On 2018-12-03 06:19, Magnus Ihse Bursie wrote: The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset with missed copyright year updates in the build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8214710 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8214710-fix-update-copyright-year/webrev.01 /Magnus
Re: RFR: JDK-8214710 Fix hg log in update_copyright_year.sh
Magnus: On 12/03/18 08:16, Alan Bateman wrote: On 03/12/2018 16:10, Magnus Ihse Bursie wrote: The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset with missed copyright year updates in the build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8214710 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8214710-fix-update-copyright-year/webrev.01 This looks okay to me. For the follow-on "missing copyright year updates" then maybe the entire source should be done rather than doing it in piecemeal. -Alan Looks good to me as well. Tim
Re: RFR: JDK-8214710 Fix hg log in update_copyright_year.sh
On 2018-12-03 17:16, Alan Bateman wrote: On 03/12/2018 16:10, Magnus Ihse Bursie wrote: The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset with missed copyright year updates in the build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8214710 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8214710-fix-update-copyright-year/webrev.01 This looks okay to me. Thanks. For the follow-on "missing copyright year updates" then maybe the entire source should be done rather than doing it in piecemeal. I just created JDK-8214718... Anyway, I'm not sure that's a good idea. The script gives an indication of files that should be updated, but it's not 100% correct and someone will need to verify that it does not trigger for changes that should not result in a copyright year update (like updating the copyright header). The script, as it is, tries to filter out changesets that it should not consider, but that looked very brittle, and I did in fact remove that check before running the script on the build system code. Perhaps not component knowledge is needed, but laying the burden on a single person to do this grunt work for all of the code base is perhaps not fair either. For me, I'd like to know that the code I'm responsible for is correct. /Magnus
Re: RFR: JDK-8214710 Fix hg log in update_copyright_year.sh
On 03/12/2018 16:10, Magnus Ihse Bursie wrote: The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset with missed copyright year updates in the build system. Bug: https://bugs.openjdk.java.net/browse/JDK-8214710 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8214710-fix-update-copyright-year/webrev.01 This looks okay to me. For the follow-on "missing copyright year updates" then maybe the entire source should be done rather than doing it in piecemeal. -Alan
