Re: RFR: JDK-8232133: Change to GCC 8.3 for building on Linux at Oracle
On 2019-10-10 15:25, Kim Barrett wrote: On Oct 10, 2019, at 2:27 PM, Erik Joelsson wrote: Updating defaults in devkit creator makefiles. Also remembering to update building.md this time. Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8232133 /Erik doc/building.md 341 The JDK is currently known to be able to compile with at least version 7.4 of 342 gcc. Maybe things like the above should get cleaned up while you are here. Other than that, looks good to me. I don’t need another webrev for version updates like that mentioned above. Thanks! I've updated that line to 8.3. /Erik
Re: RFR: JDK-8232133: Change to GCC 8.3 for building on Linux at Oracle
> 10 okt. 2019 kl. 20:27 skrev Erik Joelsson : > > Updating defaults in devkit creator makefiles. Also remembering to update > building.md this time. > > Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/ Looks good to me. /Magnus > > Bug: https://bugs.openjdk.java.net/browse/JDK-8232133 > > /Erik >
Re: RFR: JDK-8232133: Change to GCC 8.3 for building on Linux at Oracle
Hi Erik, On 11/10/2019 4:27 am, Erik Joelsson wrote: Updating defaults in devkit creator makefiles. Also remembering to update building.md this time. Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8232133 Seems okay. I'm somewhat surprised this is such a small update from 8.2 to 8.3 - hardly seems worthwhile. I assume we will jump 9.x next time? Thanks, David /Erik
Re: RFR: JDK-8232133: Change to GCC 8.3 for building on Linux at Oracle
> On Oct 10, 2019, at 2:27 PM, Erik Joelsson wrote: > > Updating defaults in devkit creator makefiles. Also remembering to update > building.md this time. > > Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8232133 > > /Erik doc/building.md 341 The JDK is currently known to be able to compile with at least version 7.4 of 342 gcc. Maybe things like the above should get cleaned up while you are here. Other than that, looks good to me. I don’t need another webrev for version updates like that mentioned above.
