Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-04-05 14:09, David Holmes wrote: :) V12 looks fine. Sorry I didnt see this before previous email. Finally! :-) I'll wait for Thomas to test on AIX as well, then I believe this is finally ready to push. /Magnus David On 5/04/2018 9:51 PM, Magnus Ihse Bursie wrote: On 2018-04-05

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

:) V12 looks fine. Sorry I didnt see this before previous email. David On 5/04/2018 9:51 PM, Magnus Ihse Bursie wrote: On 2018-04-05 13:07, Magnus Ihse Bursie wrote: On 2018-04-05 12:30, David Holmes wrote: On 5/04/2018 7:52 PM, Magnus Ihse Bursie wrote: On 2018-04-05 10:30, David Holmes wro

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 5/04/2018 9:07 PM, Magnus Ihse Bursie wrote: On 2018-04-05 12:30, David Holmes wrote: On 5/04/2018 7:52 PM, Magnus Ihse Bursie wrote: On 2018-04-05 10:30, David Holmes wrote: On 5/04/2018 6:07 PM, Magnus Ihse Bursie wrote: On 2018-04-04 09:59, David Holmes wrote: Hi Magnus, Sorry for

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-04-05 13:07, Magnus Ihse Bursie wrote: On 2018-04-05 12:30, David Holmes wrote: On 5/04/2018 7:52 PM, Magnus Ihse Bursie wrote: On 2018-04-05 10:30, David Holmes wrote: On 5/04/2018 6:07 PM, Magnus Ihse Bursie wrote: On 2018-04-04 09:59, David Holmes wrote: Hi Magnus, Sorry for th

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-04-05 13:07, Magnus Ihse Bursie wrote: On 2018-04-05 12:30, David Holmes wrote: On 5/04/2018 7:52 PM, Magnus Ihse Bursie wrote: On 2018-04-05 10:30, David Holmes wrote: On 5/04/2018 6:07 PM, Magnus Ihse Bursie wrote: On 2018-04-04 09:59, David Holmes wrote: Hi Magnus, Sorry for th

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-04-05 12:30, David Holmes wrote: On 5/04/2018 7:52 PM, Magnus Ihse Bursie wrote: On 2018-04-05 10:30, David Holmes wrote: On 5/04/2018 6:07 PM, Magnus Ihse Bursie wrote: On 2018-04-04 09:59, David Holmes wrote: Hi Magnus, Sorry for the delay ... On 28/03/2018 8:15 PM, Magnus Ihse

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 5/04/2018 7:52 PM, Magnus Ihse Bursie wrote: On 2018-04-05 10:30, David Holmes wrote: On 5/04/2018 6:07 PM, Magnus Ihse Bursie wrote: On 2018-04-04 09:59, David Holmes wrote: Hi Magnus, Sorry for the delay ... On 28/03/2018 8:15 PM, Magnus Ihse Bursie wrote: On 2018-03-27 18:24, Thoma

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-04-05 10:30, David Holmes wrote: On 5/04/2018 6:07 PM, Magnus Ihse Bursie wrote: On 2018-04-04 09:59, David Holmes wrote: Hi Magnus, Sorry for the delay ... On 28/03/2018 8:15 PM, Magnus Ihse Bursie wrote: On 2018-03-27 18:24, Thomas Stüfe wrote: Hi Magnus, just a cursory look,

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-04-04 09:59, David Holmes wrote: Hi Magnus, Sorry for the delay ... On 28/03/2018 8:15 PM, Magnus Ihse Bursie wrote: On 2018-03-27 18:24, Thomas Stüfe wrote: Hi Magnus, just a cursory look, will look in greater detail tomorrow. This is good, thanks for doing this. As I wrote off

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 5/04/2018 6:07 PM, Magnus Ihse Bursie wrote: On 2018-04-04 09:59, David Holmes wrote: Hi Magnus, Sorry for the delay ... On 28/03/2018 8:15 PM, Magnus Ihse Bursie wrote: On 2018-03-27 18:24, Thomas Stüfe wrote: Hi Magnus, just a cursory look, will look in greater detail tomorrow. Thi

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, Sorry for the delay ... On 28/03/2018 8:15 PM, Magnus Ihse Bursie wrote: On 2018-03-27 18:24, Thomas Stüfe wrote: Hi Magnus, just a cursory look, will look in greater detail tomorrow. This is good, thanks for doing this. As I wrote offlist, please remove the painfully wrong AIX

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-03-29 14:51, Thomas Stüfe wrote: Hi Magnus, On Thu, Mar 29, 2018 at 8:47 AM, Thomas Stüfe > wrote: On Thu, Mar 29, 2018 at 12:37 AM, Magnus Ihse Bursie mailto:magnus.ihse.bur...@oracle.com>> wrote: On 2018-03-28 21:21, Thomas Stüfe w

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, On Thu, Mar 29, 2018 at 8:47 AM, Thomas Stüfe wrote: > > > On Thu, Mar 29, 2018 at 12:37 AM, Magnus Ihse Bursie < > magnus.ihse.bur...@oracle.com> wrote: > >> On 2018-03-28 21:21, Thomas Stüfe wrote: >> >> Hi Magnus, >> >> I had a closer look at the changes, especially at jsig.c. It a

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On Thu, Mar 29, 2018 at 12:37 AM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-03-28 21:21, Thomas Stüfe wrote: > > Hi Magnus, > > I had a closer look at the changes, especially at jsig.c. It all comes > slowly back. The AIX version has been almost comically wrong. > > Abou

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-03-28 21:21, Thomas Stüfe wrote: Hi Magnus, I had a closer look at the changes, especially at jsig.c. It all comes slowly back. The AIX version has been almost comically wrong. About NSIG, I remember that we had coding in our port which needed to know the max number of signals, and t

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, I had a closer look at the changes, especially at jsig.c. It all comes slowly back. The AIX version has been almost comically wrong. About NSIG, I remember that we had coding in our port which needed to know the max number of signals, and this was surprisingly hard since on some platfo

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-03-27 18:24, Thomas Stüfe wrote: Hi Magnus, just a cursory look, will look in greater detail tomorrow. This is good, thanks for doing this. As I wrote offlist, please remove the painfully wrong AIX "workarounds". I do not know why we did this - the original code is quite old - my as

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 2018-03-28 01:03, David Holmes wrote: Hi Magnus, I appreciate what you are trying to do here but there are reasons this kind of cleanup keeps getting deferred :) - it's not trivial and deals with really old code that isn't always clear. You may have bitten off more than you want to chew he

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, I appreciate what you are trying to do here but there are reasons this kind of cleanup keeps getting deferred :) - it's not trivial and deals with really old code that isn't always clear. You may have bitten off more than you want to chew here. (And I'm strapped for time to work th

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, just a cursory look, will look in greater detail tomorrow. This is good, thanks for doing this. As I wrote offlist, please remove the painfully wrong AIX "workarounds". I do not know why we did this - the original code is quite old - my assumption is that dlsym(RTLD_NEXT) was not work

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Build change looks good. I will let someone more informed look at the code changes. /Erik On 2018-03-27 02:42, Magnus Ihse Bursie wrote: When I was about to update jsig.c, I noticed that the four copies for aix, linux, macosx and solaris were basically the same, with only small differences.

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, I will take a look at this tomorrow. There are some open bugs on jsig regarding the number of signals it can handle on different platforms IIRC. Also the Solaris differences may not be needed as the pthread functions can be used without any concern in most cases. Thanks, David On

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 03/27/2018 06:42 PM, Magnus Ihse Bursie wrote: > * Linux and macosx used a uint32_t/uint64_t instead of sigset_t for jvmsigs, > as aix and solaris do. This is a less robust solution, and the added checks > show > that it has failed in the past. Now all platforms use sigset_t/sigismember(). Ah