Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread David Holmes
On 8/05/2018 1:40 AM, Erik Joelsson wrote: Looks good to me. Note for future, I would like it even more if we got rid of the pre-defined jvm.cfg altogether and just always generated it. The build That was supposed to be happening ... see (non-public sorry) JDK-8179985. Don't know what the

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread Erik Joelsson
On 2018-05-07 08:40, Erik Joelsson wrote: Looks good to me. Note for future, I would like it even more if we got rid of the pre-defined jvm.cfg altogether and just always generated it. The build itself shouldn't be dictating artificial limitations on build parameters. If we want to enforce

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread Erik Joelsson
Looks good to me. Note for future, I would like it even more if we got rid of the pre-defined jvm.cfg altogether and just always generated it. The build itself shouldn't be dictating artificial limitations on build parameters. If we want to enforce limitations those should be explicit

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread David Holmes
On 7/05/2018 6:20 PM, Aleksey Shipilev wrote: On 05/06/2018 09:20 AM, David Holmes wrote: On 5/05/2018 9:26 PM, Aleksey Shipilev wrote: RFE:    https://bugs.openjdk.java.net/browse/JDK-8202683 Fix:    http://cr.openjdk.java.net/~shade/8202683/webrev.01/ Minimal VM is targeted to 32-bit

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-07 Thread Aleksey Shipilev
On 05/06/2018 09:20 AM, David Holmes wrote: > On 5/05/2018 9:26 PM, Aleksey Shipilev wrote: >> RFE: >>    https://bugs.openjdk.java.net/browse/JDK-8202683 >> >> Fix: >>    http://cr.openjdk.java.net/~shade/8202683/webrev.01/ >> >> Minimal VM is targeted to 32-bit only, but hear me out. Recent

Re: RFR 8202683: Minimal VM should build cleanly on 64-bit platforms

2018-05-06 Thread David Holmes
On 5/05/2018 9:26 PM, Aleksey Shipilev wrote: RFE: https://bugs.openjdk.java.net/browse/JDK-8202683 Fix: http://cr.openjdk.java.net/~shade/8202683/webrev.01/ Minimal VM is targeted to 32-bit only, but hear me out. Recent build system changes, notably conditional GC compilation, requires