Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-07 Thread Thomas Stüfe
Great, thanks! On Mon, May 7, 2018 at 5:41 PM, Erik Joelsson wrote: > Yes, sure, I'm working on a different fix in the same area now anyway so can > sneak this fix in there. Will get done this week. > > /Erik > > > > On 2018-05-07 07:37, Thomas Stüfe wrote: >> >> Hi

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-07 Thread Erik Joelsson
Yes, sure, I'm working on a different fix in the same area now anyway so can sneak this fix in there. Will get done this week. /Erik On 2018-05-07 07:37, Thomas Stüfe wrote: Hi Erik, since your proposal worked, will you do a fix? Thanks, Thomas On Fri, May 4, 2018 at 8:30 AM, Thomas Stüfe

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-07 Thread Thomas Stüfe
Hi Erik, since your proposal worked, will you do a fix? Thanks, Thomas On Fri, May 4, 2018 at 8:30 AM, Thomas Stüfe wrote: > Hi Erik, > > that worked on both machines for all builds. > > Thanks, Thomas > > On Thu, May 3, 2018 at 10:13 PM, Erik Joelsson

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-04 Thread Thomas Stüfe
Hi Erik, that worked on both machines for all builds. Thanks, Thomas On Thu, May 3, 2018 at 10:13 PM, Erik Joelsson wrote: > Hello, > > In my case, VCINSTALLDIR is in short form already. Could you try changing > line 543 from BASIC_WINDOWS_REWRITE_AS_UNIX_PATH to

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-03 Thread Erik Joelsson
Hello, In my case, VCINSTALLDIR is in short form already. Could you try changing line 543 from BASIC_WINDOWS_REWRITE_AS_UNIX_PATH to BASIC_FIXUP_PATH? /Erik On 2018-05-03 11:17, Thomas Stüfe wrote: Hi Erik, I see the error on two very different machines. One is my private machine -

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-03 Thread Thomas Stüfe
Hi Erik, I see the error on two very different machines. One is my private machine - windows 7, VS2013 and VS2017 installed. The second one is my corporate Laptop, Windows 10 and only VS2013. In both cases I use a very recent cygwin64 installation. Both cases run in TOOLCHAIN_SETUP_MSVC_DLL

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-03 Thread Erik Joelsson
Also, on my windows system, if I try using my local Visual Studio, both MSVC dll's are found in the Visual Studio dir, and the spaces are all cleaned up. I wonder what's different about your setup, Thomas. /Erik On 2018-05-03 10:13, Erik Joelsson wrote: Hello, On 2018-05-03 03:41, Magnus

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-03 Thread Erik Joelsson
Hello, On 2018-05-03 03:41, Magnus Ihse Bursie wrote: I think the main issue here is that BASIC_FIXUP_PATH should be called for the located msvcr*.dll files. I don't have time to look at it now, but see if you can do a rewrite using BASIC_FIXUP_PATH when the potential file is located. This

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-03 Thread Thomas Stüfe
Thank you Magnus, will do. On Thu, May 3, 2018 at 12:41 PM, Magnus Ihse Bursie wrote: > I think the main issue here is that BASIC_FIXUP_PATH should be called for > the located msvcr*.dll files. I don't have time to look at it now, but see > if you can do a rewrite

Re: Windows: problem with msvxxx.dll locations containing spaces

2018-05-03 Thread Magnus Ihse Bursie
I think the main issue here is that BASIC_FIXUP_PATH should be called for the located msvcr*.dll files. I don't have time to look at it now, but see if you can do a rewrite using BASIC_FIXUP_PATH when the potential file is located. This should remove all spaces from the path. /Magnus On

Windows: problem with msvxxx.dll locations containing spaces

2018-05-02 Thread Thomas Stüfe
Hi, My 32bit builds on Windows were failing since quite a while and I finally had some minutes to look into that. See prior discussion here: http://mail.openjdk.java.net/pipermail/build-dev/2018-March/021150.html My output used to look like this: checking if fixpath.exe works... yes