Re: Build failed in Jenkins: Mesos-Windows #703

2016-10-17 Thread Joseph Wu 
Neither stout nor libprocess tests have the test filters of
`src/tests/environment.cpp`.

The problem is that on Windows, you must be an Administrator (essentially
root) to create symlinks.  The four failed tests above (all except for
"OsTest.System", which failed for a different reason) create symlinks.

On Mon, Oct 17, 2016 at 11:08 AM, Vinod Kone  wrote:

> Can the stout tests be prefixed with `ROOT_` ?
>
> On Fri, Oct 14, 2016 at 5:15 PM, Joseph Wu  wrote:
>
> > I'll fix this shortly.  I need to disable a couple (stout) tests that
> > require Administrator privileges.  The ASF CI does not run any "ROOT"
> > tests, so I'll make this change in the Jenkins job itself.
> >
> > On Fri, Oct 14, 2016 at 5:03 PM, Apache Jenkins Server <
> > jenk...@builds.apache.org> wrote:
> >
> > > See 
> > >
> > > Changes:
> > >
> > > [josephwu] Made semantics of `os::rmdir` consistent between POSIX and
> > > Windows.
> > >
> > > [josephwu] Cleaned up style in stout rmdir_tests.cpp.
> > >
> > > [josephwu] Stout: Enabled tests that pass on Windows.
> > >
> > > [josephwu] Libprocess: Enabled tests that pass on Windows.
> > >
> > > [josephwu] Windows: Updated build script to run the stout/libprocess
> > tests.
> > >
> > > --
> > > [...truncated 3980 lines...]
> > > [--] 10 tests from FsTest
> > > [ RUN  ] FsTest.Find
> > > [   OK ] FsTest.Find (7 ms)
> > > [ RUN  ] FsTest.ReadWriteString
> > > [   OK ] FsTest.ReadWriteString (1 ms)
> > > [ RUN  ] FsTest.Mkdir
> > > [   OK ] FsTest.Mkdir (5 ms)
> > > [ RUN  ] FsTest.Exists
> > > [   OK ] FsTest.Exists (4 ms)
> > > [ RUN  ] FsTest.Touch
> > > [   OK ] FsTest.Touch (1 ms)
> > > [ RUN  ] FsTest.Symlink
> > > F:\jenkins\jenkins-slave\workspace\Mesos-Windows\3rdparty\
> > stout\tests\os\filesystem_tests.cpp(192):
> > > error: fs::symlink(file, link): 'internal::windows::create_sym
> > bolic_link':
> > > 'CreateSymbolicLink' call failed: A required privilege is not held by
> the
> > > client.
> > >
> > >
> > > [  FAILED  ] FsTest.Symlink (5 ms)
> > > [ RUN  ] FsTest.Rm
> > > F:\jenkins\jenkins-slave\workspace\Mesos-Windows\3rdparty\
> > stout\tests\os\filesystem_tests.cpp(222):
> > > error: fs::symlink(fileToSymlink, fileSymlink1):
> > 'internal::windows::create_symbolic_link':
> > > 'CreateSymbolicLink' call failed: A required privilege is not held by
> the
> > > client.
> > >
> > >
> > > [  FAILED  ] FsTest.Rm (3 ms)
> > > [ RUN  ] FsTest.List
> > > [   OK ] FsTest.List (2 ms)
> > > [ RUN  ] FsTest.Rename
> > > [   OK ] FsTest.Rename (3 ms)
> > > [ RUN  ] FsTest.Close
> > > [   OK ] FsTest.Close (3 ms)
> > > [--] 10 tests from FsTest (34 ms total)
> > >
> > > [--] 4 tests from ProcessTest
> > > [ RUN  ] ProcessTest.Process
> > > [   OK ] ProcessTest.Process (7 ms)
> > > [ RUN  ] ProcessTest.Processes
> > > [   OK ] ProcessTest.Processes (109 ms)
> > > [ RUN  ] ProcessTest.Pids
> > > [   OK ] ProcessTest.Pids (18 ms)
> > > [ RUN  ] ProcessTest.Pstree
> > >
> > > Pinging 127.0.0.1 with 32 bytes of data:
> > > Reply from 127.0.0.1: bytes=32 time<1ms TTL=128
> > > Reply from 127.0.0.1: bytes=32 time<1ms TTL=128
> > >
> > > Ping statistics for 127.0.0.1:
> > > Packets: Sent = 2, Received = 2, Lost = 0 (0% loss),
> > > Approximate round trip times in milli-seconds:
> > > Minimum = 0ms, Maximum = 0ms, Average = 0ms
> > > [   OK ] ProcessTest.Pstree (1124 ms)
> > > [--] 4 tests from ProcessTest (1259 ms total)
> > >
> > > [--] 9 tests from RmdirTest
> > > [ RUN  ] RmdirTest.TrivialRemoveEmptyDirectoryAbsolutePath
> > > [   OK ] RmdirTest.TrivialRemoveEmptyDirectoryAbsolutePath (2 ms)
> > > [ RUN  ] RmdirTest.TrivialRemoveEmptyDirectoryRelativePath
> > > [   OK ] RmdirTest.TrivialRemoveEmptyDirectoryRelativePath (1 ms)
> > > [ RUN  ] RmdirTest.RemoveFile
> > > [   OK ] RmdirTest.RemoveFile (2 ms)
> > > [ RUN  ] RmdirTest.RemoveRecursiveByDefault
> > > [   OK ] RmdirTest.RemoveRecursiveByDefault (1 ms)
> > > [ RUN  ] RmdirTest.TrivialFailToRemoveInvalidPath
> > > [   OK ] RmdirTest.TrivialFailToRemoveInvalidPath (1 ms)
> > > [ RUN  ] RmdirTest.FailToRemoveNestedInvalidPath
> > > [   OK ] RmdirTest.FailToRemoveNestedInvalidPath (2 ms)
> > > [ RUN  ] RmdirTest.RemoveDirectoryWithSymbolicLinkTargetDirectory
> > > F:\jenkins\jenkins-slave\workspace\Mesos-Windows\
> > > 3rdparty\stout\tests\os\rmdir_tests.cpp(309): error:
> > > fs::symlink(targetDirectory, link): 'internal::windows::create_sym
> > bolic_link':
> > > 'CreateSymbolicLink' call failed: A required privilege is not held by
> the
> > > client.
> > >
> > >
> > > [  FAILED  ] RmdirTest.RemoveDirectoryWithSymbolicLinkTargetDirectory
> (2
> > > ms)
> > > [ RUN  ]

Re: Build failed in Jenkins: Mesos-Windows #703

2016-10-17 Thread Vinod Kone 
Can the stout tests be prefixed with `ROOT_` ?

On Fri, Oct 14, 2016 at 5:15 PM, Joseph Wu  wrote:

> I'll fix this shortly.  I need to disable a couple (stout) tests that
> require Administrator privileges.  The ASF CI does not run any "ROOT"
> tests, so I'll make this change in the Jenkins job itself.
>
> On Fri, Oct 14, 2016 at 5:03 PM, Apache Jenkins Server <
> jenk...@builds.apache.org> wrote:
>
> > See 
> >
> > Changes:
> >
> > [josephwu] Made semantics of `os::rmdir` consistent between POSIX and
> > Windows.
> >
> > [josephwu] Cleaned up style in stout rmdir_tests.cpp.
> >
> > [josephwu] Stout: Enabled tests that pass on Windows.
> >
> > [josephwu] Libprocess: Enabled tests that pass on Windows.
> >
> > [josephwu] Windows: Updated build script to run the stout/libprocess
> tests.
> >
> > --
> > [...truncated 3980 lines...]
> > [--] 10 tests from FsTest
> > [ RUN  ] FsTest.Find
> > [   OK ] FsTest.Find (7 ms)
> > [ RUN  ] FsTest.ReadWriteString
> > [   OK ] FsTest.ReadWriteString (1 ms)
> > [ RUN  ] FsTest.Mkdir
> > [   OK ] FsTest.Mkdir (5 ms)
> > [ RUN  ] FsTest.Exists
> > [   OK ] FsTest.Exists (4 ms)
> > [ RUN  ] FsTest.Touch
> > [   OK ] FsTest.Touch (1 ms)
> > [ RUN  ] FsTest.Symlink
> > F:\jenkins\jenkins-slave\workspace\Mesos-Windows\3rdparty\
> stout\tests\os\filesystem_tests.cpp(192):
> > error: fs::symlink(file, link): 'internal::windows::create_sym
> bolic_link':
> > 'CreateSymbolicLink' call failed: A required privilege is not held by the
> > client.
> >
> >
> > [  FAILED  ] FsTest.Symlink (5 ms)
> > [ RUN  ] FsTest.Rm
> > F:\jenkins\jenkins-slave\workspace\Mesos-Windows\3rdparty\
> stout\tests\os\filesystem_tests.cpp(222):
> > error: fs::symlink(fileToSymlink, fileSymlink1):
> 'internal::windows::create_symbolic_link':
> > 'CreateSymbolicLink' call failed: A required privilege is not held by the
> > client.
> >
> >
> > [  FAILED  ] FsTest.Rm (3 ms)
> > [ RUN  ] FsTest.List
> > [   OK ] FsTest.List (2 ms)
> > [ RUN  ] FsTest.Rename
> > [   OK ] FsTest.Rename (3 ms)
> > [ RUN  ] FsTest.Close
> > [   OK ] FsTest.Close (3 ms)
> > [--] 10 tests from FsTest (34 ms total)
> >
> > [--] 4 tests from ProcessTest
> > [ RUN  ] ProcessTest.Process
> > [   OK ] ProcessTest.Process (7 ms)
> > [ RUN  ] ProcessTest.Processes
> > [   OK ] ProcessTest.Processes (109 ms)
> > [ RUN  ] ProcessTest.Pids
> > [   OK ] ProcessTest.Pids (18 ms)
> > [ RUN  ] ProcessTest.Pstree
> >
> > Pinging 127.0.0.1 with 32 bytes of data:
> > Reply from 127.0.0.1: bytes=32 time<1ms TTL=128
> > Reply from 127.0.0.1: bytes=32 time<1ms TTL=128
> >
> > Ping statistics for 127.0.0.1:
> > Packets: Sent = 2, Received = 2, Lost = 0 (0% loss),
> > Approximate round trip times in milli-seconds:
> > Minimum = 0ms, Maximum = 0ms, Average = 0ms
> > [   OK ] ProcessTest.Pstree (1124 ms)
> > [--] 4 tests from ProcessTest (1259 ms total)
> >
> > [--] 9 tests from RmdirTest
> > [ RUN  ] RmdirTest.TrivialRemoveEmptyDirectoryAbsolutePath
> > [   OK ] RmdirTest.TrivialRemoveEmptyDirectoryAbsolutePath (2 ms)
> > [ RUN  ] RmdirTest.TrivialRemoveEmptyDirectoryRelativePath
> > [   OK ] RmdirTest.TrivialRemoveEmptyDirectoryRelativePath (1 ms)
> > [ RUN  ] RmdirTest.RemoveFile
> > [   OK ] RmdirTest.RemoveFile (2 ms)
> > [ RUN  ] RmdirTest.RemoveRecursiveByDefault
> > [   OK ] RmdirTest.RemoveRecursiveByDefault (1 ms)
> > [ RUN  ] RmdirTest.TrivialFailToRemoveInvalidPath
> > [   OK ] RmdirTest.TrivialFailToRemoveInvalidPath (1 ms)
> > [ RUN  ] RmdirTest.FailToRemoveNestedInvalidPath
> > [   OK ] RmdirTest.FailToRemoveNestedInvalidPath (2 ms)
> > [ RUN  ] RmdirTest.RemoveDirectoryWithSymbolicLinkTargetDirectory
> > F:\jenkins\jenkins-slave\workspace\Mesos-Windows\
> > 3rdparty\stout\tests\os\rmdir_tests.cpp(309): error:
> > fs::symlink(targetDirectory, link): 'internal::windows::create_sym
> bolic_link':
> > 'CreateSymbolicLink' call failed: A required privilege is not held by the
> > client.
> >
> >
> > [  FAILED  ] RmdirTest.RemoveDirectoryWithSymbolicLinkTargetDirectory (2
> > ms)
> > [ RUN  ] RmdirTest.RemoveDirectoryWithSymbolicLinkTargetFile
> > F:\jenkins\jenkins-slave\workspace\Mesos-Windows\
> > 3rdparty\stout\tests\os\rmdir_tests.cpp(332): error:
> > fs::symlink(targetFile, link): 'internal::windows::create_sym
> bolic_link':
> > 'CreateSymbolicLink' call failed: A required privilege is not held by the
> > client.
> >
> >
> > [  FAILED  ] RmdirTest.RemoveDirectoryWithSymbolicLinkTargetFile (2 ms)
> > [ RUN  ] RmdirTest.RemoveDirectoryButPreserveRoot
> > [   OK ] RmdirTest.RemoveDirectoryButPreserveRoot (2 ms)
> > [--] 9 tests from RmdirTest (18 ms total)
> >
> > [--] 1 test from SocketTests
> > [