On Tuesday 31 July 2012 18:08:15 walter harms wrote:
> compile tested,
> refactor correct_password.c to avoid one #if
>
> Signed-off-by: wharms
> ---
> libbb/correct_password.c |9 +++--
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/libbb/correct_password.c b/libbb
On Tuesday 31 July 2012 15:15:51 manuel.f.zerp...@ww.stud.uni-erlangen.de wrote:
> From: Manuel Zerpies
>
> Check the return values of read(), write() and fgets().
>
> Signed-off-by: Manuel Zerpies
> ---
> applets/applet_tables.c |5 -
> applets/usage.c |7 +--
> libbb/
On Wed, Jul 25, 2012 at 11:12:56PM +0400, Michael Tokarev wrote:
> On 24.07.2012 17:57, Denys Vlasenko wrote:
> > On Thu, Jul 19, 2012 at 11:56 AM, Michael Tokarev wrote:
> >> As with messages in libbb/messages.c and their declarations
> >> in include/libbb.h, there are a few other places where
>
Am 31.07.2012 17:12, schrieb Laurent Bercot:
>>> - printf(usage_array[i].aname);
>>> + printf("%s", usage_array[i].aname);
>> This can be replaced with fputs().
>
> gcc does this automatically, see below.
>
>
>>> static void xputenv(char *str)
>>> {
>>> if (putenv(st
On Tue, Jul 24, 2012 at 04:30:27PM +0200, Denys Vlasenko wrote:
> On Mon, Jul 16, 2012 at 10:56 AM, Aurelien Jarno wrote:
> > Some messages strings are defined with ALIGN1 in libbb/messages.c
> > to make sure strings are not aligned and thus to save some bytes. The
> > corresponding declaration in
>> -printf(usage_array[i].aname);
>> +printf("%s", usage_array[i].aname);
> This can be replaced with fputs().
gcc does this automatically, see below.
>> static void xputenv(char *str)
>> {
>> if (putenv(str))
>> -bb_error_msg_and_die(bb_msg_memory_exh
compile tested,
refactor correct_password.c to avoid one #if
Signed-off-by: wharms
---
libbb/correct_password.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/libbb/correct_password.c b/libbb/correct_password.c
index 6301589..7cabd33 100644
--- a/libbb/correct_p
Am 31.07.2012 15:15, schrieb manuel.f.zerp...@ww.stud.uni-erlangen.de:
> From: Manuel Zerpies
>
> compiling with gcc >= 4.4.3 the warning "format not a string literal
> and no format arguments" is thrown. This patch fixes that.
>
> Signed-off-by: Manuel Zerpies
> ---
> applets/usage_pod.c
31.07.2012 17:15, manuel.f.zerp...@ww.stud.uni-erlangen.de wrote:
> From: Manuel Zerpies
>
> compiling with gcc >= 4.4.3 the warning "format not a string literal
> and no format arguments" is thrown. This patch fixes that.
>
[]
> index 0b1c4aa..a67e8b4 100644
> --- a/applets/usage_pod.c
> +++ b/
31.07.2012 17:15, manuel.f.zerp...@ww.stud.uni-erlangen.de wrote:
> From: Manuel Zerpies
>
> The variable "unsigned opts" is not used. Saves an unnecessary call to
> getopt32().
>
> Signed-off-by: Manuel Zerpies
> ---
> miscutils/flashcp.c |2 --
> 1 files changed, 0 insertions(+), 2 delet
From: Manuel Zerpies
I'm writing my Bachelor thesis at the VAMOS project [0] at the
Friedrich-Alexander-Universität Erlangen Nürnberg. At VAMOS we
do research about the variability management in operating systems
and projects which use the Kconfig tool.
The patch of Dinny Wu is incomplete. Thi
From: Manuel Zerpies
compiling with gcc >= 4.4.3 the warning "format not a string literal
and no format arguments" is thrown. This patch fixes that.
Signed-off-by: Manuel Zerpies
---
applets/usage_pod.c |2 +-
archival/libarchive/data_extract_to_command.c |2 +
From: Manuel Zerpies
Check the return values of read(), write() and fgets().
Signed-off-by: Manuel Zerpies
---
applets/applet_tables.c |5 -
applets/usage.c |7 +--
libbb/lineedit.c|4 +++-
libbb/xfuncs_printf.c |4 +++-
4 files changed, 15 insertions(
From: Manuel Zerpies
The variable "unsigned opts" is not used. Saves an unnecessary call to
getopt32().
Signed-off-by: Manuel Zerpies
---
miscutils/flashcp.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/miscutils/flashcp.c b/miscutils/flashcp.c
index 790f9c0..47d11
14 matches
Mail list logo
