Re: [git commit] fstrim: -17b

2013-11-10 Thread souf
Le 09/11/2013 23:41, Bernhard Reutner-Fischer a écrit : commit: http://git.busybox.net/busybox/commit/?id=140f4e351191d8633fd5bd6dcf38cd1f07cb branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master Also, use the name of the block device we found, not necessarily the one we got

fstrim: patch

2013-11-10 Thread souf
Hi, Please apply this patch to fstrim applet Thanks. --- busybox/util-linux/fstrim.c.orig 2013-11-10 11:33:33.966789413 +0100 +++ busybox/util-linux/fstrim.c 2013-11-10 12:46:23.045660354 +0100 @@ -60,7 +60,7 @@ int fstrim_main(int argc UNUSED_PARAM, char **argv) { struct fstrim_range

Re: fstrim: patch

2013-11-10 Thread Tito
On Sunday 10 November 2013 12:57:41 souf wrote: Hi, Please apply this patch to fstrim applet Thanks. Hi, this patch looks wrong to me: --- busybox/util-linux/fstrim.c.orig2013-11-10 11:33:33.966789413 +0100 +++ busybox/util-linux/fstrim.c 2013-11-10 12:46:23.045660354 +0100 @@ -60,7

running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Michael Tokarev
Hello. When running testsuite, we're trying to execute applets by their names, like grep, cp, sh and so on. When CONFIG_BUSYBOX_PREFER_APPLETS set to y, busybox tries to exec itself. But this, in turn, depends on CONFIG_BUSYBOX_EXEC_PATH pointing to the right executable. On linux this is

Re: running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Michael Tokarev
Please excuse me for incomplete subject line. It was supposed to be .. and EXEC_PATH=/bin/busybox, not empty as it is now. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

testsuite and bashisms

2013-11-10 Thread Michael Tokarev
Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct heavily. It is implemented in bash and in busybox ash, but not, for example, in dash, and it is not in POSIX either. So when the system /bin/sh does not implement this construct, los of tests fails

Re: testsuite and bashisms

2013-11-10 Thread Michael Tokarev
10.11.2013 19:25, Michael Tokarev wrpte: Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct heavily. It is implemented in bash and in busybox ash, but not, for example, in dash, and it is not in POSIX either. So when the system /bin/sh does not

Fwd: Re: fstrim: patch

2013-11-10 Thread souf
Message original Sujet: Re: fstrim: patch Date : Sun, 10 Nov 2013 16:52:04 +0100 De : souf souf_o...@yahoo.fr Pour : Tito farmat...@tiscali.it Le 10/11/2013 14:56, Tito a écrit : On Sunday 10 November 2013 12:57:41 souf wrote: Hi, Please apply this patch to fstrim applet

Re: testsuite and bashisms

2013-11-10 Thread Michael Tokarev
10.11.2013 19:39, Michael Tokarev wrote: 10.11.2013 19:25, Michael Tokarev wrpte: Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct heavily. It is implemented in bash and in busybox ash, but not, for example, in dash, and it is not in POSIX either.

Re: testsuite and bashisms

2013-11-10 Thread Michael Tokarev
10.11.2013 20:09, Michael Tokarev wrote: 10.11.2013 19:39, Michael Tokarev wrote: 10.11.2013 19:25, Michael Tokarev wrpte: Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct heavily. It is implemented in bash and in busybox ash, but not, for

Re: fstrim: patch

2013-11-10 Thread Tito
On Sunday 10 November 2013 16:52:04 you wrote: Le 10/11/2013 14:56, Tito a écrit : On Sunday 10 November 2013 12:57:41 souf wrote: Hi, Please apply this patch to fstrim applet Thanks. Hi, this patch looks wrong to me: --- busybox/util-linux/fstrim.c.orig2013-11-10

Re: fstrim: patch

2013-11-10 Thread Bernhard Reutner-Fischer
On 10 November 2013 21:31, Tito farmat...@tiscali.it wrote: On Sunday 10 November 2013 16:52:04 you wrote: Le 10/11/2013 14:56, Tito a écrit : On Sunday 10 November 2013 12:57:41 souf wrote: Hi, Please apply this patch to fstrim applet Thanks. Hi, this patch looks wrong to

Re: running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Tito
On Sunday 10 November 2013 15:46:10 Michael Tokarev wrote: Hello. When running testsuite, we're trying to execute applets by their names, like grep, cp, sh and so on. When CONFIG_BUSYBOX_PREFER_APPLETS set to y, busybox tries to exec itself. But this, in turn, depends on

Re: testsuite and bashisms

2013-11-10 Thread Bernhard Reutner-Fischer
On 10 November 2013 17:19, Michael Tokarev m...@tls.msk.ru wrote: 10.11.2013 20:09, Michael Tokarev wrote: 10.11.2013 19:39, Michael Tokarev wrote: 10.11.2013 19:25, Michael Tokarev wrpte: Another question/issue with the testsuite. ' The testsuite uses ${var/search/replace} construct

Re: running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Bernhard Reutner-Fischer
On 10 November 2013 21:57, Tito farmat...@tiscali.it wrote: On Sunday 10 November 2013 15:46:10 Michael Tokarev wrote: Hello. When running testsuite, we're trying to execute applets by their names, like grep, cp, sh and so on. When CONFIG_BUSYBOX_PREFER_APPLETS set to y, busybox tries to

Re: running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Tito
On Sunday 10 November 2013 22:12:08 you wrote: On 10 November 2013 21:57, Tito farmat...@tiscali.it wrote: On Sunday 10 November 2013 15:46:10 Michael Tokarev wrote: Hello. When running testsuite, we're trying to execute applets by their names, like grep, cp, sh and so on. When

Re: running testsuite with PREFER_APPLETS=y and EXEC_PATH=

2013-11-10 Thread Rich Felker
On Sun, Nov 10, 2013 at 06:46:10PM +0400, Michael Tokarev wrote: Hello. When running testsuite, we're trying to execute applets by their names, like grep, cp, sh and so on. When CONFIG_BUSYBOX_PREFER_APPLETS set to y, busybox tries to exec itself. But this, in turn, depends on