Re: [PATCH] Correct exit codes for invalid tar archives

2013-11-20 Thread Denys Vlasenko
On Tue, Nov 19, 2013 at 8:59 PM, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.com wrote: i = full_read(archive_handle-src_fd, tar, 512); - /* If GNU tar sees EOF in above read, it says: -* tar: A lone zero block at N, where N = kilobyte -* where EOF

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-20 Thread Denys Vlasenko
On Tue, Nov 19, 2013 at 1:58 PM, Tito farmat...@tiscali.it wrote: Please try attached patch. looks good for consolidation of the other loginutils but for sulogin it makes implementing the locked root account feature more difficult Why difficult? ... pwd = getpwuid(0); if

Re: Unit tests for busybox

2013-11-20 Thread Denys Vlasenko
On Tue, Nov 19, 2013 at 1:58 PM, Bartosz Gołaszewski bartekg...@gmail.com wrote: 2013/11/5 Bartosz Gołaszewski bartekg...@gmail.com: Anyway, what do you think about the unit tests then? Any comments? I think it's best to keep tests in the same source files where tested function is. This way

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-20 Thread Tito
On Wednesday 20 November 2013 13:25:15 you wrote: On Tue, Nov 19, 2013 at 1:58 PM, Tito farmat...@tiscali.it wrote: Please try attached patch. looks good for consolidation of the other loginutils but for sulogin it makes implementing the locked root account feature more difficult Why

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-20 Thread Denys Vlasenko
Add a new return value to ask_and_check_password() to signify this condition. On Wed, Nov 20, 2013 at 2:05 PM, Tito farmat...@tiscali.it wrote: On Wednesday 20 November 2013 13:25:15 you wrote: On Tue, Nov 19, 2013 at 1:58 PM, Tito farmat...@tiscali.it wrote: Please try attached patch.

Re: [PATCH] rfkill : use new-style config/kbuild/applet

2013-11-20 Thread Denys Vlasenko
On Sat, Nov 16, 2013 at 2:07 PM, souf souf_o...@yahoo.fr wrote: Hi all, Use xasprintf instead of sprintf I applied only the conversion to new style part. Your bloatcheck looks suspect. Did you look at assembly why it is so much smaller? ___ busybox

Re: [PATCH alternative] sulogin: fix FEATURE_SHADOWPASSWDS sematics

2013-11-20 Thread Harald Becker
Hi Denys ! + if (pwd-pw_passwd == !) ... Do you mean if (pwd-pw_passwd[0] == !) ... ? -- Harald ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox