Re: [PATCH v3] nandwrite: implement -n (read/write without ecc)

2016-01-01 Thread Denys Vlasenko
Applied, thanks! On Sat, Dec 19, 2015 at 9:34 PM, Aaro Koskinen wrote: > Implement -n (read/write without ecc). > > Signed-off-by: Aaro Koskinen > --- > > v3: Use xioctl() instead of open coding it. > > v2:

Re: [PATCH v3] blkdiscard: new applet

2016-01-01 Thread Denys Vlasenko
Applied, thanks! Please try and yell at me if something's not right. On Tue, Dec 1, 2015 at 2:55 PM, Ari Sundholm wrote: > From: Ari Sundholm > > This applet discards blocks on a given device. > Tested with multiple 32-bit and 64-bit kernel versions and two

Re: [PATCH] Remove a compilation warning

2016-01-01 Thread Rich Felker
On Fri, Jan 01, 2016 at 02:44:25PM -0500, Jody Bruchon wrote: > How about putting the left side in parentheses to silence the > warning instead of turning the warning off completely? My point was that the parentheses make the code less readable, not more readable, and that nobody would reasonably

Re: [PATCH] Remove a compilation warning

2016-01-01 Thread Cristian Ionescu-Idbohrn
On Fri, 1 Jan 2016, Rich Felker wrote: > On Fri, Jan 01, 2016 at 02:44:25PM -0500, Jody Bruchon wrote: > > How about putting the left side in parentheses to silence the > > warning instead of turning the warning off completely? > > My point was that the parentheses make the code less readable, not

[PATCH 0/3] su: FEATURE_SU_NULLOK_SECURE

2016-01-01 Thread Kaarle Ritvanen
This patch set implements a new feature which, when enabled, makes su reject blank passwords unless the user is on a secure TTY defined in /etc/securetty. This resembles the default PAM configuration of some Linux distros which specify the nullok_secure option for pam_unix.so. function

[PATCH 1/3] login: move check_securetty to libbb

2016-01-01 Thread Kaarle Ritvanen
Signed-off-by: Kaarle Ritvanen --- include/libbb.h| 1 + libbb/Kbuild.src | 1 + libbb/securetty.c | 27 +++ loginutils/login.c | 19 --- 4 files changed, 29 insertions(+), 19 deletions(-) create mode 100644

[PATCH 2/3] libbb: allow_blank argument for ask_and_check_password_extended()

2016-01-01 Thread Kaarle Ritvanen
Signed-off-by: Kaarle Ritvanen --- include/libbb.h | 2 +- libbb/correct_password.c | 6 +++--- loginutils/sulogin.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/libbb.h b/include/libbb.h index e607b8f..4c43c72 100644

[PATCH 3/3] su: FEATURE_SU_NULLOK_SECURE

2016-01-01 Thread Kaarle Ritvanen
When this feature is enabled, blank passwords are not accepted by su unless the user is on a secure TTY defined in /etc/securetty. This resembles the default PAM configuration of some Linux distros which specify the nullok_secure option for pam_unix.so. Signed-off-by: Kaarle Ritvanen

Re: [PATCH] Remove a compilation warning

2016-01-01 Thread Denys Vlasenko
Applied, thanks On Thu, Dec 31, 2015 at 11:01 AM, Cristian Ionescu-Idbohrn wrote: > Reported by gcc (Debian 5.3.1-4) 5.3.1 20151219 > > shell/ash.c: In function 'evaltree': > shell/ash.c:8432:19: warning: logical not is only applied to the left hand > side of

Re: [PATCH] Remove a compilation warning

2016-01-01 Thread Rich Felker
On Thu, Dec 31, 2015 at 11:01:24AM +0100, Cristian Ionescu-Idbohrn wrote: > Reported by gcc (Debian 5.3.1-4) 5.3.1 20151219 > > shell/ash.c: In function 'evaltree': > shell/ash.c:8432:19: warning: logical not is only applied to the left hand > side of comparison [-Wlogical-not-parentheses] >