Re: [PATCH] ash: fix incorrect path in describe_command

2017-05-26 Thread Denys Vlasenko
On Fri, May 26, 2017 at 9:31 AM, Youfu Zhang wrote: > $ PATH=/extra/path:/usr/sbin:/usr/bin:/sbin:/bin \ >> busybox sh -xc 'command -V ls; command -V ls; command -Vp ls; command -vp ls' > + command -V ls > ls is /bin/ls > + command -V ls > ls is a tracked alias for /bin/ls >

Re: udhcpc changes in 1.25.0 that didn't seem to be mentioned?

2017-05-26 Thread Denys Vlasenko
On Tue, May 23, 2017 at 10:39 AM, Natanael Copa wrote: > This issue is affecting Alpine Linux too. From the setup script we will > start network in the background while user creates the root password. > However, udhcpc will not print information on the screen about the >

Re: [PATCH] ls: fix support for long options when FEATURE_LS_COLOR is deselected

2017-05-26 Thread Xabier Oneca -- xOneca
Hello, > Xabier Oneca: >> Shouldn't "--color" be guarded by IF_FEATURE_LS_COLOR, then? > > As I understand it, it's a choice: if a feature is not selected > at build time, guarding the option declaration in applet_long_options > makes busybox fail when the option is given at run-time, whereas

Re: [PATCH] ls: fix support for long options when FEATURE_LS_COLOR is deselected

2017-05-26 Thread Denys Vlasenko
On Fri, May 26, 2017 at 1:38 PM, Laurent Bercot wrote: > Declaration of ls_longopts and initialization of applet_long_options > were incorrectly guarded with ENABLE_FEATURE_LS_COLOR; that yielded a > "ls: NO_OPT: \xff" error message when long options were selected and >

Re: [PATCH] add/remove-shell: prevent world writable /etc/shells

2017-05-26 Thread Denys Vlasenko
On Wed, May 10, 2017 at 6:40 PM, Natanael Copa wrote: > add-shell will not preserve the current permissions, and if umask is 0 > it will create the /etc/shells world writable. To reproduce: > > umask 0; add-shell /bin/bash; ls -l /etc/shells > > As a workaround we add the

Re: [PATCH] ls: fix support for long options when FEATURE_LS_COLOR is deselected

2017-05-26 Thread Laurent Bercot
(replying to myself because for some reason the busybox ML manager does not send me the mails in a whole thread if I've been Cc:ed in one of the messages in the thread. So now I need the Cc: every time. ISTR it's a classic misfeature of Mailman.) Xabier Oneca: > Shouldn't "--color" be guarded

Re: [PATCH] ls: fix support for long options when FEATURE_LS_COLOR is deselected

2017-05-26 Thread Xabier Oneca -- xOneca
Hello! 2017-05-26 13:38 GMT+02:00 Laurent Bercot : > Declaration of ls_longopts and initialization of applet_long_options > were incorrectly guarded with ENABLE_FEATURE_LS_COLOR; that yielded a > "ls: NO_OPT: \xff" error message when long options were selected and >

[PATCH] ls: fix support for long options when FEATURE_LS_COLOR is deselected

2017-05-26 Thread Laurent Bercot
Declaration of ls_longopts and initialization of applet_long_options were incorrectly guarded with ENABLE_FEATURE_LS_COLOR; that yielded a "ls: NO_OPT: \xff" error message when long options were selected and color support was not. This patch ensures long options are initialized separately from

[PATCH] ash: fix incorrect path in describe_command

2017-05-26 Thread Youfu Zhang
$ PATH=/extra/path:/usr/sbin:/usr/bin:/sbin:/bin \ > busybox sh -xc 'command -V ls; command -V ls; command -Vp ls; command -vp ls' + command -V ls ls is /bin/ls + command -V ls ls is a tracked alias for /bin/ls + command -Vp ls ls is a tracked alias for (null) + command -vp ls Segmentation fault