Re: [PATCH] ash: avoid GLIBC'ism %m

2017-07-25 Thread Kang-Che Sung
On Mon, Jul 24, 2017 at 3:34 AM, Denys Vlasenko wrote: > On Sat, Jul 22, 2017 at 8:56 PM, Johannes Schindelin > wrote: >> On Fri, 21 Jul 2017, Denys Vlasenko wrote: >> >>> On Wed, Jul 19, 2017 at 3:47 AM, Jody Bruchon

[PATCH] unzip: fix regression on big-endian machines

2017-07-25 Thread Natanael Copa
This fixes a regression which was introduced with commit 2a0867a5 ("unzip: optional support for bzip2 and lzma") and causes unzip to exit with error when extracting archives: unzip: unsupported method 2048 Signed-off-by: Natanael Copa --- archival/unzip.c | 1 + 1 file

Re: [PATCH] ash: avoid GLIBC'ism %m

2017-07-25 Thread Denys Vlasenko
On Sun, Jul 23, 2017 at 9:34 PM, Denys Vlasenko wrote: > On Sat, Jul 22, 2017 at 8:56 PM, Johannes Schindelin > wrote: >> On Fri, 21 Jul 2017, Denys Vlasenko wrote: >> >>> On Wed, Jul 19, 2017 at 3:47 AM, Jody Bruchon

Re: [PATCH v3 0/2] Avoid GLIBC'ism "%m"

2017-07-25 Thread Kang-Che Sung
On Tue, Jul 25, 2017 at 9:56 PM, Johannes Schindelin wrote: > > As pointed out by Kang-Che Sung and verified by Jody Bruchon, the "%m" > format placeholder is really not in any open standard. > > Also: contrary to Denys' assumption, there are libc versions out there >

[PATCH v3 0/2] Avoid GLIBC'ism "%m"

2017-07-25 Thread Johannes Schindelin
As pointed out by Kang-Che Sung and verified by Jody Bruchon, the "%m" format placeholder is really not in any open standard. Also: contrary to Denys' assumption, there are libc versions out there which did not follow GLIBC's example to implement this non-POSIX placeholder. That must be the

Re: [PATCH v2 1/2] ash: introduce ash_perror_msg_and_raise_error()

2017-07-25 Thread Johannes Schindelin
Hi Ron, On Sun, 23 Jul 2017, Ron Yorston wrote: > Johannes Schindelin wrote: > >@@ -1263,6 +1263,8 @@ ash_vmsg(const char *msg, va_list ap) > > fprintf(stderr, "line %d: ", startlinno); > > } > > vfprintf(stderr, msg, ap); > >+if (strerr) > >+