Issues with rm and rmdir

2018-09-09 Thread Mark Phillips
I have busybox running Ubuntu on a Samsung tablet (https://userland.tech/). I have git setup to retrieve some of my code repositories. I tried a git clone with an typo in the name of the repository, so none of the code was downloaded, but git did create a directory foo with a .git directory

Re: less Idle time with busybox ash as bash vs bash

2018-09-09 Thread Denys Vlasenko
In Fri, Aug 31, 2018 at 8:11 PM James Hanley wrote: > We had some bash scripts that we converted to use busybox ash as bash > (removed any array constructs) and when comparing the two scripts - it > seems that running them under busybox yields less idle time compared > to bash. > > I was

Re: [PATCH] remove_file: don't call rmdir if remove_file return failure

2018-09-09 Thread Denys Vlasenko
Applied, thanks! On Wed, Sep 5, 2018 at 10:40 AM Yu Chen wrote: > > From: Chen Yu > > When deleting a directory, the directory should not be removed if the > file in the subdirectory fails to be deleted. > > Background information: > > When I tested the kernel using LTP (linux-test-project).I

Re: [PATCH] head: add test case for negative -n invocation

2018-09-09 Thread Denys Vlasenko
Please post a "new-style" test, see e.g. testsuite/dc.tests for an example On Thu, Sep 6, 2018 at 12:09 PM Thomas De Schampheleire wrote: > > From: Thomas De Schampheleire > > Commit 2da9724b56169f00bd7fb6b9a11c9409a7620981 broke 'head -n -1' and was > later reverted with

Re: [PATCH] remove_file: don't call rmdir if remove_file return failure

2018-09-09 Thread Denys Vlasenko
Applied, thanks! On Tue, Sep 4, 2018 at 9:11 AM Yu Chen wrote: > > From: Chen Yu > > When deleting a directory, the directory should not be removed if the > file in the subdirectory fails to be deleted. > > Background information: > > When I tested the kernel using LTP (linux-test-project).I