Re: uname vs /etc/os-release

2018-11-14 Thread Eli Schwartz
On 11/14/18 7:10 PM, Bernd Petrovitsch wrote: > On 14/11/2018 19:26, James Hanley wrote: >> uname doesn't (appear to) do it now, but should it extract information >> from /etc/os-release for rendering? > > Why should it? What are you missing? Please bring something serious and > not just a wish/cl

Re: uname vs /etc/os-release

2018-11-14 Thread Bernd Petrovitsch
On 14/11/2018 19:26, James Hanley wrote: > uname doesn't (appear to) do it now, but should it extract information > from /etc/os-release for rendering? Why should it? What are you missing? Please bring something serious and not just a wish/claim/. Thank you. In fact: - /etc/os-release is just

Re: uname vs /etc/os-release

2018-11-14 Thread Eli Schwartz
On 11/14/18 1:26 PM, James Hanley wrote: > uname doesn't (appear to) do it now, but should it extract information > from /etc/os-release for rendering? That's extremely linux specific, and coreutils uname doesn't do it either. What's the point? This is supposed to describe the operating system you

Re: [PATCH 1/3] Support both custom scripts and scripted applets

2018-11-14 Thread Eli Schwartz
On 11/14/18 1:54 PM, Ron Yorston wrote: > Denys Vlasenko wrote: >> I propose to treat both of these types scripts the same way. >> >> I have a feeling this will result in simpler code. >> >> Let me know if you foresee difficulties with this approach. > > I suppose my concern is that it risks losin

Re: [PATCH 1/3] Support both custom scripts and scripted applets

2018-11-14 Thread Ron Yorston
Denys Vlasenko wrote: >I propose to treat both of these types scripts the same way. > >I have a feeling this will result in simpler code. > >Let me know if you foresee difficulties with this approach. I suppose my concern is that it risks losing the distinctive features of the two types of script.

uname vs /etc/os-release

2018-11-14 Thread James Hanley
uname doesn't (appear to) do it now, but should it extract information from /etc/os-release for rendering? -Jim ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [RFC PATCH v2] Allow applets to be implemented as scripts

2018-11-14 Thread Denys Vlasenko
On Fri, Nov 9, 2018 at 7:34 PM Ron Yorston wrote: > Eli Schwartz wrote: > >If you absolutely must provide these scripts, move them to docs/ -- > >including nologin -- which is more descriptive of their initial > >intention. > > applets_sh/README says: > >So far these scripts are not hooked to

Re: [PATCH] ash: fix SEGV in parsebackq on big buffers caused by alloca

2018-11-14 Thread Ron Yorston
Martin, Try my patch 'ash: preserve characters on heap in backquote parsing' from Nov 11 instead. The trouble with using malloc/free is that it can leak memory if an exception is raised. We used to use malloc/free. See commit 072fc60f2 'ash: use alloca to get rid of setjmp' for an idea of the a

Re: [PATCH 1/3] Support both custom scripts and scripted applets

2018-11-14 Thread Denys Vlasenko
Apologies for late reply. On Fri, Nov 9, 2018 at 12:50 PM Ron Yorston wrote: > BusyBox has support for embedded shell scripts. Two types can be > distinguished: custom scripts and scripts implementing applets. > > All embedded scripts can be run by name and are subject to tab > completion in st

free -b alignment issues

2018-11-14 Thread Hadrien Lacour
Hello, after switching to busybox awk because mawk had a bug, I discovered a bug in free: > free -b totalusedfree shared buff/cache available Mem:16812838912 1123995648 13094776832 157700096 2594066432 15411052544 Swap: 0 0

Re: [PATCH] hush: correct description for HUSH_TICK config option

2018-11-14 Thread Denys Vlasenko
Applied, thanks On Fri, Nov 9, 2018 at 1:00 PM Ron Yorston wrote: > > The HUSH_TICK configuration option enables command substitution, > not process substitution. > > Signed-off-by: Ron Yorston > --- > shell/hush.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/shell/hu