Re: [PATCH 1/3] Support both custom scripts and scripted applets

2018-11-16 Thread Kang-Che Sung
On Sat, Nov 17, 2018 at 6:56 AM Denys Vlasenko wrote: > I basically agree. > > How about this? - embed/ applets can have configuration. > If it exists, then they are visible in "make menuconfig" > and can be selected or deselected. > But if config is _absent_, they are included unconditionally. >

Re: [PATCH 1/3] Support both custom scripts and scripted applets

2018-11-16 Thread Denys Vlasenko
On Wed, Nov 14, 2018 at 7:54 PM Ron Yorston wrote: > Denys Vlasenko wrote: > >I propose to treat both of these types scripts the same way. > > > >I have a feeling this will result in simpler code. > > > >Let me know if you foresee difficulties with this approach. > > I suppose my concern is that

Re: [PATCH v2] ash: reorder control characters to save bytes

2018-11-16 Thread Denys Vlasenko
Let's keep the same values or at least the order as in dash. There were bugs related to handling incoming chars which match "escape chars". For example: shell/ash_test/ash-quoting/dollar_squote_bash2.tests shell/ash_test/ash-quoting/unicode_8x_chars.tests shell/ash_test/ash-redir/redir7.tests

Re: wget code shrink (recent change)

2018-11-16 Thread Denys Vlasenko
On Fri, Nov 16, 2018 at 9:20 AM Xabier Oneca -- xOneca wrote: > > Hello, > > How is this actually possible to happen? I've been trying to reproduce > it (on x86_64) without success... :/ > > https://git.busybox.net/busybox/commit/?id=fe836d84554c007916adc1c2e5f5daae2f878947 > > tls: code shrink >

Re: [PATCH] ash: preserve characters on heap in backquote parsing

2018-11-16 Thread Ron Yorston
Denys Vlasenko wrote: >The location you are touching here is the same in dash. >Looks like it needs to be fixed there as well. >Can you submit this fix to dash? Then I'll port it from there, >and code will stay in sync. I submitted the same fix to the dash mailing list shortly after sending it

Re: [PATCH v2] ash: ensure variables are fully initialised when unset

2018-11-16 Thread Denys Vlasenko
Applied, thanks! On Mon, Nov 12, 2018 at 10:11 PM Ron Yorston wrote: > > When a variable is unset by calling setvar(name, NULL, 0) the code > to initialise the new, empty variable fails to initialise the last > character of the string. > > Attempts to read the contents of the unset variable will

Re: [PATCH] ash: preserve characters on heap in backquote parsing

2018-11-16 Thread Denys Vlasenko
Hi Ron, As usual, since those years back when dash resumed (semi-)active maintenance of ash codebase, I would like to be easily pick up fixes from them. In order to do that, it would be very useful to keep codebase from diverging further than it has already diverged. For example, bbox ash had a

[PATCH v2] ash: reorder control characters to save bytes

2018-11-16 Thread Ron Yorston
During the processing of argument strings ash uses non-ASCII values to indicate particular constructs. These values are arbitrary and can be changed at will. Sampling a number of permutations showed that the current choice of values results in the largest code. 11% of samples were just as bad

Re: wget code shrink (recent change)

2018-11-16 Thread Raffaello D. Di Napoli
On 16/11/2018 03:20, Xabier Oneca -- xOneca wrote: How is this actually possible to happen? I've been trying to reproduce it (on x86_64) without success... :/ https://git.busybox.net/busybox/commit/?id=fe836d84554c007916adc1c2e5f5daae2f878947 tls: code shrink function old new delta

[PATCH] ash: reorder control characters to save bytes

2018-11-16 Thread Ron Yorston
During the processing of argument strings ash uses non-ASCII values to indicate particular constructs. These values are arbitrary and can be changed at will. Sampling a number of permutations showed that the current choice of values results in the largest code. 11% of samples were just as bad

Re: wget code shrink (recent change)

2018-11-16 Thread Ron Yorston
Xabier Oneca wrote: >I can't see why that change would generate less asm. Out of curiosity, >anybody cares to explain? And when they've done that I have another puzzle for them... Ron ___ busybox mailing list busybox@busybox.net

wget code shrink (recent change)

2018-11-16 Thread Xabier Oneca -- xOneca
Hello, How is this actually possible to happen? I've been trying to reproduce it (on x86_64) without success... :/ https://git.busybox.net/busybox/commit/?id=fe836d84554c007916adc1c2e5f5daae2f878947 tls: code shrink function old new delta spawn_ssl_client 219 218 -1 diff --git