Re: [PATCH v2 1/2] modutils: check ELF header before calling finit_module()

2021-01-04 Thread Lauri Kasanen
On Tue, 5 Jan 2021 10:47:25 +0800 Kang-Che Sung wrote: > I don't see why the > "Invalid ELF header" message would bother you so much, since you > won't load kernel modules often. As mentioned in my original post, it's a pr_err. It shows up on console! So every boot there's 20 scary errors inter

Re: [PATCH v2 1/2] modutils: check ELF header before calling finit_module()

2021-01-04 Thread Kang-Che Sung
On Mon, Jan 4, 2021 at 6:32 PM Qu Wenruo wrote: > > On 2021/1/4 下午6:01, Kang-Che Sung wrote: > > On Sun, Jan 3, 2021 at 12:11 PM Qu Wenruo wrote: > >> > >> finit_module() and init_module() system calls have clear specification > >> to only accept valid ELF image. > >> > >> Although we try finit_m

Re: [PATCH] Fix for the FEATURE_UTMP on the FreeBSD

2021-01-04 Thread Denys Vlasenko
Applied, thank you. On Mon, Jan 4, 2021 at 7:35 PM Alex Samorukov wrote: > > FreeBSD is not using and does not define _PATH_UTMPX. > Tested with busybox applets depending on FEATURE_UTMP (e.g. who, users, etc) > > Signed-off-by: Alex Samorukov > --- > include/libbb.h | 4 > 1 file changed

Re: AW: [PATCH] ash: Load $ENV file also if $SSH_CLIENT/SSH2_CLIENT is preset in env, reformat

2021-01-04 Thread Denys Vlasenko
On Mon, Jan 4, 2021 at 8:48 PM Björn Bidar wrote: > Am Montag, 4. Januar 2021, 14:43:46 EET schrieben Sie: > > > > Please explain your real-world scenario which prompted you > > > > to create the patch. > > > > > > The real world scenario is that a user might run commands via ssh on a > > > device

Re: Nuke

2021-01-04 Thread Denys Vlasenko
On Mon, Jan 4, 2021 at 5:43 PM Tim Tassonis wrote: > On 1/3/21 4:31 PM, Denys Vlasenko wrote: > > On Sun, Jun 21, 2020 at 4:56 AM Eli Schwartz > > wrote: > >> On 6/20/20 7:26 AM, Mike Davies wrote: > >>> So whos brilliant idea was it to select 'nuke' to be built by default ? > > > > Almost all o

Re: AW: [PATCH] ash: Load $ENV file also if $SSH_CLIENT/SSH2_CLIENT is preset in env, reformat

2021-01-04 Thread Björn Bidar
Am Montag, 4. Januar 2021, 14:43:46 EET schrieben Sie: > On Sun, Jan 3, 2021 at 6:25 PM Björn Bidar wrote: > > Am Sonntag, 3. Januar 2021, 11:43:25 EET schrieben Sie: > > > I can see that ash users also might need their init scripts to be run > > > for "ssh USER@HOST COMMAND", but ash has no .bash

[PATCH] Fix for the FEATURE_UTMP on the FreeBSD

2021-01-04 Thread Alex Samorukov
FreeBSD is not using and does not define _PATH_UTMPX. Tested with busybox applets depending on FEATURE_UTMP (e.g. who, users, etc) Signed-off-by: Alex Samorukov --- include/libbb.h | 4 1 file changed, 4 insertions(+) diff --git a/include/libbb.h b/include/libbb.h index dad6fc687..664bf04

Re: [PATCH] Fix traceroute applet on the FreeBSD

2021-01-04 Thread Alex Samorukov
On 04.01.2021 12:35, Denys Vlasenko wrote: > Applied 10 patches. Thank you. > Thank you! I will send one more patch today. P.S. I did a wiki page [1] about current status, will try to keep it up to date. https://github.com/samm-git/busybox/wiki ___

Re: Nuke

2021-01-04 Thread Tim Tassonis
On 1/3/21 4:31 PM, Denys Vlasenko wrote: On Sun, Jun 21, 2020 at 4:56 AM Eli Schwartz wrote: On 6/20/20 7:26 AM, Mike Davies wrote: So whos brilliant idea was it to select 'nuke' to be built by default ? Almost all options are "on" by default. There should be a special reason (documented

Re: [PATCH v2 1/2] modutils: check ELF header before calling finit_module()

2021-01-04 Thread Qu Wenruo
On 2021/1/4 下午6:01, Kang-Che Sung wrote: On Sun, Jan 3, 2021 at 12:11 PM Qu Wenruo wrote: finit_module() and init_module() system calls have clear specification to only accept valid ELF image. Although we try finit_module() on compressed modules to let the kernel determine if it's an ELF im

Re: [PATCH] Fix traceroute applet on the FreeBSD

2021-01-04 Thread Denys Vlasenko
Applied 10 patches. Thank you. On Mon, Jan 4, 2021 at 1:41 AM Alex Samorukov wrote: > > This patch addressing 2 issues: > > 1. Replacing source/dest with uh_sport/uh_dport. It seems that uh_* members > are >defined on both Linux and BSD, so no #ifdef here > 2. Use SOL_IPV6 instead of SOL_RAW

Re: [PATCH v2 1/2] modutils: check ELF header before calling finit_module()

2021-01-04 Thread Kang-Che Sung
On Sun, Jan 3, 2021 at 12:11 PM Qu Wenruo wrote: > > finit_module() and init_module() system calls have clear specification > to only accept valid ELF image. > > Although we try finit_module() on compressed modules to let the kernel > determine if it's an ELF image, but it's not ideal, especially