Re: [PATCH 1/2] less: fully implement -R and print color escapes

2022-04-14 Thread FriendlyNeighborhoodShane
Actually, after sleeping on it, I think count_colctrl could use some more validation (even though even less doesn't do much more than this). v2 incoming. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH 2/2] less: replace most uses of NORMAL escape with UNHIGHLIGHT

2022-04-14 Thread Ishan Bhargava
On Fri, 15 Apr 2022 at 05:49, Kang-Che Sung wrote: > What's the difference between the NORMAL escape and the UNHIGHLIGHT escape? > Is there a test case to demonstrate th> The UNHIGHLIGHT escape flips only the HIGHLIGHT (invert, actually) bit back to off. The normal escape flips ALL special

Re: [PATCH 2/2] less: replace most uses of NORMAL escape with UNHIGHLIGHT

2022-04-14 Thread Kang-Che Sung
On Friday, April 15, 2022, FriendlyNeighborhoodShane < shane.880088.s...@gmail.com> wrote: > Fixes conflict when -R's color escape codes are mixed together with > highlights. Better complement to HIGHLIGHT. What's the difference between the NORMAL escape and the UNHIGHLIGHT escape? Is there a

Re: [PATCH v8] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-14 Thread Jason A. Donenfeld
Hi Bernhard, On Tue, Apr 12, 2022 at 8:37 PM Bernhard Reutner-Fischer wrote: > > Hi Jason! > I'm a bit surprised that even if i give -n the seed is moved to > seed.credit. The next boot/run will find the now creditable seed and > happily add it, IIUC, despite i wanted it to not be credited? > Is

Re: [PATCH v8] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-14 Thread Bernhard Reutner-Fischer
Hi Jason! On Sun, 10 Apr 2022 23:20:34 +0200 "Jason A. Donenfeld" wrote: > +static int read_new_seed(uint8_t *seed, size_t len, bool *is_creditable) > +{ > + ssize_t ret; > + > + *is_creditable = false; > + ret = getrandom(seed, len, GRND_NONBLOCK); > + if (ret == (ssize_t)len)

[PATCH 2/2] less: replace most uses of NORMAL escape with UNHIGHLIGHT

2022-04-14 Thread FriendlyNeighborhoodShane
Fixes conflict when -R's color escape codes are mixed together with highlights. Better complement to HIGHLIGHT. --- miscutils/less.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/miscutils/less.c b/miscutils/less.c index 392a3ef3c..7fcd6951a 100644 ---

[PATCH 1/2] less: fully implement -R and print color escapes

2022-04-14 Thread FriendlyNeighborhoodShane
Emit NORMAL at newlines, like less, to deal with malformed input. --- Fits a little akwardly into the output flow with a break and continue, but it works. miscutils/less.c | 54 +++- 1 file changed, 30 insertions(+), 24 deletions(-) diff --git