Hi,
I can't follow everything in your mail,
but about:
>> Having said that, the current implementation as it is here is
>> surely wrong, since the fallback getrandom returns ENOSYS, instead
>> of setting errno to ENOSYS?
>> 200a9669fbf6f06894e42439fc11a1a6073a as of -04-10.
Already fixed
Thomas Devoogdt wrote in
:
|About:
|>> HAVE_GETRANDOM := $(shell printf '#include \n#include \
|>> \nint main(void){char buf[256];\ngetrandom(buf,sizeof(buf)\
|>> ,GRND_NONBLOCK);}' >bb_libtest.c; $(CC) $(CFLAGS) $(CFLAGS_busybox) \
|>> -D_GNU_SOURCE -o /dev/null
|
|Is it a good idea to
Hello,
On 19 April 2023 22:24:13 CEST, Thomas Devoogdt wrote:
>Is it a good idea to have GRND_NONBLOCK in that check? What if it's
>not defined, but getrandom() is, then HAVE_GETRANDOM might incorrectly
>be false?
>We do anyway define it in seedrng.c if needed.
Indeed, maybe it should be
Hi,
About:
>> HAVE_GETRANDOM := $(shell printf '#include \n#include
>> \nint main(void){char
>> buf[256];\ngetrandom(buf,sizeof(buf),GRND_NONBLOCK);}' >bb_libtest.c; $(CC)
>> $(CFLAGS) $(CFLAGS_busybox) -D_GNU_SOURCE -o /dev/null
Is it a good idea to have GRND_NONBLOCK in that check? What if
On 4/19/23 14:52, Kang-Che Sung wrote:
Just my two cents...
On Wednesday, April 19, 2023, Raphaël Mélotte mailto:raphael.melo...@mind.be>> wrote:
> +# Not all libc versions have getrandom, so check for it.
> +HAVE_GETRANDOM := $(shell printf '#include \n#include \nint main(void){char
Just my two cents...
On Wednesday, April 19, 2023, Raphaël Mélotte
wrote:
> +# Not all libc versions have getrandom, so check for it.
> +HAVE_GETRANDOM := $(shell printf '#include \n#include
\nint main(void){char
buf[256];\ngetrandom(buf,sizeof(buf),GRND_NONBLOCK);}' >bb_libtest.c; $(CC)
glibc <= 2.24 does not provide getrandom(). A check for it has been
added in 200a9669fbf6f06894e42439fc11a1a6073a and fixed in
cb57abb46f06f4ede8d9ccbdaac67377fdf416cf.
However, building with a libc other than glibc can lead to the same
problem as not every other libc has getrandom() either:
