Re: [PATCH v2] vi: allow writing to another file if this one is readonly

2021-04-13 Thread Denys Vlasenko
Applied, thanks On Sun, Apr 4, 2021 at 5:30 PM Alison Winters wrote: > > Version 2. Same change but rebased after Ron's improvements. Fixes bug > where if you open a read only file, you can't save it as a different > filename. > > --- > editors/vi.c | 5 ++--- > 1 file changed, 2 insertions(+)

Re: [PATCH] build system: avoid build failure during bisection

2021-04-13 Thread Denys Vlasenko
Applied, thanks On Sat, Apr 3, 2021 at 9:58 AM Ron Yorston wrote: > > Commit 4bdc914ff (build system: fix compiler warnings) added a > test on the return value of fgets() in split-include.c. > > During bisection it's possible to go back to a state where a > configuration value didn't exist. This

Re: [PATCH v3] watchdog: make open-write-close-open functionality a config knob

2021-04-13 Thread Denys Vlasenko
Applied, thank you On Tue, Apr 6, 2021 at 10:15 AM Rasmus Villemoes wrote: > > The behaviour introduced by commit 31c765081dc4 ("watchdog: stop > watchdog first on startup") causes warnings in the kernel log when the > nowayout feature is enabled: > > [ 16.212184] watchdog: watchdog0: nowayout

Re: [PATCH v2 3/3] touch: add --time=what option

2021-04-13 Thread Denys Vlasenko
> #if ENABLE_FEATURE_TOUCH_SUSV3 > char *reference_file = NULL; > char *date_str = NULL; > +IF_LONG_OPTS(char *time_arg = NULL;) These are actually long-ish insns (on x86, "mov immediate" (and "test") has no byte-extending version, unlike ALU ops). Sometimes it's cheaper to test if

Re: [PATCH 2/3] touch: prevent usage of -r and -t at once

2021-04-13 Thread Denys Vlasenko
Applied, thanks On Mon, Apr 12, 2021 at 11:32 PM Xabier Oneca -- xOneca wrote: > > coreutils forbids this combination. > > Signed-off-by: Xabier Oneca > --- > coreutils/touch.c | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/coreutils/touch.c b/coreu

Re: [PATCH v2] touch: switch to using utimensat() and futimens()

2021-04-13 Thread Denys Vlasenko
Applied, thank you On Sun, Apr 11, 2021 at 7:44 AM urmum-69 wrote: > > This patch changes the functions used to update timestamps in touch. > > Before, utimes() and lutimes() were used, which had certain > disadvantages. > They are unable to handle nanosecond timestamps, and implementations of >

Re: [PATCH v2 3/3] touch: remove unneeded GETOPT32 defines

2021-04-12 Thread Denys Vlasenko
Applied all 3 patches. Thank you. On Sat, Apr 10, 2021 at 12:44 AM Xabier Oneca -- xOneca wrote: > > > Long options handling (getopt32 vs getopt32long) is done in libb.h, no need > > to > > care here of the same logic. This cleans the code a bit. > > > > Also, --no-create was grouped as a SUSv3

Re: [PATCH] lineedit: fix tab completion with equal sign

2021-04-10 Thread Denys Vlasenko
Applied, thank you On Fri, Apr 9, 2021 at 5:10 PM Natanael Copa wrote: > > Fix tab completion for the path when equal sign (=) is used. For > example: dd if=/dev/ze > > Signed-off-by: Natanael Copa > --- > > I have used busybox ash as the primary shell for over a decade. This > tiny feature will

Re: [PATCH 00/11] vi: yet more patches

2021-04-10 Thread Denys Vlasenko
Applied all 11, thank you! On Tue, Apr 6, 2021 at 2:39 PM Ron Yorston wrote: > > Another assortment of vi patches. > > Maybe this time I've finally sorted out movement by word. > > Or maybe not. > > Ron > ___ > busybox mailing list > busybox@busybox.net

Re: [PATCH] vi: deal with invalid movements in shift commands

2021-03-30 Thread Denys Vlasenko
Applied, thank you. On Tue, Mar 30, 2021 at 2:02 PM Ron Yorston wrote: > > Since commit 25d259264 (vi: make buffer handling more vi-like) > find_range() can return early when an invalid movement is > specified. > > The call to find_range() in the code that handles shift commands > ('<' and '>') d

Re: [PATCH 0/10] vi: more patches

2021-03-29 Thread Denys Vlasenko
Applied both patch sets. Thank you. On Sun, Mar 28, 2021 at 2:18 PM Ron Yorston wrote: > > I've been working through my copy of 'The Ultimate Guide to the Vi > and Ex Text Editors' fixing things I find are different in BusyBox vi. > Currently I'm half way through chapter 5. > > These patches shou

Re: [PATCH 1/1] libbb: fix parse_duration_str with LOCALE_SUPPORT

2021-03-26 Thread Denys Vlasenko
Applied, thank you. On Mon, Mar 22, 2021 at 6:21 AM Maxim Kochetkov wrote: > > Decimal dot may differs from ".", so we need to set LC_NUMERIC to "C" before > processing duration string by strtod() > > Signed-off-by: Maxim Kochetkov > --- > coreutils/sleep.c | 4 > libbb/duration.c | 7 +++

Re: TLS Support in Busybox syslogd

2021-03-16 Thread Denys Vlasenko
On Sat, Mar 13, 2021 at 6:53 PM Mike <6502...@gmail.com> wrote: > > No offense intended, but are you serious? The code bloat from adding tls > support would completely invalidate the whole purpose of using busybox in the > first place. We do have TLS code in bbox (as otherwise wget would be near

Re: [PATCH v2] udhcpc: ignore zero-length DHCP options

2021-03-16 Thread Denys Vlasenko
Applied, thanks. On Tue, Mar 16, 2021 at 7:52 AM Russell Senior wrote: > > > Discovered that the DHCP server on a TrendNet router (unknown model) > provides a zero-length option 12 (Host Name) in the DHCP ACK message. This > has the effect of causing udhcpc to drop the rest of the options, includ

Re: Issues with reading ncurses man pages

2021-03-10 Thread Denys Vlasenko
On Sun, Feb 7, 2021 at 3:49 AM depsterr wrote: > > Hi, I'm trying to open some ncurses man pages in busybox man, however it's > not possible as these files are suffixed .3x instead of .3 (even though > they're in section 3). > > Currently busybox man assumes the man page will have the same "titl

Re: HUSH_LINENO_VAR without HUSH_BASH_COMPAT

2021-03-10 Thread Denys Vlasenko
Applied, thanks On Fri, Feb 5, 2021 at 5:28 PM wrote: > > Hi, > > It turns out that HUSH_LINENO_VAR works fine without HUSH_BASH_COMPAT. > Maybe we could allow configuring such a build? > > -- > ___ > busybox mailing list > busybox@busybox.net > http://

Re: [PATCH] hwclock: Check for SYS_settimeofday before calling syscall

2021-03-09 Thread Denys Vlasenko
On Mon, Mar 8, 2021 at 2:34 AM Khem Raj wrote: > > Some newer architectures e.g. RISCV32 have 64bit time_t from get go and > thusly do not have gettimeofday_time64/settimeofday_time64 implemented > therefore check for SYS_settimeofday definition before making the > syscall. Fixes build for riscv32

Re: [PATCH] wget: new option FEATURE_WGET_FTP to enable/disable FTP

2021-03-09 Thread Denys Vlasenko
Applied, except for - h->protocol = P_FTP; + h->protocol = NULL; bit (->protocol[0] must exist). On Sun, Jan 17, 2021 at 7:35 PM Sergey Ponomarev wrote: > > Introduce a separate option FTPS_SUPPORTED instead of not obvious > ENABLE_FEATURE_WGET_HTTPS. > > function

Re: [PATCH v2] bloat-o-meter: avoid double counting

2021-03-09 Thread Denys Vlasenko
Applied, thanks On Mon, Mar 8, 2021 at 8:31 PM Ron Yorston wrote: > > Disable 'echo' in the default config, run 'make baseline', then > re-enable 'echo' and run 'make bloatcheck': > > function old new delta > .rodata

Re: Traceroute bug in 1.33 release (please apply patch from master)

2021-03-08 Thread Denys Vlasenko
Done. On Mon, Mar 8, 2021 at 8:06 AM Lauri Kasanen wrote: > > Hi, > > Traceroute on the 1.33 release is buggy "traceroute: NO OPT x!". The > patch on master, commit f3a55b306ed3 "traceroute: fix option parsing" > fixes it. > > Please apply this patch to the 1.33 branch. > > - Lauri >

Re: [PATCH] vi: restore 0 offset after :set noXXX command

2021-03-01 Thread Denys Vlasenko
Applied, thank you. On Sun, Feb 28, 2021 at 12:19 AM Alison Winters wrote: > > Fixes bug where commands after the first noXXX command are ignored. > e.g. :set noic tabstop=4 > --- > editors/vi.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/editors/vi.c b/

Re: Issues with scripts/trylink

2021-02-23 Thread Denys Vlasenko
On Tue, Feb 23, 2021 at 1:30 PM Laurent Bercot wrote: > >Aha. We have CONFIG_EXTRA_LDLIBS. We just need to change the logic > >so that it is not appended to LDLIBS, but treated separately, > >with no elision. > > That would be nice, thanks. Of course, they should be added to > the line *before*

Re: [PATCH v2] echo: do not assume that free() leaves errno unmodified

2021-02-23 Thread Denys Vlasenko
Applied, thank you. On Tue, Feb 23, 2021 at 12:31 PM Natanael Copa wrote: > > On Fri, 22 Jan 2021 08:35:55 +0100 > Natanael Copa wrote: > > > musl libc's mallocng free() may modify errno if kernel does not support > > MADV_FREE which causes echo to echo with error when it shouldn't. > > > > Futu

Re: Issues with scripts/trylink

2021-02-23 Thread Denys Vlasenko
On Tue, Feb 23, 2021 at 12:44 PM Denys Vlasenko wrote: > On Sat, Feb 13, 2021 at 3:23 PM Laurent Bercot > wrote: > > An example is utmp functionality with the musl C library: musl > > provides utmpx.h stubs that do nothing, and the utmps library > > ( https://skarnet.o

Re: Issues with scripts/trylink

2021-02-23 Thread Denys Vlasenko
On Sat, Feb 13, 2021 at 3:23 PM Laurent Bercot wrote: > Greetings, > > busybox is linked via the scripts/trylink shell script. I have > found a couple issues with trylink's management of additional libraries: > > > 1. https://git.busybox.net/busybox/tree/scripts/trylink#n123 > > This "saniti

Re: [PATCH] lineedit: support empty PATH entries in tab completion

2021-02-23 Thread Denys Vlasenko
Applied, thank you! On Thu, Feb 18, 2021 at 10:50 AM Ron Yorston wrote: > > Zero-length path prefixes can be specified in PATH as a leading or > trailing colon or two adjacent colons. POSIX says that the use of > zero-length prefixes to refer to the current directory is a legacy > feature. None

Re: [PATCH] diff: code shrink

2021-02-22 Thread Denys Vlasenko
Applied, thank you On Tue, Feb 16, 2021 at 10:09 AM Ron Yorston wrote: > > function old new delta > diff_main 15151495 -20 >

Re: [PATCH] libbb: '--help' handling in standalone shell mode

2021-02-18 Thread Denys Vlasenko
Thank you for finding this bug. I committed a somewhat different fix, one which factors out the code to detect --help (some applets opt out of handling it specially). On Thu, Feb 18, 2021 at 8:44 AM Ron Yorston wrote: > > Most BusyBox applets respond to the '--help' option by printing > a usage m

Re: [PATCH] build system: prevent breakage by over-zealous CFLAGS

2021-02-18 Thread Denys Vlasenko
I fixed that, but then ash.c also throws a similar error, so fixed that as well. Thank you. On Sun, Feb 14, 2021 at 9:38 AM Ron Yorston wrote: > > A user reports that the use of "-Werror=format-security" in > HOSTCFLAGS prevents usage_pod from building. > > Signed-off-by: Ron Yorston > --- > a

Re: Issues with applets/usage_pod.c

2021-02-15 Thread Denys Vlasenko
--- a/applets/usage_pod.c +++ b/applets/usage_pod.c @@ -71,7 +71,7 @@ int main(void) } else { printf(", "); } - printf(usage_array[i].aname); + printf("%s", usage_array[i].aname); col += len2;

Re: [PATCH] libbb: introduce and use fputs_stdout

2021-02-03 Thread Denys Vlasenko
networking/httpd_ssi.c should not be touched. Applied excluding that chunk. Thank you. On Thu, Jan 21, 2021 at 1:09 PM Ron Yorston wrote: > > function old new delta > fputs_stdout - 12 +12 > zxc_

Re: [PATCH] libbb: code shrink fgets_str

2021-02-03 Thread Denys Vlasenko
Applied, thanks! On Sat, Jan 23, 2021 at 2:22 PM Ron Yorston wrote: > > Use a NULL value of maxsz_p to indicate to xmalloc_fgets_internal() > that the caller doesn't care about the maximum size of the buffer. > This allows the default maximum size to be set once in > xmalloc_fgets_internal() inst

Re: [PATCH] nl: ensure '-b n' option displays file content

2021-02-02 Thread Denys Vlasenko
Applied, thanks! On Thu, Jan 21, 2021 at 9:41 AM Ron Yorston wrote: > > The command 'nl -b n' should output no line numbers, just some > spaces as a placeholder followed by the actual file content. > > Add tests for line numbering by cat and nl. The correct results > were obtained from coreutils

Re: [PATCH] cryptpw: typo in usage message

2021-02-02 Thread Denys Vlasenko
Applied, thank you. On Tue, Jan 26, 2021 at 2:02 PM Ron Yorston wrote: > > '[-p N]' should be '[-P N]' in the trivial usage message. > > Signed-off-by: Ron Yorston > --- > loginutils/cryptpw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/loginutils/cryptpw.c b/loginu

Re: [PATCH] vi: fix range selection by forward character motion

2021-02-02 Thread Denys Vlasenko
Applied, thanks! On Mon, Feb 1, 2021 at 12:54 PM Ron Yorston wrote: > > Selection of ranges for change/delete/yank by forward character > motion commands (SPACE or 'l') was incorrect. The range was > always one character whereas vi allows the size of the range to > be specified. > > Fix this by

Re: [PATCH] libbb: code shrink and speed up index_in_strings()

2021-02-02 Thread Denys Vlasenko
Applied, thanks! On Fri, Jan 29, 2021 at 2:23 PM Ron Yorston wrote: > > Rewrite index_in_strings() to replace calls to strcmp()/strlen(). > With this change searching for valid names in the applet_names > array (for example) is 40% faster. > > The code has to assume the strings aren't sorted, so

Re: [PATCH] libbb: code shrink and speed up find_applet_by_name()

2021-02-02 Thread Denys Vlasenko
Applied, thanks! On Fri, Jan 29, 2021 at 2:23 PM Ron Yorston wrote: > > find_applet_by_name() determines the appropriate range of applet > indices to check for the given name and performs a linear search in > applet_names[]. > > Revise the code so the index of the upper bound of the range, 'max',

Re: [PATCH] awk: allow printf('%c') to output NUL, closes 13486

2021-02-02 Thread Denys Vlasenko
Applied, thanks! On Wed, Jan 27, 2021 at 12:19 PM Ron Yorston wrote: > > Treat the output of printf as binary rather than a null-terminated > string so that NUL characters can be output. > > This is considered to be a GNU extension, though it's also available > in mawk and FreeBSD's awk. > > func

Re: [PATCH 1/1] update_passwd: fix context variable

2021-01-14 Thread Denys Vlasenko
Applied, thanks On Sun, Jan 10, 2021 at 1:20 PM Bernd Kuhls wrote: > > Commit > https://git.busybox.net/busybox/commit/libbb/update_passwd.c?id=2496616b0a8d1c80cd1416b73a4847b59b9f969a > > changed the variable used from context to seuser but forgot this > change resulting in build errors detected

Re: parameter expansion with uninitialized variable

2021-01-08 Thread Denys Vlasenko
Indeed. Fixed in git just now. On Fri, Jan 8, 2021 at 9:53 PM Christian Hesse wrote: > > Hello everybody, > > with busybox 1.32 shell's parameter expansion starts to fail with > uninitialized variables. > > Set a variable and echo, replacing comma with space: > > ~ $ test=abc,def > ~ $ echo ${tes

Re: Tags for 1_33_0 and 1_32_1

2021-01-08 Thread Denys Vlasenko
Done On Thu, Jan 7, 2021 at 5:25 PM Martin Kaiser wrote: > > Hi Denys and all, > > I just saw that 1.33.0 and 1.32.1 were released some days ago. However, > there are no tags for them in the git repository. Would you mind adding > them? > > Thanks & Best regards, > Martin > __

Re: Problem with HISTFILE

2021-01-07 Thread Denys Vlasenko
Fixed by this? commit 3f8ec00b0c54790283cfec675716ef4b8e00bd8a Author: Denys Vlasenko Date: Sun Jan 3 10:55:39 2021 +0100 ash: make a strdup copy of $HISTFILE for line editing On Thu, Jan 7, 2021 at 9:11 AM Olivier JAVAUX wrote: > > > Hello, > > When I try to setu

Re: [PATCH] Fix for the FEATURE_UTMP on the FreeBSD

2021-01-04 Thread Denys Vlasenko
Applied, thank you. On Mon, Jan 4, 2021 at 7:35 PM Alex Samorukov wrote: > > FreeBSD is not using and does not define _PATH_UTMPX. > Tested with busybox applets depending on FEATURE_UTMP (e.g. who, users, etc) > > Signed-off-by: Alex Samorukov > --- > include/libbb.h | 4 > 1 file changed

Re: AW: [PATCH] ash: Load $ENV file also if $SSH_CLIENT/SSH2_CLIENT is preset in env, reformat

2021-01-04 Thread Denys Vlasenko
On Mon, Jan 4, 2021 at 8:48 PM Björn Bidar wrote: > Am Montag, 4. Januar 2021, 14:43:46 EET schrieben Sie: > > > > Please explain your real-world scenario which prompted you > > > > to create the patch. > > > > > > The real world scenario is that a user might run commands via ssh on a > > > device

Re: Nuke

2021-01-04 Thread Denys Vlasenko
On Mon, Jan 4, 2021 at 5:43 PM Tim Tassonis wrote: > On 1/3/21 4:31 PM, Denys Vlasenko wrote: > > On Sun, Jun 21, 2020 at 4:56 AM Eli Schwartz > > wrote: > >> On 6/20/20 7:26 AM, Mike Davies wrote: > >>> So whos brilliant idea was it to select 'nuke

Re: [PATCH] Fix traceroute applet on the FreeBSD

2021-01-04 Thread Denys Vlasenko
Applied 10 patches. Thank you. On Mon, Jan 4, 2021 at 1:41 AM Alex Samorukov wrote: > > This patch addressing 2 issues: > > 1. Replacing source/dest with uh_sport/uh_dport. It seems that uh_* members > are >defined on both Linux and BSD, so no #ifdef here > 2. Use SOL_IPV6 instead of SOL_RAW

Re: Nuke

2021-01-03 Thread Denys Vlasenko
On Sun, Jun 21, 2020 at 4:56 AM Eli Schwartz wrote: > On 6/20/20 7:26 AM, Mike Davies wrote: > > So whos brilliant idea was it to select 'nuke' to be built by default ? Almost all options are "on" by default. There should be a special reason (documented in a comment) why option is off by default

Re: FreeBSD patches

2021-01-03 Thread Denys Vlasenko
On Sun, Jan 3, 2021 at 9:10 AM Alex Samorukov wrote: > Hi, > > I am using BusyBox on FreeBSD, mostly on my embedded toys. As result i > started to maintain port of it in the ports tree. > > Some of the applets require patches to build, so i decided to share them > with upstream. I am using GH with

Re: AW: [PATCH] ash: Load $ENV file also if $SSH_CLIENT/SSH2_CLIENT is preset in env, reformat

2021-01-03 Thread Denys Vlasenko
On Mon, Nov 2, 2020 at 3:13 PM Björn Bidar wrote: > >Would you mind to drop a few words what bash does in such cases ? > It does exactly what ash does with but it load bashrc instead of $ENV like in > the patch. > See man bash: "Bash attempts to determine when it is being run with its > standard

Re: [PATCH v1] modprobe: Fix memory leak

2021-01-02 Thread Denys Vlasenko
Let's not do this, saving code size: modprobe is not a long-running program. On Tue, Dec 22, 2020 at 3:12 PM Andy Shevchenko wrote: > Free command line options after parsing. > > Fixes: e4202df0918e ("modprobe: Add support for > modprobe.blacklist=module1,module2,...&

Re: Busybox modprobe hitch with kernel 5.10

2021-01-02 Thread Denys Vlasenko
On Sun, Jan 3, 2021 at 2:59 AM Qu Wenruo wrote: > >> If you really want to make finit_modules() to support compressed module, > >> purpose a new system call other than changing something which already > >> has a clear and simple spec. > > > > I decided to just wait when inevitably someone adds tha

Re: Busybox modprobe hitch with kernel 5.10

2021-01-02 Thread Denys Vlasenko
On Sat, Jan 2, 2021 at 2:48 AM Qu Wenruo wrote: > On 2021/1/1 下午7:05, Denys Vlasenko wrote: > > I propose this simple fix: > > > > if (not_a_good_ELF_image(image_ptr)) { > > + if (!not_GZIP_signature(image_ptr) > > +

Re: [PATCH] udhcpc: Add support to change default interface name

2021-01-01 Thread Denys Vlasenko
Applied, sorry for the delay On Tue, May 5, 2020 at 8:59 PM Andre Kalb wrote: > > > Signed-off-by: Andre Kalb > --- > networking/udhcp/Config.src | 8 > networking/udhcp/d6_dhcpc.c | 4 ++-- > networking/udhcp/dhcpc.c| 4 ++-- > 3 files changed, 12 insertions(+), 4 deletions(-) > >

Re: Busybox modprobe hitch with kernel 5.10

2021-01-01 Thread Denys Vlasenko
On Thu, Dec 31, 2020 at 2:04 AM Qu Wenruo wrote: > On 2020/12/31 上午8:50, Denys Vlasenko wrote: > > On Thu, Dec 31, 2020 at 1:45 AM Qu Wenruo wrote: > >> If kernel is really going to detect compressed module, the decompression > >> should happen before we check the

Re: Busybox modprobe hitch with kernel 5.10

2020-12-30 Thread Denys Vlasenko
On Thu, Dec 31, 2020 at 1:45 AM Qu Wenruo wrote: > >> Ah, I see what's happening. modprobe normally tries finit_module() > >> first, and falls back to init_module() for compressed modules, which > >> is the case here. We added new error messages as part of an effort to > >> demystify module loader

Re: Busybox modprobe hitch with kernel 5.10

2020-12-30 Thread Denys Vlasenko
On Wed, Dec 30, 2020 at 12:28 PM Jessica Yu wrote: > +++ Lauri Kasanen [30/12/20 10:08 +0200]: > >On Tue, 29 Dec 2020 22:05:21 +0100 > >Denys Vlasenko wrote: > > > >> On Mon, Dec 28, 2020 at 6:15 PM Lauri Kasanen wrote: > >> > Hi, > >> > &

Re: [PATCH 1/1] httpd: fix offset for sendfile

2020-12-29 Thread Denys Vlasenko
Applied, thank you On Tue, Dec 29, 2020 at 4:29 PM Maxim Storchak wrote: > > If the Range: header is not present it the request, > the offset passed to sendfile is wrong, > and httpd falls back to the read-write loop. > > Signed-off-by: Maxim Storchak > --- > networking/httpd.c | 2 +- > 1 file

Re: Busybox modprobe hitch with kernel 5.10

2020-12-29 Thread Denys Vlasenko
On Mon, Dec 28, 2020 at 6:15 PM Lauri Kasanen wrote: > Hi, > > On Busybox 1.31.1, modprobing any module for the 5.10 kernel prints a > nasty message: > Module has invalid ELF header > > but the module loads successfully after that. So looks like bb tries > two paths, the first fails, second succee

Re: Add possiblity to support specifying desired section of manpage

2020-12-27 Thread Denys Vlasenko
miscutils/man.c: In function ‘man_main’: miscutils/man.c:343:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 343 | char sect_str[3]; | ^~~~ miscutils/man.c:395:4: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-stat

Re: [PATCH] mount: Surround syslog.h with the config check

2020-12-26 Thread Denys Vlasenko
Applied, thank you On Mon, Dec 21, 2020 at 5:54 PM Lauri Kasanen wrote: > > This lets bb mount build for limited targets without syslog.h, > as long as the parts using it like NFS are disabled. > > Signed-off-by: Lauri Kasanen > --- > util-linux/mount.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [PATCH v1] modprobe: Add support for modprobe.blacklist=module1, module2, ...

2020-12-21 Thread Denys Vlasenko
On Tue, Nov 3, 2020 at 4:31 PM Andy Shevchenko wrote: > > Add support for modprobe.blacklist=module1,module2,... > > On x86_64 (Debian Unstable) it gives +79 bytes. > > function old new delta > parse_and_add_kcmdline_module_options

Re: "ping URL -w 6" always fail (1.31.x until now)

2020-12-20 Thread Denys Vlasenko
Fixed, thanks! On Sat, Dec 19, 2020 at 7:50 PM Justin Jiang wrote: > > Please any busybox maintainers help to assess and merge the following patch > for ping.c, thanks. > > https://bugs.busybox.net/show_bug.cgi?id=13401 > > ping someurl with -w arguments, it always failed > > ### EXAMPLE OUTPUT

Re: [PATCH 1/1] loop device: report mount failure in case of set_loop failure

2020-12-17 Thread Denys Vlasenko
On Wed, Dec 9, 2020 at 9:21 PM Thomas De Schampheleire wrote: > El mié, 9 dic 2020 a las 21:16, Denys Vlasenko > () escribió: > > On Wed, Dec 9, 2020 at 9:08 PM Thomas De Schampheleire > > wrote: > > > > On Wed, Dec 9, 2020 at 10:19 AM Thomas De Schampheleire

Re: [PATCH] lineedit: match local directories when searching PATH

2020-12-16 Thread Denys Vlasenko
Applied both patches, thank you. On Fri, Dec 11, 2020 at 1:34 PM Ron Yorston wrote: > > When tab-completing a command we search PATH if the partial text > doesn't include a slash. Also match subdirectories of the current > directory, in case the user intends to run a binary from one of > them. >

Re: [PATCH] udhcp: bind to device even for ucast packets

2020-12-15 Thread Denys Vlasenko
applied, thanks On Tue, Dec 15, 2020 at 10:54 AM Michal Kazior wrote: > > From: Michal Kazior > > There are cases where binding to source IP and > destination IP is insufficient to guarantee sane > xmit netdev. > > One case where this can fail is when > route-matching netdev carrier is down (cab

Re: [PATCH] dd: implement iflag=direct and oflag=direct

2020-12-14 Thread Denys Vlasenko
Aplied with some changes. Thank you. On Sat, Dec 12, 2020 at 10:28 AM Akash Hadke wrote: > > Package: busybox > Version: v1.31.1 > Severity: wishlist > > > This implementation assumes that iflag/oflag=direct will be used only on > block devices and files that are multiples of pagesize, and makes

Re: [PATCH] Fix nsenter option parsing

2020-12-11 Thread Denys Vlasenko
Applied, thanks. On Thu, Dec 10, 2020 at 11:54 PM Thomas Lidén wrote: > > Usage: nsenter [OPTIONS] [PROG [ARGS]] > Stop nsenter from processing ARGS to PROG as OPTIONS. > e.g. "nsenter ls -l" gives: invalid option -- 'l' > > diff --git a/util-linux/nsenter.c b/util-linux/nsenter.c > index c48dcf8

Re: Traceroute ICMP option doesn't work

2020-12-11 Thread Denys Vlasenko
On Thu, Dec 10, 2020 at 1:23 PM M K Verma wrote: > Are you aware of how -I(ICMP) can be fixed on Busybox? > I have gone through the code, tested and I see the -I(ICMP) is sent instead > of UDP in case of IPv4 hosts when a flag is enabled in the defconfig. > > The same does not work out in case of

Re: [PATCH 1/1] loop device: report mount failure in case of set_loop failure

2020-12-09 Thread Denys Vlasenko
On Wed, Dec 9, 2020 at 9:08 PM Thomas De Schampheleire wrote: > > On Wed, Dec 9, 2020 at 10:19 AM Thomas De Schampheleire > > wrote: > > > From: Philippe Belet > > > > > > When mounting, in parallel, multiple loop devices (squashfs for the > > > submitter's case), the following behavior can be o

Re: [PATCH 1/1] loop device: report mount failure in case of set_loop failure

2020-12-09 Thread Denys Vlasenko
On Wed, Dec 9, 2020 at 10:19 AM Thomas De Schampheleire wrote: > From: Philippe Belet > > When mounting, in parallel, multiple loop devices (squashfs for the > submitter's case), the following behavior can be observed: > > stat64(/path/to/image, {st_mode=S_IFREG|0644, st_size=4096, ...}) = 0 > op

Re: Traceroute ICMP option doesn't work

2020-12-09 Thread Denys Vlasenko
On Wed, Dec 9, 2020 at 3:28 PM M K Verma wrote: > Do you guys see traceroute -6 www.cisco.com completing for you ? My network has no IPv65 > The same command with -I(ICMP) completes in Linux PC. > > Will this be fixed someday on the Busybox? There is a bug that's still open > apparently. > trac

Re: Traceroute ICMP option doesn't work

2020-12-08 Thread Denys Vlasenko
On Tue, Dec 8, 2020 at 5:39 AM M K Verma wrote: > Hi Busybox, > > Package: Busybox > Version: 1.29.3 > > We see that traceroute with -6 or traceroute6 never succeeds to trace some of > the sites that filter UDP packets, for example www.cisco.com, www.nokia.com > and so on. > > We see the issue w

Re: [PATCH] mkdtemp: proper error detection on mktemp

2020-12-08 Thread Denys Vlasenko
applied, thanks On Fri, Dec 4, 2020 at 8:53 AM Alexander Dahl wrote: > > Hei hei, > > Am Donnerstag, 3. Dezember 2020, 23:42:24 CET schrieb Xabier Oneca -- xOneca: > > On error, mktemp returns an empty string, not NULL. > > > > Signed-off-by: Xabier Oneca > > --- > > libbb/platform.c | 2 +- > >

Re: [PATCH] tar: updated help

2020-12-08 Thread Denys Vlasenko
On Wed, Dec 2, 2020 at 7:53 PM Christophe Vidal wrote: > > Do you prefer this version? It results in: ... -oDon't restore user:group --overwriteReplace existing files -kDon't replace existing files -Z(De)compress using compress -z(De)compress using gzip

Re: Logging of unsuccessful login attempts

2020-12-02 Thread Denys Vlasenko
Let's just do this: puts("Login incorrect"); + syslog(LOG_WARNING, "invalid password for '%s'%s", + username, fromhost); if (++count == 3) { - syslog(LOG_WARNING, "invalid password for '%s'%s"

Re: mount(8) unable to mount a device via symlink that contains ':'

2020-12-02 Thread Denys Vlasenko
On Wed, Dec 2, 2020 at 10:23 AM Misha Gusarov wrote: > There is a problem in mount(8) that prevents it from mounting a device > via a symlink > that contains a : symbol: > > $ mount -o bind /dev/disk/by-path/pci-:13:00.0-scsi-0:0:3:0 > /some/mount/point > mount: bad address '/dev/disk/by-path/

Re: [PATCH] tar: updated help

2020-12-02 Thread Denys Vlasenko
Please use tabs. If you use "--strip-components NUM" instead of "NUMBER", it'll line up nicely for 3-tab columns. On Mon, Nov 30, 2020 at 7:05 PM Christophe Vidal wrote: > > Hi, > > Here is a patch for tar that documents long options without a short option in > --help > > Long options documente

Re: [bug] dd piped input truncates ~1% of values to %4096 on multi-core systems

2020-11-30 Thread Denys Vlasenko
On Sun, Nov 29, 2020 at 2:21 PM John Thomson wrote: > I may have run into a bug where dd with piped input will truncate a small > number of results (~1%) to a modulo 4096 value on multi-core systems. > The test script does not produce errors running under bash. > This issue is not seen if dd read

Re: [PATCH] httpd: code shrink

2020-11-27 Thread Denys Vlasenko
On Tue, Oct 6, 2020 at 8:36 PM Xabier Oneca -- xOneca wrote: > Hi Bruno, > > If I understand correctly: > > > > decode_base64() from uuencode.c = bigger one > > decodeBase64(char *Data) from httpd.c = smaller one > > You understood it right. :) > > > Assuming they are equivalent (I didn't check),

Re: Placement of load_policy in /usr/sbin

2020-11-27 Thread Denys Vlasenko
Fedora still has it under /usr On Thu, Oct 15, 2020 at 5:09 PM Björn Bidar wrote: > > > I think it makes sense to move it to /sbin since there seems to be a > > general move away from /usr AFAI have heard. > Isn't it more the opposite by using /usr/{s,}bin but keeping /{s,}bin as a > synmlink onl

Re: [PATCH 7/8] mdev: add SIGHUP handler to reload configuration

2020-11-22 Thread Denys Vlasenko
This is bloat. There is no rule every daemon should understand SIGHUP. On Mon, Dec 16, 2019 at 10:57 PM Jan Klötzke wrote: > > Like a well behaved daemon the reception of SIGHUP triggers a reload of > /etc/mdev.conf. The file is parsed immediately to catch any errors early > and to cache the curr

Re: [PING] mdev: improve daemon operation

2020-11-22 Thread Denys Vlasenko
Sorry for the delay. Thanks for the reminder. On Sat, Nov 21, 2020 at 11:54 AM Jan Klötzke wrote: > I posted a patch series for mdev almost a year ago: > > http://lists.busybox.net/pipermail/busybox/2019-December/087675.html Applied patches 1-6. Thank you. _

Re: [PING] mdev: improve daemon operation

2020-11-22 Thread Denys Vlasenko
This is bloat. There is no rule every daemon should understand SIGHUP. On Sat, Nov 21, 2020 at 11:54 AM Jan Klötzke wrote: > > Hi, > > I posted a patch series for mdev almost a year ago: > > http://lists.busybox.net/pipermail/busybox/2019-December/087675.html > > It improves the reliability of

Re: [PATCH 5/8] mdev: add syslog logging mode

2020-11-22 Thread Denys Vlasenko
Applied, thanks On Mon, Dec 16, 2019 at 10:57 PM Jan Klötzke wrote: > > If mdev is run as daemon it should be possible to forward the debug > messages to syslog. This feature might be useful if mdev is run with -s > during boot too. OTOH it makes no sense for the daemon to log to > mdev.log. This

Re: [PATCH 4/8] mdev: re-initialize if uevent messages were lost

2020-11-22 Thread Denys Vlasenko
Applied, thanks On Mon, Dec 16, 2019 at 10:57 PM Jan Klötzke wrote: > > If the netlink read() failed with ENOBUFS we know that we have missed at > least one message due to a socket receive buffer overrun. The only way > how to recover is to drop the old socket, open a fresh one and make a > cold-

Re: [PATCH 3/8] mdev: move daemon setup to dedicated function

2020-11-22 Thread Denys Vlasenko
Applied, thanks On Mon, Dec 16, 2019 at 10:57 PM Jan Klötzke wrote: > > Signed-off-by: Jan Klötzke > --- > util-linux/mdev.c | 44 +++- > 1 file changed, 27 insertions(+), 17 deletions(-) > > diff --git a/util-linux/mdev.c b/util-linux/mdev.c > index 4e32

Re: [PATCH 6/8] mdev: add -v to increase log verbosity

2020-11-22 Thread Denys Vlasenko
Applied, thanks. On Mon, Dec 16, 2019 at 10:57 PM Jan Klötzke wrote: > > If logging to stderr and/or syslog the -v option can be given one or > more times to increase the log verbosity. If mdev is used as hotplug > helper the log level is fixed set to 2 if mdev.log is found an appended > because

Re: [PATCH 2/8] mdev: increase netlink buffer sizes

2020-11-22 Thread Denys Vlasenko
Applied, thank you On Mon, Dec 16, 2019 at 10:57 PM Jan Klötzke wrote: > > The socket receive buffer turned out to be too small for real world > systems. Use the same size as udevd to be on the safe side. As this is > just a limit and the memory is not allocated by the kernel until really > neede

Re: [PATCH 1/8] libbb: set netlink socket revbuf size before binding

2020-11-22 Thread Denys Vlasenko
Applied, thank you. On Mon, Dec 16, 2019 at 10:57 PM Jan Klötzke wrote: > > As soon as the socket is bound it will receive messages. Make sure the > recieve buffer size is increased before the first message is received. > > Signed-off-by: Jan Klötzke > --- > libbb/xconnect.c | 15 +-

Re: [PATCH] lineedit: fix unicode characters in prompt

2020-11-21 Thread Denys Vlasenko
Applied, thanks. On Sat, Nov 21, 2020 at 2:06 PM Audun M. Gangstø wrote: > > Hi, > > This little patch should make single-width unicode characters in the prompt > work properly. > > -- > Best regards, > Audun M. Gangstø > > ___ > busybox mailing list >

Re: Ping for a patch

2020-11-21 Thread Denys Vlasenko
Done. Sorry On Tue, Nov 17, 2020 at 3:10 PM Norbert Lange wrote: > > Hello, > > would be nice if this were to be included in the next version: > > http://lists.busybox.net/pipermail/busybox/2020-July/088131.html > > Norbert > ___ > busybox mailing list

Re: [PATCH] flashcp copy only different blocks

2020-11-21 Thread Denys Vlasenko
Sorry for the delay. On Mon, Oct 26, 2020 at 10:24 AM Harvey Wu (吳崇維) wrote: > The original flashcp process is erase, write and verify all blocks > in one time from file to device. > This patch will add a function that only copy different block data > from file to device. The function will compar

Re: warning: label 'out1' defined but not used

2020-11-19 Thread Denys Vlasenko
Applied, thanks. On Wed, Nov 18, 2020 at 10:41 AM Cristian Ionescu-Idbohrn wrote: > > I'm seeing this warning: > > shell/ash.c: In function 'subevalvar': > shell/ash.c:7280:2: warning: label 'out1' defined but not used > [-Wunused-label] > 7280 | out1: > | ^~~~ > > It appears this patch

Re: [PATCH v2] util-linux: support erofs filesystem

2020-11-18 Thread Denys Vlasenko
Applied, thank you. On Mon, Jul 13, 2020 at 5:22 PM Norbert Lange wrote: > > Add erofs to the known volume_ids. > > Signed-off-by: Norbert Lange > --- > util-linux/volume_id/erofs.c | 71 +++ > util-linux/volume_id/volume_id.c | 3 + > util-linux/volum

Re: [PATCH] ifupdown: basic support for bridge_ports

2020-11-17 Thread Denys Vlasenko
On Sat, May 9, 2020 at 4:38 PM Joachim Nilsson wrote: > > This patch adds basic support for setting up bridges with ifupdown. > The implementation is limited to listing actual interfaces in the > bridge_ports attribute of a stanza in /etc/network/interace: > > iface br0 inet static > a

Re: [PATCH] archival: avoid std namespace for local includes

2020-11-16 Thread Denys Vlasenko
Applied, thank you On Sat, May 9, 2020 at 1:31 PM Joachim Nilsson wrote: > > Avoid using same include file naming pattern as available in GLIBC. > Renamed to match grp_.h et al. > > Signed-off-by: Joachim Nilsson > --- > archival/ar.c | 2 +- > archival/libarchive/get_

Re: Resubmit batch of patches?

2020-11-16 Thread Denys Vlasenko
Thank you for the reminder, I'll review them now On Wed, Sep 9, 2020 at 7:28 PM Joachim Wiberg wrote: > > Hi Denys, > > way back in May this year I sent a bunch of patches. Considering > what's been going on in the world it feels like years ago ... I've > even changed my last name since then :)

Re: [RFC PATCH] httpd: handle HTTP upload case better

2020-11-16 Thread Denys Vlasenko
On Sat, May 9, 2020 at 1:26 PM Joachim Nilsson wrote: > When shutting down a connection right after an HTTP upload we must wait > a while for the client to see the response. > > Signed-off-by: Joachim Nilsson > --- > networking/httpd.c | 15 +-- > 1 file changed, 9 insertions(+), 6 d

Re: [PATCH] ash: allow Ctrl-C to abort PS2, like Bash and Dash

2020-11-16 Thread Denys Vlasenko
Applied, thank you On Sat, May 9, 2020 at 12:04 PM Joachim Nilsson wrote: > > Prior to patch: > > $ ' > > Ctrl-C > > > > I.e., not possible to breaḱ out from PS2 prompt, unless inputing final > quote character. Ctrl-D works, but this patch makes ash behave like > Bash and Dash: > >

Re: [PATCH] syslogd: delay PID file creation until syslogd is ready

2020-11-16 Thread Denys Vlasenko
Applied, thank you On Sat, May 9, 2020 at 4:49 PM Joachim Nilsson wrote: > > This patch moves the creation of the PID file until after syslogd has > set up signal handlers and is ready. > > Signed-off-by: Joachim Nilsson > --- > sysklogd/syslogd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 d

<    1   2   3   4   5   6   7   8   9   10   >