[PATCH] awk: fix ternary operator and precedence of =

the assignment is on the right side of a compare. This fixes commit 0256e00a9d07 (awk: fix precedence of = relative to ==) Signed-off-by: Natanael Copa --- editors/awk.c | 18 ++ testsuite/awk.tests | 9 +++-- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git

[PATCH] tests: add test for ternary precedence

This tests a regression introduced by commit 0256e00a9d07 (awk: fix precedence of = relative to ==). Signed-off-by: Natanael Copa --- testsuite/awk.tests | 5 + 1 file changed, 5 insertions(+) diff --git a/testsuite/awk.tests b/testsuite/awk.tests index 063084a1c..a56232d02 100755

Re: [PATCH] awk: fix use after free (CVE-2023-42363)

On Tue, 21 May 2024 08:46:46 +0200 Natanael Copa wrote: > > Current git master awk is also broken. > > A reproducer: > > busybox awk 'BEGIN { a = 0 ? "yes": "no"; print a}' > > Prints 0 instead of "no". > > Looks like awk treat

Re: [PATCH] awk: fix use after free (CVE-2023-42363)

On Tue, 21 May 2024 07:43:03 +0200 Natanael Copa wrote: > Hi again, > > On Mon, 20 May 2024 22:52:44 +0200 > Natanael Copa wrote: > > > On Mon, 20 May 2024 17:55:28 +0200 > > Natanael Copa wrote: > > > > > Fixes https://bugs.busybox.net/show_bug.

Re: [PATCH] awk: fix use after free (CVE-2023-42363)

Hi again, On Mon, 20 May 2024 22:52:44 +0200 Natanael Copa wrote: > On Mon, 20 May 2024 17:55:28 +0200 > Natanael Copa wrote: > > > Fixes https://bugs.busybox.net/show_bug.cgi?id=15865 > > I also found out that CVE-2023-42364 and CVE-2023-42365 are fixed with >

Re: [PATCH] awk: fix use after free (CVE-2023-42363)

On Mon, 20 May 2024 17:55:28 +0200 Natanael Copa wrote: > Fixes https://bugs.busybox.net/show_bug.cgi?id=15865 I also found out that CVE-2023-42364 and CVE-2023-42365 are fixed with commit 0256e00a9d07 (awk: fix precedence of = relative to ==). See: https://bugs.busybox.net/show_bug.cgi

[PATCH] awk: fix use after free (CVE-2023-42363)

Fixes https://bugs.busybox.net/show_bug.cgi?id=15865 Signed-off-by: Natanael Copa --- editors/awk.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/editors/awk.c b/editors/awk.c index 0981c6735..122376935 100644 --- a/editors/awk.c +++ b/editors/awk.c

[PATCH] wget: add header Accept: */*

Some servers (like https://netfilter.org) returns failure if the Accept header is missing. Both GNU wget and curl adds this header, so make busybox do the same. fixes: https://bugs.busybox.net/show_bug.cgi?id=15982 function old new delta

[PATCH] time: fix max resident set size unit

The ru_maxrss is already in Kbytes and not pages. function old new delta time_main 11951190 -5 -- (add/remove: 0/0

Re: [PATCH resend] sed: check errors writing file with sed -i

Hi! Any change to get this merged? We have used it in alpine for a while, and so far no issues. Thanks! -nc On Tue, 19 Sep 2023 17:11:02 +0900 Dominique Martinet wrote: > From: Dominique Martinet > > sed would currently not error if write failed when modifying a file. > > This can be

Re: [PATCH] find: fix -xdev -depth (and -delete)

Hi! I think this bug looks pretty bad, as it deletes stuff unintentionally. And appears to reduce size, so I'd think this would be nice! Denys, what do you think? Thanks! -nc On Tue, 19 Sep 2023 17:17:47 +0900 Dominique Martinet wrote: > From: Dominique Martinet > > find -xdev with

Re: sha256sum Illegal instruction on musl amd64

On Wed, 29 Mar 2023 15:46:58 +0200 Denys Vlasenko wrote: > > > it's caused by having a cpu with AVX512 (the github runners do) but not > > > sha_ni, > > > and the code that checks it is broken and misdetects sha_ni support when > > > avx512 > > > exists. the github runners don't have sha_ni,

Re: sha256sum Illegal instruction on musl amd64

On Wed, 29 Mar 2023 15:07:49 +0200 Denys Vlasenko wrote: > On Wed, Mar 1, 2023 at 12:01*PM alice wrote: > > On Tue Feb 28, 2023 at 11:17 PM CET, wrote: > > > I'm having an intermittent issue with "BusyBox v1.36.0 (2023-01-03 > > > 22:49:12 > > > UTC)" (the one from the Docker image

Re: sha256sum Illegal instruction on musl amd64

Hi, On Wed, 01 Mar 2023 11:55:16 +0100 "alice" wrote: > On Tue Feb 28, 2023 at 11:17 PM CET, wrote: > > Hi, > > > > I'm having an intermittent issue with "BusyBox v1.36.0 (2023-01-03 22:49:12 > > UTC)" (the one from the Docker image busybox:musl) when running on amd64 > > GitHub > > actions

sha_ni detection for sha hwaccel is broken

Hi, We have an issue where busybox sha1sum and/or sha256sum is broken when HWACCEL is enabled. This has been observed on github runners only so far. I cloned busybox repo and added github runner that build only sha1sum and sha256sum with hwaccel enabled. I added debug printf statements to see if

Re: BusyBox 1.36.0 regression: Segfaults on i386 musl libc

ctly how to do that. > > [1]: > https://github.com/torvalds/linux/blob/94a855111ed9106971ca2617c5d075269e6aefde/arch/x86/crypto/sha1_ni_asm.S#L112 > > Sören Tempel wrote: > > Hello, > > > > Natanael Copa wrote: > > > diff --git a/libbb/hash_md5_sha.

Re: BusyBox 1.36.0 regression: Segfaults on i386 musl libc

On Thu, 05 Jan 2023 21:39:09 +0100 Sören Tempel wrote: > Hi, > > I am the maintainer of the BusyBox package for Alpine Linux. While > upgrading that package from 1.35.0 to 1.36.0 I noticed a segfault > on Alpine x86, on all other architectures BusyBox 1.36.0 builds > fine and passes the tests.

[PATCH] more: accept and ignore -e

Accept and ignore -e which is specified in POSIX. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/more.html --- util-linux/more.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util-linux/more.c b/util-linux/more.c index eea69da06..a830dcbc1 100644 ---

Re: [PATCH v2 1/2] awk: fix use after free (CVE-2022-30065)

+0200 Natanael Copa wrote: > fixes https://bugs.busybox.net/show_bug.cgi?id=14781 > > Signed-off-by: Natanael Copa > --- > editors/awk.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/editors/awk.c b/editors/awk.c > index 079d0bde5..728ee8685 100644 &g

[PATCH v2 1/2] awk: fix use after free (CVE-2022-30065)

fixes https://bugs.busybox.net/show_bug.cgi?id=14781 Signed-off-by: Natanael Copa --- editors/awk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/editors/awk.c b/editors/awk.c index 079d0bde5..728ee8685 100644 --- a/editors/awk.c +++ b/editors/awk.c @@ -3128,6 +3128,9 @@ static var

[PATCH v2 2/2] awk: add tests for CVE-2022-30065

Signed-off-by: Natanael Copa --- testsuite/awk.tests | 11 +++ 1 file changed, 11 insertions(+) diff --git a/testsuite/awk.tests b/testsuite/awk.tests index 93e25d8c1..6c3a03c37 100755 --- a/testsuite/awk.tests +++ b/testsuite/awk.tests @@ -479,4 +479,15 @@ testing 'awk backslash

Re: [PATCH] awk: fix use after free (CVE-2022-30065)

On Thu, 16 Jun 2022 12:54:56 +0200 Natanael Copa wrote: > On Tue, 14 Jun 2022 18:24:54 +0200 > Denys Vlasenko wrote: > > > On Tue, Jun 14, 2022 at 8:55 AM Natanael Copa > > wrote: > > > Hi! > > > > > > Is there anything else I can do

Re: [PATCH] awk: fix use after free (CVE-2022-30065)

On Tue, 14 Jun 2022 18:24:54 +0200 Denys Vlasenko wrote: > On Tue, Jun 14, 2022 at 8:55 AM Natanael Copa wrote: > > Hi! > > > > Is there anything else I can do to help fix CVE-2022-30065? I have > > created a testcase for the testsuite and proposed a fix, but I'm not

Re: [PATCH] awk: fix use after free (CVE-2022-30065)

:56:27 +0200 Natanael Copa wrote: > fixes https://bugs.busybox.net/show_bug.cgi?id=14781 > --- > editors/awk.c | 6 -- > testsuite/awk.tests | 6 ++ > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/editors/awk.c b/editors/awk.c > index 079

[PATCH] awk: fix use after free (CVE-2022-30065)

fixes https://bugs.busybox.net/show_bug.cgi?id=14781 --- editors/awk.c | 6 -- testsuite/awk.tests | 6 ++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/editors/awk.c b/editors/awk.c index 079d0bde5..be38289e4 100644 --- a/editors/awk.c +++ b/editors/awk.c @@

[PATCH] modinfo: add -k option for kernel version

) Total: 50 bytes textdata bss dec hex filename 834606 141242008 850738 cfb32 busybox_old 834657 141242008 850789 cfb65 busybox_unstripped Signed-off-by: Natanael Copa --- modutils/modinfo.c | 30 ++ 1 file changed, 18

Re: Request for 1.33.2 release

> On 24 Nov 2021, at 14:31, Denys Vlasenko wrote: > > On Thu, Nov 11, 2021 at 5:09 PM Natanael Copa wrote: >> Hi! >> >> I think it would be nice with a 1.33.2 release, with fixes for all the >> recent CVEs. >> >> Those commits should be cherr

Request for 1.33.2 release

Hi! I think it would be nice with a 1.33.2 release, with fixes for all the recent CVEs. Those commits should be cherry-picked to 1_33_stable: 4d4fc5ca5ee4f (man: fix segfault in "man 1") CVE-2021-42373 04f052c56ded5 (unlzma: fix a case where we could read before beginning

Re: Backporting security fixes for 1_31_stable, 1_32_stable and 1_33_stable

On Thu, 11 Nov 2021 12:33:28 + xiechengliang wrote: > I asked one of the disclosers of these vulnerabilities by email, he gave me > the following results. > > CVEfix > CVE-2021-42373commit 4d4fc5ca5ee4f (man: fix segfault in "man 1") > CVE-2021-42374

Backporting security fixes for 1_31_stable, 1_32_stable and 1_33_stable

Hi! There are a number of security issues published that affects busybox older than 1.34. https://jfrog.com/blog/unboxing-busybox-14-new-vulnerabilities-uncovered-by-claroty-and-jfrog/ I am interested in backporting the fixes to alpine linux stable branches, which means that I'd like to

[PATCH] lineedit: fix tab completion with equal sign

Fix tab completion for the path when equal sign (=) is used. For example: dd if=/dev/ze Signed-off-by: Natanael Copa --- I have used busybox ash as the primary shell for over a decade. This tiny feature will make a pretty big impact. libbb/lineedit.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] echo: do not assume that free() leaves errno unmodified

On Fri, 22 Jan 2021 08:35:55 +0100 Natanael Copa wrote: > musl libc's mallocng free() may modify errno if kernel does not support > MADV_FREE which causes echo to echo with error when it shouldn't. > > Future versions of POSIX[1] will require that free() leaves errno > unm

[PATCH v2] echo: do not assume that free() leaves errno unmodified

musl libc's mallocng free() may modify errno if kernel does not support MADV_FREE which causes echo to echo with error when it shouldn't. Future versions of POSIX[1] will require that free() leaves errno unmodified but til then, do not rely free() implementation. Should fix downstream issues:

[PATCH] echo: do not assume that free() leaves errno unmodified

musl libc's mallocng free() may modify errno if kernel does not support MADV_FREE which causes echo to echo with error when it shouldn't. Future versions of POSIX[1] will require that free() leaves errno unmodified but til then, do not rely free() implementation. Should fix downstream issues:

deadlock in ash in busybox 1.32

Hi! The testsuite for stunnel-5.56 deadlocks after busybox upgrade from 1.32.1->1.32.0. I have bisected it to this commmit: commit 47eb979404735b9528538968cb5eaac7355a0c5a (HEAD, refs/bisect/bad) Author: Denys Vlasenko Date: Tue Feb 18 15:37:43 2020 +0100 ash: jobs: Only clear

Re: Non-responsive maintainer?

On Fri, 5 Jun 2020 12:10:54 +0200 Bernhard Reutner-Fischer wrote: > PS: Furthermore don't forget that Denys is doing this stuff for more > than 10 years now and in these years has "donated" quite alot of his > spare time to the project. One usually does not hear "thanks alot for > your

[PATCH v2 2/2] iproute: codeshrink initalization of netlink request

reduce size by de-duplicate initialization of netlink reqest structure initialization. function old new delta init_rtnlmsg_rtmsg_req - 34 +34 init_nlmsg_ifinfomsg_req - 34

[PATCH v2 1/2] iproute: codeshrink netlink message length check

reduce size by de-duplicate netlink message length check function old new delta check_nlmsg_len- 22 +22 print_route 19011893 -8 print_neigh

Re: [PATCH 1/2] iproute: codeshrink netlink message length check

On Wed, 13 Nov 2019 18:55:09 +0100 Bernhard Reutner-Fischer wrote: > On 12 November 2019 12:04:24 CET, Natanael Copa wrote: > >reduce size by de-duplicate netlink message length check > > > >function old new > &

[PATCH] nslookup: fix exitcode with search domains, closes 12541

839394 146602080 856134 d1046 busybox_old 839410 146602080 856150 d1056 busybox_unstripped Signed-off-by: Natanael Copa --- networking/nslookup.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/networking/nslookup.c b

Re: Sime makelike wrapper scripts support

ild -t image . > > } > > > > push() { > > docker push -t image > > } > > > > "$@" > > ``` > > > > If you call that minimake.sh, then you call it as: > > > > ``` > > ./minimake.sh hello > > ./minimake.sh build > > ./

Re: Sime makelike wrapper scripts support

On Mon, 13 Jan 2020 10:30:59 + Ron Yorston wrote: > Boris wrote: > >Sure, to avoid any confusion I would't use the name "Makefile". > >"Minimake" sounds clear to me, and the cli `mim`. > > I like the command name 'mim' (which Merriam-Webster tells me is an > adjective meaning 'affectedly

Re: Sime makelike wrapper scripts support

On Sun, 12 Jan 2020 00:10:09 +0100 Boris Kotov wrote: > Hello BusyBox community, > > > my name is Boris, I would like to make a small feature request regarding > the `ash` shell. > > It would be really handy to have a simple Makefile-like wrapper scripts > syntax just to execute some common

[PATCH 1/2] iproute: codeshrink netlink message length check

reduce size by de-duplicate netlink message length check function old new delta check_nlmsg_len- 22 +22 print_route 19011893 -8 print_neigh

[PATCH 2/2] iproute: codeshrink initalization of netlink request

reduce size by de-duplicate initialization of netlink reqest structure initialization. function old new delta init_rtnlmsg_rtmsg_req - 34 +34 init_nlmsg_ifinfomsg_req - 34

Re: [PATCH 1/1] Optionally re-introduce bb_info_msg()

On Fri, 12 Apr 2019 17:01:51 + James Byrne wrote: > Between Busybox 1.24.2 and 1.25.0 the bb_info_msg() function was > eliminated and calls to it changed to be bb_error_msg(). The downside of > this is that daemons now log all messages to syslog at the LOG_ERR level > which makes it hard to

Re: [PATCH] wget: don't silently ignore certificate validation

Denys, Most common use case for https is to give some sort of guarantee that you actually get what you think you get or that you get from who you think you get it from. That is what most people expect when downloading from https. If you don't care about verifying that, then the common use case is

[PATCH] testsuite: add test for regression in cat

Add a couple of tests for a regression introduced with commit 75e90b15 (cat: fix "cat -An" ignoring -n; make numbering go througn all files) Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- I don't have a fix for the regression yet but I was able to find the commit

Re: Switching Fedora machine away from systemd

On Thu, 19 Apr 2018 17:18:29 +0200 Denys Vlasenko wrote: > After yet another incident of wandering among endless > directories/"targets"/links trying to figure out how to stop > the laptop from falling asleep on lid close, I've had enough. > > Since no one had

Re: serioius resgression with cpio -p and symlinks in busybox 1.28.2

t match) Thanks! -nc > > On Fri, Mar 30, 2018 at 1:29 PM, Natanael Copa <nc...@alpinelinux.org> wrote: > > Hi, > > > > There is a serious regression in busybox 1.28.2 that breaks booting > > alpine linux machines. > > > > The problem co

Re: [PATCH] cpio: fix regression with symlinks

On Fri, 30 Mar 2018 20:16:21 +0200 Denys Vlasenko <vda.li...@googlemail.com> wrote: > On Fri, Mar 30, 2018 at 2:17 PM, Natanael Copa <nc...@alpinelinux.org> wrote: > > Fix to make cpio create symlinks. > > > > This fixe

[PATCH] cpio: fix regression with symlinks

Fix to make cpio create symlinks. This fixes a regression in cpio introduced with a84db18fc71d09e801df0ebca048d82e90b32c6a (tar,unzip: postpone creation of symlinks with "suspicious" targets). Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- This should got to fixes-1.

serioius resgression with cpio -p and symlinks in busybox 1.28.2

Hi, There is a serious regression in busybox 1.28.2 that breaks booting alpine linux machines. The problem comes from /bin/sh -> /bin/busybox symlink no longer getting copied with cpio -p. To reproduce: $ mkdir -p 1/bin 2 $ ln -s /bin/busybox 1/bin/sh $ (cd 1 && echo "/bin/sh" | cpio -vdmp

bug in busybox grep -F -w

Hi! It looks like there is a bug in `busybox grep -F -w`: $ echo "aa" | busybox grep -F -w "a" aa I would expect that to not output anything. GNU grep does not output anything, nor does FreeBSD grep. -nc ___ busybox mailing list busybox@busybox.net

Re: Removing -n option from udhcpc

On Tue, 6 Feb 2018 20:04:20 +0100 Denys Vlasenko wrote: > On Mon, Feb 5, 2018 at 8:10 PM, Daykin, Evan wrote: > > Good Afternoon, > > > > > > > > We have a lot of devices which were shipped running Busybox 1.20.2. We ran a > > test to see what

Re: [PATCH] unzip: fix regression on big-endian machines

On Thu, 27 Jul 2017 15:39:35 +0200 Denys Vlasenko <vda.li...@googlemail.com> wrote: > Applied, thanks! This should go to 1_27_stable too. Thanks! > > On Tue, Jul 25, 2017 at 8:44 PM, Natanael Copa <nc...@alpinelinux.org> wrote: > > This fixes a regression which

Re: [PATCH] miscutils/microcom: Fixed segfault

On Fri, 4 Aug 2017 02:02:36 +0200 Denys Vlasenko wrote: > On Thu, Aug 3, 2017 at 7:11 AM, Marian Buschsieweke > wrote: > > microcom did not check if required parameter TTY is present. Thus, > > bb_basename() was called with a NULL pointer

[PATCH] unzip: fix regression on big-endian machines

This fixes a regression which was introduced with commit 2a0867a5 ("unzip: optional support for bzip2 and lzma") and causes unzip to exit with error when extracting archives: unzip: unsupported method 2048 Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- archival/unzip

missing branch and tag for release 1.27.0

Hi, Congrats with the 1.27.0 release! I just want to point out that the 1_27_stable branch is missing. This means that there is a broken link for "git" on the front page: https://git.busybox.net/busybox/tree/?h=1_27_stable The git tag for 1.27.0 seems also to be missing. Thanks! -nc

Re: udhcpc changes in 1.25.0 that didn't seem to be mentioned?

Hi, This issue is affecting Alpine Linux too. From the setup script we will start network in the background while user creates the root password. However, udhcpc will not print information on the screen about the lease which will overwrite the "Enter root password" prompt. I tried to redirect

[PATCH] add/remove-shell: prevent world writable /etc/shells

permissions than it previously had. Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- loginutils/add-remove-shell.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/loginutils/add-remove-shell.c b/loginutils/add-remove-shell.c index af7c31779..a434d054d

[PATCH] ntpd: improve postponed hostname resolution

bss dec hex filename 802129 154592192 819780 c8244 busybox_old 802095 154592192 819746 c8222 busybox_unstripped Signed-off-by: Kaarle Ritvanen <kaarle.ritva...@datakunkku.fi> Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- networking

Re: ash regression in busybox-1.26.1

; On Tue, Jan 3, 2017 at 3:41 PM, Natanael Copa <nc...@alpinelinux.org> wrote: > > Hi > > > > There is a regression in ash in busybox-1.26.1, with > > https://git.busybox.net/busybox/commit/?id=ea7d2f6ec0596789fc5b2e3fca3b7a602bfa2c26 > > applied. > > > >

ash regression in busybox-1.26.1

Hi There is a regression in ash in busybox-1.26.1, with https://git.busybox.net/busybox/commit/?id=ea7d2f6ec0596789fc5b2e3fca3b7a602bfa2c26 applied. To reproduce, try build flac-1.3.2 with CONFIG_SHELL=/bin/ash ... Making all in libFLAC++ make[3]: Entering directory

Re: running `busybox --install -s` as non-root in a staging dir

On Thu, 15 Dec 2016 16:37:22 +0100 Natanael Copa <nc...@alpinelinux.org> wrote: > Hi, > > I am working on creating a rootfs tarball for alpine linux to be used > as base for things like docker images. Currently all alpine release > iso images are created as non-root, with so

running `busybox --install -s` as non-root in a staging dir

Hi, I am working on creating a rootfs tarball for alpine linux to be used as base for things like docker images. Currently all alpine release iso images are created as non-root, with some help from fakeroot. I do have a problem with the rootfs image. The problem is that package manager

Re: bug in ash set -e

On Wed, 09 Nov 2016 16:12:41 + Ron Yorston <r...@pobox.com> wrote: > Natanael Copa wrote: > >I have found a bug (or weird feature?) in busybox ash: > > > >$ dash -c "set -e ; ( false ) ; echo 'should not echo'" > >$ bash -c "set -e ; ( false

bug in ash set -e

Hi, I have found a bug (or weird feature?) in busybox ash: $ dash -c "set -e ; ( false ) ; echo 'should not echo'" $ bash -c "set -e ; ( false ) ; echo 'should not echo'" $ ash -c "set -e ; ( false ) ; echo 'should not echo'" should not echo $ It looks like `set -e` does not catch error in ( )

Re: [PATCH] iproute: ensure scope is correctly initialised

ctice this attempt at optimisation results in no saving, so > remove it. > > Reported-by: Natanael Copa <nc...@alpinelinux.org> > Signed-off-by: Ron Yorston <r...@pobox.com> Acked-by: Natanael Copa <nc...@alpinelinux.org> We now use this in alpine linux and it works. Thanks!

ip route add bug in 1.25.0

Hi, ip route add 0.0.0.0/0 via dev eth0 This results in default route not being set which results in broken network in alpine linux. This worked just fine in busybox-1.24.x The test case I have been using in my local network is: $ sudo busybox ip route add 192.168.0.0/24 via 10.98.106.9

Re: [PATCH] lineedit: trivial codeshrink for vi-mode

Denys, Any reason to not apply this? -nc On Fri, 29 May 2015 10:08:56 +0200 Natanael Copa <nc...@alpinelinux.org> wrote: > Introduce and use BB_isalnum_or_underscore(). > > bloatcheck on x86_64: > function o

[PATCH 1/2] gzip: fix compression level bug. Closes 9131

-4 to -9 is mapped to correct level and avoids out-of-bounds access. Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- See https://bugs.busybox.net/show_bug.cgi?id=9131 for more details archival/gzip.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/archival/

[PATCH 2/2] gzip: add test that checks that -9 compresses better than -1

Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- testsuite/gzip/gzip-compression-levels | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 testsuite/gzip/gzip-compression-levels diff --git a/testsuite/gzip/gzip-compression-levels b/testsuite/gzip/gzip-compression-leve

Re: busybox 1.25 ntpd retry initial DNS resolution (forever, no timeout for now).

On Tue, 28 Jun 2016 20:19:29 +0200 "KP.Kirchdoerfer" wrote: > Hi; > > I'm testing busybox 1.25 and wonder how to deal with the commit > > https://git.busybox.net/busybox/commit/networking?id=e4caf1dd9ce8569371a0eeb77ccf02a572dc0f11 > > At the first look it seems to

[PATCH] df: use f_frsize instead of f_bsize for correct sizes

i?id=9046 Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- coreutils/df.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/coreutils/df.c b/coreutils/df.c index d79c11a..06b2920 100644 --- a/coreutils/df.c +++ b/coreutils/df.c @@ -188,7 +188

[PATCH v2] libbb: fix time parsing of [[CC]YY]MMDDhhmm[.SS]

If SS is not given a value, it is assumed to be zero. http://pubs.opengroup.org/onlinepubs/9699919799/utilities/touch.html closes 8951 Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- V1 -> V2 changes: - always set seconds to 0. If you for example do: `touch -t 1100 somefil

[PATCH] libbb: fix time parsing of [[CC]YY]MMDDhhmm[.SS]

If SS is not given a value, it is assumed to be zero. http://pubs.opengroup.org/onlinepubs/9699919799/utilities/touch.html closes 8951 Signed-off-by: Natanael Copa <nc...@alpinelinux.org> --- libbb/time.c | 4 1 file changed, 4 insertions(+) diff --git a/libbb/time.c b/libbb/time.c

[PATCH] loginutils: add portable groupadd applet

-off-by: Natanael Copa <nc...@alpinelinux.org> --- I kept the addgroup applet for the following reasons: - We may need the backward compatible addgroup for a migration period to not break things. - the `shadow` groupadd can not add users to a group. We need keep addgroup til we have an

Re: [PATCH 1/2 1.24] ash: fix error during recursive processing of here document

On Tue, 22 Mar 2016 09:21:24 + Ron Yorston wrote: > Mike Frysinger wrote: > >i've cherry picked back this commit to the 1.24 branch > > Thanks, but why not 2/2 also? I wonder that too. The 2/2 patch fixes this: foo () { cat

Re: [Bug 6182] nologin: new applet

On Mon, 15 Feb 2016 19:09:20 -0500 Mike Frysinger <vap...@gentoo.org> wrote: > On 15 Feb 2016 17:23, Natanael Copa wrote: > > On Sat, 13 Feb 2016 13:32:10 +0100 > > Bernhard Reutner-Fischer <rep.dot@gmail.com> wrote: > > > On February 13, 2016 12:04:4

adduser/addgroup vs portable useradd/groupadd

Hi, As you may know, busybox has been the core of Alpine Linux for a decade. One of the things that has been necessary for its success has been that busybox has followed the standards, making the tools compatible with the corresponding bigger tools. Even GNU extensions and long-opts have been

Re: [Bug 6182] nologin: new applet

On Sat, 13 Feb 2016 13:32:10 +0100 Bernhard Reutner-Fischer wrote: > On February 13, 2016 12:04:40 PM GMT+01:00, bugzi...@busybox.net wrote: > >https://bugs.busybox.net/show_bug.cgi?id=6182 > > > >Mike Frysinger changed: > > > > What

Re: [PATCH 3/3] su: FEATURE_SU_NULLOK_SECURE

On Thu, 5 Nov 2015 16:27:36 +0200 Kaarle Ritvanen wrote: > When this feature is enabled, blank passwords are not accepted by su > unless the user is on a secure TTY defined in /etc/securetty. This > resembles the default PAM configuration of some Linux distros

Re: [PATCH 3/3] ash: simplify EOF/newline handling in list parser

: > ><7c245aa> [PARSER] Simplify EOF/newline handling in list parser > > (See git://git.kernel.org/pub/scm/utils/dash/dash.git) > > Reported-by: Natanael Copa <nc...@alpinelinux.org> > Signed-off-by: Ron

Re: [PATCH 2/3] Revert "ash: fix a SEGV case in an invalid heredoc" xxx

On Thu, 29 Oct 2015 12:29:37 + Ron Yorston <r...@pobox.com> wrote: > Natanael Copa wrote: > >I think this will not work. peektoken and nexttoken_ends_lists are not > >same thing. > > Originally peektoken in Busybox ash was the same as in dash. It then &

Re: [PATCH 2/3] Revert "ash: fix a SEGV case in an invalid heredoc" xxx

On Thu, 29 Oct 2015 11:30:22 + Ron Yorston <r...@pobox.com> wrote: > This reverts commit 7e66102f762a7d80715f0c7e5925433256b78cee but > leaves the test in place as it's still valid. > > Reported-by: Natanael Copa <nc...@alpinelinux.org> > Signed-off-by:

Re: [PATCH 1.24.1] ash: backport fix for here document issues

On Thu, 29 Oct 2015 11:31:39 + Ron Yorston <r...@pobox.com> wrote: > Reported-by: Natanael Copa <nc...@alpinelinux.org> > Signed-off-by: Ron Yorston <r...@pobox.com> > --- > shell/ash.c | 72 > +---

Re: [PATCH 1.24.1] ash: backport fix for here document issues

On Thu, 29 Oct 2015 11:31:39 + Ron Yorston <r...@pobox.com> wrote: > Reported-by: Natanael Copa <nc...@alpinelinux.org> > Signed-off-by: Ron Yorston <r...@pobox.com> > --- > shell/ash.c | 72 > +---

Re: [PATCH 5/5 v2] ash: fix error during recursive processing of here document

On Thu, 29 Oct 2015 16:44:56 + Ron Yorston wrote: > Save the value of the checkkwd flag to prevent it being clobbered > during recursion. > > Based on commit ec2c84d from git://git.kernel.org/pub/scm/utils/dash/dash.git > by Herbert Xu. This fixes the issue introduced with

Re: [PATCH 1.24.1] ash: backport fix for here document issues

On Thu, 29 Oct 2015 16:22:44 + Ron Yorston <r...@pobox.com> wrote: > Natanael Copa wrote: > >if true; then > >cat >>confdefs.h <<_ACEOF > >#define `date` > >_ACEOF > >fi > > > >Seems like `command` inside heredoc insid

busybox 1.24.1 ash regression

Hi, musl's configure script fails with busybox 1.24.1 ash: ./configure: line 50: syntax error: unexpected "}" The relevant code from the script quote () { tr '\n' ' ' &1 && { echo "$1" ; return 0 ; } $1 EOF printf %s\\n "$1" | sed -e "s/'/'''/g" -e "1s/^/'/" -e "\$s/\$/'/" -e

Re: busybox 1.24.1 ash regression

On Thu, 29 Oct 2015 08:16:30 +0100 Natanael Copa <nc...@alpinelinux.org> wrote: > Simplfied test case: > > > foo () { > tr '\n' ' ' < $1 > EOF > } > > foo "bar" > > > The simplified testcase works with bash, dash and busybox

Re: busybox 1.24.1 ash regression

On Thu, 29 Oct 2015 09:21:06 +0100 Natanael Copa <nc...@alpinelinux.org> wrote: > On Thu, 29 Oct 2015 08:16:30 +0100 > Natanael Copa <nc...@alpinelinux.org> wrote: > > > Simplfied test case: > > > > > > foo () { > >

Re: busybox 1.24.1 ash regression

On Thu, 29 Oct 2015 09:28:20 +0100 Natanael Copa <nc...@alpinelinux.org> wrote: > On Thu, 29 Oct 2015 09:21:06 +0100 > Natanael Copa <nc...@alpinelinux.org> wrote: > > > On Thu, 29 Oct 2015 08:16:30 +0100 > > Natanael Copa <nc...@alpinelinux.org>

request for another missed ifupdown patch

Hi, This was sent 2012 but probably forgotten too: http://lists.busybox.net/pipermail/busybox/2012-September/078398.html -nc ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

request for missed ifupdown ipv6 patch

This patch seems to have been forgotten and is needed for ipv6 to work properly: http://lists.busybox.net/pipermail/busybox/2012-August/078297.html Could it please be added thanks? I am getting tired of rebasing it every release. -nc PS. have you considered using patchwork? It helped alpine

Re: [PATCH] su: support denying accounts with blank password

On Tue, 13 Oct 2015 18:03:10 +0200 Denys Vlasenko <vda.li...@googlemail.com> wrote: > On Mon, Oct 12, 2015 at 12:07 PM, Natanael Copa <nc...@alpinelinux.org> wrote: > >> I tested > >> > >> $ su --version > >> su (GNU coreutils) 8.17 > &g

Re: [PATCH] su: support denying accounts with blank password

On Wed, 14 Oct 2015 10:45:49 +0200 Denys Vlasenko wrote: > Basically, you want root to have no password and yet, > you want people to not be able to su to root. Correct. The thinking is that empty password is better than a bad password. > I find this setup strange.

Re: [PATCH] su: support denying accounts with blank password

On Wed, 14 Oct 2015 05:43:32 -0400 Michael Conrad <mcon...@intellitree.com> wrote: > On 10/14/2015 2:37 AM, Natanael Copa wrote: > > The security is based on physical access. The local technician can log > > in without password. (in theory, if you have physical access the

Re: [PATCH] su: support denying accounts with blank password

On Wed, 14 Oct 2015 12:18:04 +0200 Laurent Bercot <ska-dietl...@skarnet.org> wrote: > On 14/10/2015 08:37, Natanael Copa wrote: > > using a screen and keyboard or via serial cable. he logs in as root, > > but is not asked for password or just press when asked for >

  1   2   3   4   >