[PATCH] udhcp compilation issue

make defconfig produces this compilation issue i.e missing bracket in networking/udhcp/d6_dhcpc. attached patch adds that diff --git a/networking/udhcp/d6_dhcpc.c b/networking/udhcp/d6_dhcpc.c index 1a0a5739e..6cc2316c4 100644 --- a/networking/udhcp/d6_dhcpc.c +++ b/networking/udhcp/d6_dhcpc.c @@

busybox whereis ? required / useful ?

Hi good people of busybox, i wanted to know would busybox benefit from a miny whereis implementation ?, if so i would like to submit it, just inquiring if anyone has already started on that . Kind Regards Haroon ___ busybox mailing list

[PATCH] powertop fix buffer overflow, removed unecessary strlen call

Hi, PFA a small change to procps/powertop that removes a potential buffer overflow reported by gcc. in my opinion as dirent->d_name is allocated on the stack , we can avoid the strlen call, and make the char buf[] a bit bigger to accomodate the strings that are hardcoded i.e

Re: test fails: mount -o

On Sun, Oct 21, 2018 at 01:25:57AM +, haroon maqsood wrote: > On Sun, Oct 21, 2018 at 01:22:20AM +0000, haroon maqsood wrote: > > On Mon, Oct 01, 2018 at 12:37:06PM +0530, Nikita Gupta wrote: > > > Hi team, > > > > > > While executing the testsuite include

Re: test fails: mount -o

On Sun, Oct 21, 2018 at 01:22:20AM +, haroon maqsood wrote: > On Mon, Oct 01, 2018 at 12:37:06PM +0530, Nikita Gupta wrote: > > Hi team, > > > > While executing the testsuite included with the busybox-1.24.1, I got few > > failures. > > *Failed test ca

Re: test fails: mount -o

On Mon, Oct 01, 2018 at 12:37:06PM +0530, Nikita Gupta wrote: > Hi team, > > While executing the testsuite included with the busybox-1.24.1, I got few > failures. > *Failed test case list* > cpio lists hardlinks > mount -o remount,mand > sed n (flushes pattern space, terminates early) > sed

Re: [PATCH 1/2] allow honouring libc provided SIGRTMIN/SIGRTMAX

On Fri, Oct 05, 2018 at 11:42:30AM +, haroon maqsood wrote: > Did not reply to the group, here is the fixed patch. > it was a stupid mistake on my part. > Thanks > Haroon > > From: busybox on behalf of Rasmus Villemoes > > Sent: Frid

Re: [PATCH][volume_id][reiserfs structures and etc]

Did not reply to the group, here is the fixed patch. it was a stupid mistake on my part. Thanks Haroon From: Mark Marshall Sent: Friday, October 5, 2018 7:18 AM To: haroon maqsood; busybox@busybox.net Subject: Re: [PATCH][volume_id][reiserfs structures and etc

Re: [PATCH 1/2] allow honouring libc provided SIGRTMIN/SIGRTMAX

Did not reply to the group, here is the fixed patch. it was a stupid mistake on my part. Thanks Haroon From: busybox on behalf of Rasmus Villemoes Sent: Friday, October 5, 2018 7:08 AM To: busybox@busybox.net Subject: Re: [PATCH 1/2] allow honouring libc

Re: [PATCH][volume_id][reiserfs structures and etc]

filename 89357241991888 899659 dba4b busybox_old 89359541991888 899682 dba62 busybox_unstripped From: haroon maqsood Sent: Friday, October 5, 2018 12:11 AM To: busybox@busybox.net Subject: [PATCH][volume_id][reiserfs structures and etc

[PATCH][volume_id][reiserfs structures and etc]

Hi, PFA a patch to try and streamline the reiserfs structures in use, from volume_id and mkfs_reiser. i also made some changes to the volume_id probe function for reiserfs, please let me know if you would prefer it in 2 patches. the structures are used from reiserfsprogs 3.6.27, was there a

[PATCH] make storage helpers common

Hi, I started testing/reading mkfs_reiserfs and found the BUG_wrong_field_size and STORE_LE to be defined redundantly in other files as well, Please find attached a small patch that moves these common macros into libbb.h , should there be a header for file-system helper functions and macros,

[PATCH] passwd ENABLE_FEATURE_PASSWD_WEAK_CHECK and weak password but still allowed to change passwd.

Hi, in case the desired behavior is to allow password change in case of this feature is enabled and password is weak, please ignore my misunderstanding. i think myuid !=0 is an unecessary check as it depends on feature ENABLE_FEATURE_PASSWD_WEAK_CHECK not on myuid, why is myuid checked here

Re: [PATCH] addgroup , adduser series.

could be read from top to bottom. So let us continue the discussions there On 06/08/2018 21:54, haroon maqsood wrote: > Hi, > > i think it might be misunderstanding on my part about the options. > > i was trying to fix this bug https://bugs.busybox.net/show_bug.cgi?id=10981 >

Re: [PATCH] addgroup , adduser series.

, August 6, 2018 10:07 PM To: busybox Subject: Re: [PATCH] addgroup , adduser series. Hi, please don't add your replay to the top but add it to the end of the mail so that the mail could be read from top to bottom. So let us continue the discussions there On 06/08/2018 21:54, haroon maqsood wrote

Re: [PATCH] addgroup , adduser series.

on this, it was more from a readability/understanding point of view Haroon From: busybox on behalf of Tito Sent: Sunday, August 5, 2018 6:45 PM To: busybox@busybox.net Subject: Re: [PATCH] addgroup , adduser series. On 05/08/2018 10:51, haroon maqsood wrote: >

[PATCH] addgroup , adduser series.

Hi I started working on a patch for adduser utility i.e removing the fixme and restructuring the code and implementing options S and D as they are currently disabled. i though it would make sense to send the first patch that is for addgroup, as in my opinion adduser depends on addgroup and

[PATCH][nproc --all --ignore]

From: haroon maqsood Sent: Monday, June 25, 2018 9:08 PM To: busybox@busybox.net Subject: [PATCH][nproc --all --ignore] Hi PFA the my attempt at --all --ignore implementation for nproc. i read that a good applet would make long options configurable