Re: 'case' UTF-8 bug

2017-07-05 Thread Martijn Dekker
Op 05-07-17 om 22:23 schreef Denys Vlasenko: > Fixed in git, please confirm. Confirmed. Thanks, - M. ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: 'case' UTF-8 bug

2017-07-05 Thread Denys Vlasenko
On Wed, Jul 5, 2017 at 8:56 PM, Martijn Dekker wrote: > Op 05-07-17 om 19:15 schreef Denys Vlasenko: >> Fix is in git, please try and let me know how does it work. > > It fixes the bug I reported, but it introduces a new bug: the presence > of a quoted closing square bracket in

Re: 'case' UTF-8 bug

2017-07-05 Thread Martijn Dekker
Op 05-07-17 om 19:15 schreef Denys Vlasenko: > Fix is in git, please try and let me know how does it work. It fixes the bug I reported, but it introduces a new bug: the presence of a quoted closing square bracket in a pattern (whether it's quoted literally or passed from a variable) causes the

Re: 'case' UTF-8 bug

2017-07-05 Thread Denys Vlasenko
On Wed, Jul 5, 2017 at 6:15 PM, Denys Vlasenko wrote: > I reproduced it on another machine, with this libc: > > $ /lib/libc-2.22.so > GNU C Library (Gentoo 2.22-r4 p13) stable release version 2.22, by > Roland McGrath et al. > > The cause: ash uses chars 0x81...0x88 for

Re: 'case' UTF-8 bug

2017-07-05 Thread Martijn Dekker
Op 05-07-17 om 18:15 schreef Denys Vlasenko: > On Wed, Jul 5, 2017 at 1:50 AM, Martijn Dekker wrote: >> Slackware 14.1 (with multilib added): >> >> $ /lib64/libc.so.6 >> GNU C Library (GNU libc) stable release version 2.17, by Roland McGrath et >> al. > > So, bug triggers with

Re: 'case' UTF-8 bug

2017-07-05 Thread Denys Vlasenko
On Wed, Jul 5, 2017 at 1:50 AM, Martijn Dekker wrote: > Op 04-07-17 om 20:23 schreef Denys Vlasenko: >> Ok. I just tested it again, and it works for me. >> Let's narrow it down more. My libc is: >> >> $ /lib64/libc.so.6 >> GNU C Library (GNU libc) development release version

Re: 'case' UTF-8 bug

2017-07-04 Thread Martijn Dekker
Op 04-07-17 om 20:23 schreef Denys Vlasenko: > Ok. I just tested it again, and it works for me. > Let's narrow it down more. My libc is: > > $ /lib64/libc.so.6 > GNU C Library (GNU libc) development release version 2.25.90, by > Roland McGrath et al. > Copyright (C) 2017 Free Software Foundation,

Re: 'case' UTF-8 bug

2017-07-04 Thread Denys Vlasenko
On Tue, Jul 4, 2017 at 8:13 PM, Martijn Dekker wrote: > Op 04-07-17 om 19:51 schreef Denys Vlasenko: >> You said earlier that environment makes no difference. > > That was incorrect, sorry about that. > >> For the locale, >> it should make a difference. Can you confirm that

Re: 'case' UTF-8 bug

2017-07-04 Thread Martijn Dekker
Op 04-07-17 om 19:51 schreef Denys Vlasenko: > You said earlier that environment makes no difference. That was incorrect, sorry about that. > For the locale, > it should make a difference. Can you confirm that after setting > all LC_foo variables to "C" bug does not trigger? Yes, I can confirm

Re: 'case' UTF-8 bug

2017-07-04 Thread Denys Vlasenko
On Sun, Jul 2, 2017 at 2:36 PM, Martijn Dekker wrote: Let's find out why it doesn't work for you. Is it environment? >>> [...] >>> >>> Nope, environment makes no difference. >>> >>> Finally found the time to track down the bug on my machine. It is >>> triggered by

Re: 'case' UTF-8 bug

2017-07-02 Thread Martijn Dekker
Op 01-02-17 om 13:27 schreef Denys Vlasenko: > On Sat, Dec 24, 2016 at 2:17 PM, Martijn Dekker wrote: >> Op 24-11-16 om 08:22 schreef Denys Vlasenko: >>> On Thu, Nov 24, 2016 at 2:57 AM, Martijn Dekker wrote: Op 24-11-16 om 00:14 schreef Denys Vlasenko:

Re: 'case' UTF-8 bug

2017-02-01 Thread Denys Vlasenko
On Sat, Dec 24, 2016 at 2:17 PM, Martijn Dekker wrote: > Op 24-11-16 om 08:22 schreef Denys Vlasenko: >> On Thu, Nov 24, 2016 at 2:57 AM, Martijn Dekker wrote: >>> Op 24-11-16 om 00:14 schreef Denys Vlasenko: Can't reproduce: >>> [...] Tried with

Re: 'case' UTF-8 bug

2016-12-24 Thread Martijn Dekker
Op 24-11-16 om 08:22 schreef Denys Vlasenko: > On Thu, Nov 24, 2016 at 2:57 AM, Martijn Dekker wrote: >> Op 24-11-16 om 00:14 schreef Denys Vlasenko: >>> Can't reproduce: >> [...] >>> Tried with CONFIG_FEATURE_SH_STANDALONE=y and it still works for me. >>> >>> Please send your

Re: 'case' UTF-8 bug

2016-11-24 Thread Denys Vlasenko
On Thu, Nov 24, 2016 at 2:57 AM, Martijn Dekker wrote: > Op 24-11-16 om 00:14 schreef Denys Vlasenko: >> Can't reproduce: > [...] >> Tried with CONFIG_FEATURE_SH_STANDALONE=y and it still works for me. >> >> Please send your .config > > OK, see attached. Still can't reproduce,

Re: 'case' UTF-8 bug

2016-11-23 Thread Martijn Dekker
Op 24-11-16 om 00:14 schreef Denys Vlasenko: > Can't reproduce: [...] > Tried with CONFIG_FEATURE_SH_STANDALONE=y and it still works for me. > > Please send your .config OK, see attached. - M. # # Automatically generated make config: don't edit # Busybox version: 1.25.1 # Wed Nov 23 19:33:33

Re: 'case' UTF-8 bug

2016-11-23 Thread Denys Vlasenko
On Wed, Nov 23, 2016 at 6:52 PM, Martijn Dekker wrote: > busybox ash in UTF-8 locale does not like the lowercase Greek letter > 'rho' (CF 81) in a case statement. > > case "ρ" in > ( "ρ" ) echo ok ;; > ( * ) echo WRONG ;; > esac > > outputs WRONG. > > The preceding character π

'case' UTF-8 bug

2016-11-23 Thread Martijn Dekker
busybox ash in UTF-8 locale does not like the lowercase Greek letter 'rho' (CF 81) in a case statement. case "ρ" in ( "ρ" ) echo ok ;; ( * ) echo WRONG ;; esac outputs WRONG. The preceding character π (CF 80) is fine, but the succeeding one ς (CF 82) is not. There are other characters with