Re: [PATCH] Tweaks to build process for embedded scripts

2018-11-19 Thread Kang-Che Sung
On Monday, November 19, 2018, Ron Yorston wrote: > Kang-Che Sung wrote: >>Script stripping should be optional, for at least two reasons: >>1. It's beyond the scope of the script embedding feature, and it would better >>be implemented and maintained as a separate tool. > > I don't think it's out

Re: [PATCH] Tweaks to build process for embedded scripts

2018-11-19 Thread Ron Yorston
Kang-Che Sung wrote: >Script stripping should be optional, for at least two reasons: >1. It's beyond the scope of the script embedding feature, and it would better >be implemented and maintained as a separate tool. I don't think it's out of scope. If you're handing your scripts over to the

Re: [PATCH] Tweaks to build process for embedded scripts

2018-11-19 Thread Kang-Che Sung
On Mon, Nov 19, 2018 at 5:43 PM Ron Yorston wrote: > > Denys Vlasenko wrote: > >On Sun, Nov 18, 2018 at 10:06 AM Ron Yorston wrote: > >> - Strip leading comments and blank lines from embedded scripts before > >> compressing them. Removing all comments would be nice but is hard. > > > >Well,

Re: [PATCH] Tweaks to build process for embedded scripts

2018-11-19 Thread Ron Yorston
Denys Vlasenko wrote: >On Sun, Nov 18, 2018 at 10:06 AM Ron Yorston wrote: >> - Strip leading comments and blank lines from embedded scripts before >> compressing them. Removing all comments would be nice but is hard. > >Well, this last item can mangle scripts. Let's not do this. What's the

Re: [PATCH] Tweaks to build process for embedded scripts

2018-11-18 Thread Denys Vlasenko
On Sun, Nov 18, 2018 at 10:06 AM Ron Yorston wrote: > - Force a rebuild if a script in applets_sh is changed. > > - Move the dummy usage messages for custom applets to usage.h and > change the name from 'dummy' to 'scripted'. > > - Hide an error from gen_build_files.sh if an embed directory

[PATCH] Tweaks to build process for embedded scripts

2018-11-18 Thread Ron Yorston
- Force a rebuild if a script in applets_sh is changed. - Move the dummy usage messages for custom applets to usage.h and change the name from 'dummy' to 'scripted'. - Hide an error from gen_build_files.sh if an embed directory exists but is empty. - Strip leading comments and blank lines