Re: [PATCH] getty: remove the statement of pid and sid comparison

2014-05-12 Thread Sam Liddicott
Maybe true is better than ; true so that the correct exit code will also be returned. Sam On 10 May 2014 23:19, Denys Vlasenko vda.li...@googlemail.com wrote: On Saturday 10 May 2014 04:17, Zhenhua Luo wrote: when setsid failed, the pid and sid doesn't equal, so remove following condition

RE: [PATCH] getty: remove the statement of pid and sid comparison

2014-05-11 Thread zhenhua....@freescale.com
Thanks for the comments. It works when using sh -c 'getty 115200 /dev/ttyQE1; true'. Best Regards, Zhenhua -Original Message- From: Denys Vlasenko [mailto:vda.li...@googlemail.com] Sent: Sunday, May 11, 2014 6:19 AM To: busybox@busybox.net Cc: Luo Zhenhua-B19537; Liu

RE: [PATCH] getty: remove the statement of pid and sid comparison

2014-05-10 Thread zhenhua....@freescale.com
Hello Dunham, Thanks for your comments. -Original Message- From: Isaac Dunham [mailto:ibid...@gmail.com] Sent: Saturday, May 10, 2014 12:34 PM To: Luo Zhenhua-B19537 Cc: busybox@busybox.net; Liu Ting-B28495 Subject: Re: [PATCH] getty: remove the statement of pid and sid

Re: [PATCH] getty: remove the statement of pid and sid comparison

2014-05-10 Thread Denys Vlasenko
On Saturday 10 May 2014 04:17, Zhenhua Luo wrote: when setsid failed, the pid and sid doesn't equal, so remove following condition statement. if (getsid(0) != pid) Following is the content and output of test program. root@p1022ds:~# cat sid_test.c int main() { pid_t pid;

[PATCH] getty: remove the statement of pid and sid comparison

2014-05-09 Thread Zhenhua Luo
when setsid failed, the pid and sid doesn't equal, so remove following condition statement. if (getsid(0) != pid) Following is the content and output of test program. root@p1022ds:~# cat sid_test.c int main() { pid_t pid; pid = setsid(); if (pid 0) { int fd; pid

Re: [PATCH] getty: remove the statement of pid and sid comparison

2014-05-09 Thread Isaac Dunham
On Sat, May 10, 2014 at 10:17:13AM +0800, Zhenhua Luo wrote: when setsid failed, the pid and sid doesn't equal, so remove following condition statement. if (getsid(0) != pid) snip Fix following runtime issue of getty: root@p1025:~# getty 115200 /dev/ttyQE1 getty: setsid: Operation