Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-31 Thread James Clarke
On 31 Oct 2017, at 15:06, Denys Vlasenko wrote: > > How about this? > > --- a/networking/traceroute.c > +++ b/networking/traceroute.c > @@ -709,6 +709,9 @@ packet_ok(int read_len, len_and_sockaddr *from_lsa, > > # if ENABLE_FEATURE_TRACEROUTE_VERBOSE >if

Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-31 Thread Denys Vlasenko
How about this? --- a/networking/traceroute.c +++ b/networking/traceroute.c @@ -709,6 +709,9 @@ packet_ok(int read_len, len_and_sockaddr *from_lsa, # if ENABLE_FEATURE_TRACEROUTE_VERBOSE if (verbose) { +# ifndef MAXHOSTNAMELEN +# define MAXHOSTNAMELEN 80 +# endif

Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-08 Thread James Clarke
[Dropping debian-...@lists.debian.org, as this patch only affects the Hurd] On 8 Oct 2017, at 12:28, Kang-Che Sung wrote: > 2017年10月8日 18:59，"James Clarke" 寫道： >> That's not actually true (any more); util-linux/fdisk_osf.c, whilst >> Linux-specific, does

Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-08 Thread Kang-Che Sung
2017年10月8日 18:59，"James Clarke" 寫道： That's not actually true (any more); util-linux/fdisk_osf.c, whilst Linux-specific, does use MAXPATHLEN, and networking/traceroute.c uses MAXHOSTNAMELEN. These could be changed to use {PATH,HOST_NAME}_MAX, but it's highly likely that a

Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-08 Thread James Clarke
On 8 Oct 2017, at 02:40, Kang-Che Sung wrote: > On Sun, Oct 8, 2017 at 1:53 AM, James Clarke wrote: >> Signed-off-by: James Clarke >> --- >> include/libbb.h | 19 ++- >> 1 file changed, 18 insertions(+), 1 deletion(-) >>

Re: [PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-07 Thread Kang-Che Sung
On Sun, Oct 8, 2017 at 1:53 AM, James Clarke wrote: > Signed-off-by: James Clarke > --- > include/libbb.h | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/include/libbb.h b/include/libbb.h > index

[PATCH 7/7] libbb.h: Handle missing HOST_NAME_MAX; ensure MAXFOOLEN agrees with FOO_MAX

2017-10-07 Thread James Clarke
Signed-off-by: James Clarke --- include/libbb.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/include/libbb.h b/include/libbb.h index daccf154a..56f4f4cb3 100644 --- a/include/libbb.h +++ b/include/libbb.h @@ -181,7 +181,24 @@ extern