Re: [PATCH v2] Ntpd config file support

2014-10-31 Thread Laszlo Papp
How about ... for instance merging this thing ... ? On Mon, Mar 24, 2014 at 3:13 AM, Isaac Dunham ibid...@gmail.com wrote: On Sun, Mar 23, 2014 at 03:06:08PM +0100, Denys Vlasenko wrote: On Saturday 22 March 2014 23:46, Isaac Dunham wrote: On Sat, Mar 22, 2014 at 08:40:48PM +0100, Harald

Re: [PATCH v2] Ntpd config file support

2014-03-25 Thread Denys Vlasenko
On Mon, Mar 24, 2014 at 2:15 AM, Harald Becker ra...@gmx.de wrote: + bb_error_msg(skipping %s:%u: unimplemented command '%s', + /etc/ntp.conf, parser-lineno, token[0] + ); Bad idea to do this! The default ntpd.conf contains

Re: [PATCH v2] Ntpd config file support

2014-03-23 Thread Tito
On Saturday 22 March 2014 23:46:44 Isaac Dunham wrote: On Sat, Mar 22, 2014 at 08:40:48PM +0100, Harald Becker wrote: Hi Isaac ! Your program will fail on lines starting with the word server (eg. serverxyz), that is it does not check for clear word boundary and gives wrong results in

Re: [PATCH v2] Ntpd config file support

2014-03-23 Thread Denys Vlasenko
On Saturday 22 March 2014 23:46, Isaac Dunham wrote: On Sat, Mar 22, 2014 at 08:40:48PM +0100, Harald Becker wrote: Hi Isaac ! Your program will fail on lines starting with the word server (eg. serverxyz), that is it does not check for clear word boundary and gives wrong results in

Re: [PATCH v2] Ntpd config file support

2014-03-23 Thread Harald Becker
Hi Denys ! + bb_error_msg(skipping %s:%u: unimplemented command '%s', + /etc/ntp.conf, parser-lineno, token[0] + ); Bad idea to do this! The default ntpd.conf contains other options than just server lines. All those lines

Re: [PATCH v2] Ntpd config file support

2014-03-23 Thread Isaac Dunham
On Sun, Mar 23, 2014 at 03:06:08PM +0100, Denys Vlasenko wrote: On Saturday 22 March 2014 23:46, Isaac Dunham wrote: On Sat, Mar 22, 2014 at 08:40:48PM +0100, Harald Becker wrote: Hi Isaac ! Your program will fail on lines starting with the word server (eg. serverxyz), that is it

[PATCH v2] Ntpd config file support

2014-03-22 Thread Isaac Dunham
On Sat, Mar 22, 2014 at 08:40:48PM +0100, Harald Becker wrote: Hi Isaac ! Your program will fail on lines starting with the word server (eg. serverxyz), that is it does not check for clear word boundary and gives wrong results in that case. ...which are not legitimate entries in ntp.conf.