> The choice from using the max 80 char width comes from a time where we
> did not usually add the bloat-o-meter output to commit messages, but i
> agree that we should shorten it to silence the patch checkers. I like
> Dietmars suggestion to keep the numbers aligned.
>
> What is missing in our
On Mon, 11 Mar 2024 18:39:33 +0800
Kang-Che Sung wrote:
> I was curious. Is there a reason for BusyBox's bloat-o-meter script not to
> keep in sync with the version that comes in the Linux kernel source?
>
> I occasionally use the bloat-o-meter from the Linux kernel to compare even
> BusyBox
> He didn't mean to reduce the length of the line to 72, but to align
> the number (328 bytes) in the example with the last column of previous
> lines. Is one thing I also noted that your patch changed. Note the
> final 'bytes' word changed side.
Ohh okay now i see! Thank you Xabier and Dietmar
Hi Jones,
> > How about
> >
> > 72 (add/remove: 3/0 grow/shrink: 2/0 up/down: 328/0) Total bytes:
> > 328
> >
> > to keep the numbers aligned?
>
> Yes! 72 is totally aligned with function/old/new/delta length! :)
> And IMHO 75 columns is still a bit preferred than 72 columns, two reasons
> How about
>
> 72 (add/remove: 3/0 grow/shrink: 2/0 up/down: 328/0) Total bytes: 328
>
> to keep the numbers aligned?
Yes! 72 is totally aligned with function/old/new/delta length! :)
And IMHO 75 columns is still a bit preferred than 72 columns, two reasons
are considered:
1.
> From: busybox On Behalf Of Jones Syue ???
> Sent: Wednesday, March 13, 2024 2:22 AM
>
> > This patch replaces the 78 "-" prints with 75 "-". And replace the 80
> > columns summary line with 77 columns. ("%s" is considered as two chars
> > and should be filled with whitespace " ", so 77 = 75 +
> This patch replaces the 78 "-" prints with 75 "-". And replace the 80
> columns summary line with 77 columns. ("%s" is considered as two chars
> and should be filled with whitespace " ", so 77 = 75 + 2)
This is an example which showing how this patch wrapped line to 75 columns,
use awk to count
> Per test it looks like busybox has one more items: ".rodata", if the
> modification contains a format strings like this:
> log5("crond_dummy 1 %d %d\n", crond_dummy_global_int, crond_dummy_local_int);
Looks like the formatted strings is considered as a string literal, not a
symbol, while linux
> I was curious. Is there a reason for BusyBox's bloat-o-meter script not to
> keep in sync with the version that comes in the Linux kernel source?
It looks like busybox's bloat-o-meter has this addon: .rodata section diff.
Commit f14f7fc5cad5 ("Teach bloatometer about .rodata, and tweak the
Jones Syue 薛懷宗 於 2024年3月11日 星期一寫道：
> This patch replaces the 78 "-" prints with 75 "-". And replace the 80
> columns summary line with 77 columns. ("%s" is considered as two chars
> and should be filled with whitespace " ", so 77 = 75 + 2)
>
> Consider this scenario: a patch contains the output
This patch replaces the 78 "-" prints with 75 "-". And replace the 80
columns summary line with 77 columns. ("%s" is considered as two chars
and should be filled with whitespace " ", so 77 = 75 + 2)
Consider this scenario: a patch contains the output of "bloat-o-meter" to
clarify about the size
11 matches
Mail list logo
