Re: [PATCH v2 2/9] loop:refactor: extract subfunction get_next_free_loop()

2022-11-21 Thread Xiaoming Ni
On 2022/11/21 15:50, Kang-Che Sung wrote: On Mon, Nov 21, 2022 at 9:19 AM Xiaoming Ni wrote: static int get_next_free_loop(char *dev, size_t dev_size, int id) { int loopdevno = get_free_loop(); if (loopdevno >= 0) { snprintf(dev, dev_size, LOOP_FORMAT, loop

Re: [PATCH v2 2/9] loop:refactor: extract subfunction get_next_free_loop()

2022-11-20 Thread Kang-Che Sung
On Mon, Nov 21, 2022 at 9:19 AM Xiaoming Ni wrote: > static int get_next_free_loop(char *dev, size_t dev_size, int id) > { > int loopdevno = get_free_loop(); > if (loopdevno >= 0) { > snprintf(dev, dev_size, LOOP_FORMAT, loopdevno); > return 1; /

Re: [PATCH v2 2/9] loop:refactor: extract subfunction get_next_free_loop()

2022-11-20 Thread Xiaoming Ni
On 2022/11/19 1:40, Kang-Che Sung wrote: On Friday, November 18, 2022, Xiaoming Ni > wrote: > Step 2 of micro-refactoring the set_loop function () >         Extract subfunction get_next_free_loop() from set_loop() > > Also fix miss free(try) when stat(try) and

Re: [PATCH v2 2/9] loop:refactor: extract subfunction get_next_free_loop()

2022-11-18 Thread Kang-Che Sung
On Friday, November 18, 2022, Xiaoming Ni wrote: > Step 2 of micro-refactoring the set_loop function () > Extract subfunction get_next_free_loop() from set_loop() > > Also fix miss free(try) when stat(try) and mknod fail > > function old new

[PATCH v2 2/9] loop:refactor: extract subfunction get_next_free_loop()

2022-11-18 Thread Xiaoming Ni
Step 2 of micro-refactoring the set_loop function () Extract subfunction get_next_free_loop() from set_loop() Also fix miss free(try) when stat(try) and mknod fail function old new delta set_loop