Re: [v2] jdupes 1.11.1 port to BusyBox

2018-12-20 Thread Jody Bruchon
On 12/19/2018 8:16 AM, Tito wrote: On 11/12/18 18:29, Jody Bruchon wrote: This updated version of the jdupes duplicate file finder port to BusyBox adds a whole host of feature exclusions that allow further reduction of the applet's size. Nearly all of the final actions performed by jdupes

Re: [v2] jdupes 1.11.1 port to BusyBox

2018-12-19 Thread Tito
On 11/12/18 18:29, Jody Bruchon wrote: This updated version of the jdupes duplicate file finder port to BusyBox adds a whole host of feature exclusions that allow further reduction of the applet's size. Nearly all of the final actions performed by jdupes (deletion, linking, etc.) can be

Re: [v2] jdupes 1.11.1 port to BusyBox

2018-12-19 Thread Jody Bruchon
On 12/19/2018 7:10 AM, Xabier Oneca -- xOneca wrote: Hi, The redundant unknown option text is there so the big 'case' has a default block. It should never be reached, but it's there for safety just in case. I suppose the fprintf() could be changed out to the new unsupported_option()

Re: [v2] jdupes 1.11.1 port to BusyBox

2018-12-19 Thread Xabier Oneca -- xOneca
Hi, > The redundant unknown option text is there so the big 'case' has a default > block. It should never be reached, but it's there for safety just in case. I > suppose the fprintf() could be changed out to the new unsupported_option() > function for a tiny space savings, though it's probably

Re: [v2] jdupes 1.11.1 port to BusyBox

2018-12-19 Thread Jody Bruchon
On 12/19/2018 5:02 AM, Xabier Oneca -- xOneca wrote: Hello Jody, Why are you treating disabled options with the message 'Option %s is disabled in this build', when you already provide similar message for unknown options ('Sorry, using '-%c' is not supported.')? Won't save much, but I see them a

Re: [v2] jdupes 1.11.1 port to BusyBox

2018-12-19 Thread Xabier Oneca -- xOneca
Hello Jody, Why are you treating disabled options with the message 'Option %s is disabled in this build', when you already provide similar message for unknown options ('Sorry, using '-%c' is not supported.')? Won't save much, but I see them a bit redundant... Just my two cents, Xabier Oneca_,,_

Re: [v2] jdupes 1.11.1 port to BusyBox

2018-12-18 Thread Jody Bruchon
It's been a week since I sent this in. Does anyone have any questions, comments, thoughts or opinions? On 12/11/2018 12:29 PM, Jody Bruchon wrote: This updated version of the jdupes duplicate file finder port to BusyBox adds a whole host of feature exclusions that allow further reduction of

[v2] jdupes 1.11.1 port to BusyBox

2018-12-11 Thread Jody Bruchon
This updated version of the jdupes duplicate file finder port to BusyBox adds a whole host of feature exclusions that allow further reduction of the applet's size. Nearly all of the final actions performed by jdupes (deletion, linking, etc.) can be done by piping the output to a shell script