Re: [PATCH v1] Size reduction, cleanup, fixes, improvements for swapon/swapoff

2014-04-01 Thread Bastian Bittorf
* Tito farmat...@tiscali.it [01.04.2014 10:08]: Real swapoff does more or less the same: first /proc/swaps and then /etc/fstab. Doing both without further error checking maybe adds a little overhead but reduces code needed. i'am fine with this, maybe the reason is really to not rely on /proc

Re: [PATCH v1] Size reduction, cleanup, fixes, improvements for swapon/swapoff

2014-03-31 Thread Bastian Bittorf
* Tito farmat...@tiscali.it [31.03.2014 09:53]: So now swapoff first cycles through /proc/swaps and then through fstab to swapoff all devices. Does it make sense to swapoff devices which are not known via /proc/swaps? Or is it just if /proc is missing? nevertheless: thanks for submission!

Re: [PATCH v1] Size reduction, cleanup, fixes, improvements for swapon/swapoff

2014-03-31 Thread Denys Vlasenko
On Sun, Mar 30, 2014 at 9:55 PM, Tito farmat...@tiscali.it wrote: Hi to all, this patch started as a personal fun and learning project on swapon/swapoff after Matt Whitlock's patches. I was curios if there was a way to remove all the #ifdefs from within the code as for my personal taste

Re:[PATCH v1] Size reduction, cleanup, fixes, improvements for swapon/swapoff

2014-03-31 Thread Tito
* Tito farmatito at tiscali.it [31.03.2014 09:53]: So now swapoff first cycles through /proc/swaps and then through fstab to swapoff all devices. Does it make sense to swapoff devices which are not known via /proc/swaps? Or is it just if /proc is missing? nevertheless: thanks for submission!