Re: [PATCH 3/3] syslogd: add option to log to Linux kernel printk buffer

2013-01-06 Thread Peter Korsgaard
Mike == Mike Frysinger vap...@gentoo.org writes: Mike On Saturday 05 January 2013 18:07:19 Peter Korsgaard wrote: +#else +void kmsg_init(void); +void kmsg_cleanup(void); +void log_to_kmsg(int pri, const char *msg); +#endif /* FEATURE_KMSG_SYSLOG */ ... + if

Re: [PATCH 3/3] syslogd: add option to log to Linux kernel printk buffer

2013-01-06 Thread Mike Frysinger
On Saturday 05 January 2013 18:07:19 Peter Korsgaard wrote: Why invent our own shared memory circular buffer when the kernel has a perfectly fine one already? This can be used as a smaller/simpler alternative to the syslogd IPC support (as IPC shmem/klogd/logread aren't needed), while also

Re: [PATCH 3/3] syslogd: add option to log to Linux kernel printk buffer

2013-01-06 Thread Peter Korsgaard
Mike == Mike Frysinger vap...@gentoo.org writes: Hi, Mike On Saturday 05 January 2013 18:07:19 Peter Korsgaard wrote: Why invent our own shared memory circular buffer when the kernel has a perfectly fine one already? This can be used as a smaller/simpler alternative to the syslogd IPC

Re: [PATCH 3/3] syslogd: add option to log to Linux kernel printk buffer

2013-01-05 Thread Mike Frysinger
On Tuesday 18 December 2012 14:49:20 Peter Korsgaard wrote: + /* + kernel 3.5 expects single char printk KERN_* priority prefix, + from 3.5 onwards the full syslog facility/priority format is supported + */ comment style is slightly off. needs '*' at the start of each

Re: [PATCH 3/3] syslogd: add option to log to Linux kernel printk buffer

2013-01-05 Thread Peter Korsgaard
Mike == Mike Frysinger vap...@gentoo.org writes: Mike On Tuesday 18 December 2012 14:49:20 Peter Korsgaard wrote: + /* + kernel 3.5 expects single char printk KERN_* priority prefix, + from 3.5 onwards the full syslog facility/priority format is supported + */ Mike

Re: [PATCH 3/3] syslogd: add option to log to Linux kernel printk buffer

2013-01-05 Thread Mike Frysinger
On Saturday 05 January 2013 18:07:19 Peter Korsgaard wrote: +#else +void kmsg_init(void); +void kmsg_cleanup(void); +void log_to_kmsg(int pri, const char *msg); +#endif /* FEATURE_KMSG_SYSLOG */ ... + if (ENABLE_FEATURE_KMSG_SYSLOG (option_mask32 OPT_kmsg)) { +