Re: [PATCH] add paste implementation

2017-03-11 Thread Maxime Coste
Applied the suggested changes, except for dynamically allocating the files array. I can do it if thats preferred. I traced the getopt32 call to make sure, and it does not touch the argument pointer when the switch is not present, so giving it a default values works. --- AUTHORS

Re: [PATCH] add paste implementation

2017-03-11 Thread Tito
Hi, a few more hints. Hope this helps. Ciao, Tito On 03/11/2017 12:18 PM, Maxime Coste wrote: Applied the suggested changes, except for dynamically allocating the files array. I can do it if thats preferred. I traced the getopt32 call to make sure, and it does not touch the argument pointer

Re: [PATCH] add paste implementation

2017-03-11 Thread Maxime Coste
On Sat, Mar 11, 2017 at 06:59:52PM +0100, Tito wrote: > > +static const char optstring[] = "d:s"; > > Remove optstring and add it directly to getopt32 for better readability > > > +#define PASTE_OPT_DELIMITERS (1 << 0) > > +#define PASTE_OPT_SEPARATE (1 << 1) My idea here was that optstring

Re: [PATCH] add paste implementation

2017-03-11 Thread walter harms
Am 10.03.2017 19:07, schrieb Maxime Coste: > Hello, > > here is my stab at an implementation of patch, I hope this is the proper > patch format and the code is in a good enough shape. > > --- > AUTHORS| 3 + > coreutils/paste.c | 160 >

Re: [PATCH] add paste implementation

2017-03-11 Thread Xabier Oneca -- xOneca
Hi Maxime, > diff --git a/coreutils/paste.c b/coreutils/paste.c > new file mode 100644 > index 0..ab0ad43c5 > --- /dev/null > +++ b/coreutils/paste.c > @@ -0,0 +1,160 @@ > +/* vi: set sw=4 ts=4: */ > +/* > + * paste.c - implementation of the posix paste command > + * > + * Written by

Re: [PATCH] add paste implementation

2017-03-11 Thread Maxime Coste
On Sat, Mar 11, 2017 at 12:18:42PM +0100, Xabier Oneca -- xOneca wrote: > > +//usage:#define paste_example_usage > > +//usage: "# write out directory in four columns\n" > > +//usage: "$ ls | paste - - - -\n" > > +//usage: "# combine pairs of lines from a file into single lines\n"

Re: [PATCH] add paste implementation

2017-03-11 Thread Xabier Oneca -- xOneca
Hi Maxime, 2017-03-11 12:34 GMT+01:00 Maxime Coste : > On Sat, Mar 11, 2017 at 12:18:42PM +0100, Xabier Oneca -- xOneca wrote: >> > +//usage:#define paste_example_usage >> > +//usage: "# write out directory in four columns\n" >> > +//usage: "$ ls | paste - - - -\n"

Re: [PATCH] add paste implementation

2017-03-11 Thread Maxime Coste
Hello Xabier, On Sat, Mar 11, 2017 at 01:22:20PM +0100, Xabier Oneca -- xOneca wrote: > Hi Maxime, > > 2017-03-11 12:34 GMT+01:00 Maxime Coste : > > On Sat, Mar 11, 2017 at 12:18:42PM +0100, Xabier Oneca -- xOneca wrote: > >> > +//usage:#define paste_example_usage > >> >