Re: [PATCH] hush: allow hush to run embedded scripts

2018-11-27 Thread Denys Vlasenko
Applied, thanks! On Tue, Nov 27, 2018 at 3:34 PM Ron Yorston wrote: > > Embedded scripts require a shell to be present in the BusyBox > binary. Allow either ash or hush to be used for this purpose. > If both are enabled ash takes precedence. > > The size of the binary is unchanged in the default

Re: [PATCH] testsuite: check CONFIG_DESKTOP before using 'od -t'

2018-11-27 Thread Denys Vlasenko
Applied, thanks On Wed, Nov 21, 2018 at 5:00 AM Chen Qi wrote: > > The '-t' option for od is enabled by CONFIG_DESKTOP. So > check this config before using 'od -t' in test cases. > > Signed-off-by: Chen Qi > --- > testsuite/echo/echo-prints-dash| 1 + >

Re: [Bug 7748] New: ash: fix a memory leak

2018-11-27 Thread Yuki Machida
Hi Ron, I confirmed that it disappeard a memory leak after apply this patch. Best regards, Yuki On 2018/11/22 21:34, Ron Yorston wrote: There's another case where a leak is possible: when the redirection is associated with a subshell inside the long-running loop: while true; do ( true;

Re: [PATCH] build system: prevent duplicate applet names

2018-11-27 Thread Denys Vlasenko
Applied, thanks! On Sun, Nov 25, 2018 at 12:46 PM Ron Yorston wrote: > > The embedded script feature makes it easier to create applets with > duplicate names. Currently in such cases the build succeeds but > the resulting executable doesn't work as the developer intended. > > Catch duplicate

Re: [PATCH v2] Tweaks to build process for embedded scripts

2018-11-27 Thread Denys Vlasenko
Applied, thanks! On Wed, Nov 21, 2018 at 11:11 AM Ron Yorston wrote: > > - Force a rebuild if a script in applets_sh is changed. > > - Move the dummy usage messages for custom applets to usage.h and > change the name from 'dummy' to 'scripted'. > > - Hide an error from gen_build_files.sh if an

[PATCH] docs: add embedded-scripts.txt

2018-11-27 Thread Ron Yorston
Signed-off-by: Ron Yorston --- docs/embedded-scripts.txt | 116 ++ 1 file changed, 116 insertions(+) create mode 100644 docs/embedded-scripts.txt diff --git a/docs/embedded-scripts.txt b/docs/embedded-scripts.txt new file mode 100644 index

Re: Compiling Busybox against Bionic?

2018-11-27 Thread Denys Vlasenko
On Mon, Nov 26, 2018 at 7:15 PM Isaac Beckett wrote: > So from what I can tell, people want to compile Busybox against Bionic > because that's easier than having two libc's on their Android phone. And they > want access to unix tools? So some tools don't work, because Bionic doesn't >

Re: [PATCH] docs: add embedded-scripts.txt

2018-11-27 Thread Denys Vlasenko
On Tue, Nov 27, 2018 at 11:45 AM Ron Yorston wrote: > Signed-off-by: Ron Yorston > --- > docs/embedded-scripts.txt | 116 ++ > 1 file changed, 116 insertions(+) > create mode 100644 docs/embedded-scripts.txt > > diff --git a/docs/embedded-scripts.txt

Re: [PATCH] docs: add embedded-scripts.txt

2018-11-27 Thread Ron Yorston
Denys Vlasenko wrote: >How about adding support for embedded scripts if hush shell is selected, >and ash is not? I expect that would be possible. I'll have a look. >config: bool "Enable dependencies for mu" Sure. Ron ___ busybox mailing list

[PATCH] hush: allow hush to run embedded scripts

2018-11-27 Thread Ron Yorston
Embedded scripts require a shell to be present in the BusyBox binary. Allow either ash or hush to be used for this purpose. If both are enabled ash takes precedence. The size of the binary is unchanged in the default configuration: both ash and hush are present but support for embedded scripts