DHCPv6 renew message

2020-07-31 Thread Uwe Glaeser
Hi, Subject: DHCPv6 renew in /networking/udhcp/d6_dhcpc.c as stated in the RFC3315-comment of the function send_d6_renew() the message type should be set to D6_MSG_RENEW and not DHCPREQUEST (which is an IPv4 value). Or is there a reason for the DHCPREQUEST ? /* Unicast or broadcast a DHCP

Re: [PATCH 0/4] HTTPD: Add caching

2020-07-31 Thread Denys Vlasenko
Apologies for late reply. The removal of headers should be conditional on CONFIG variables - some people may used them, and also, since Date: is mandatory, unconditionally removing it doesn't feel right. Can you send a patch which combines patches 2, 3 and 4, and then, if you want, patches which

Re: [PATCH 1/5] httpd_indexcgi.c: minimize style CSS

2020-07-31 Thread Denys Vlasenko
Applied, thanks! On Fri, Jul 10, 2020 at 9:50 PM Sergey Ponomarev wrote: > > Remove new lines \n and some semicolons ;. This minimize page style size from > 655 to 604 > > Signed-off-by: Sergey Ponomarev > --- > networking/httpd_indexcgi.c | 74 ++--- > 1 file

Re: [PATCH 2/3] ip: Add support for "noprefixroute" option

2020-07-31 Thread Denys Vlasenko
Applied, thanks On Mon, Jun 29, 2020 at 6:32 PM Christian Eggers wrote: > > The "noprefixroute" option suppresses automatic generation of a routing > table entry based on the interface's ip address. > > The ifa_flags field has only 8 bit. If higher bits are set, > rta_tb[IFA_FLAGS] has to be

Re: [PATCH 2/5] httpd_indexcgi.c: use CSS for odd/even rows

2020-07-31 Thread Denys Vlasenko
This only works for me when in this order: "tr:nth-child(odd) { background-color:#ff }" \ "tr.hdr { background-color:#eee5de }" \ "tr.foot { background-color:#eee5de }" \ Modified and applied, thanks! On Fri, Jul 10, 2020 at 9:50 PM Sergey Ponomarev

Re: [PATCH 3/5] httpd_indexcgi.c: Simplify CSS

2020-07-31 Thread Denys Vlasenko
On Fri, Jul 10, 2020 at 9:50 PM Sergey Ponomarev wrote: > Divide table to thead, tbody and tfoot as it should be in DOM. > Add row hover style. > Use short color names. > > Signed-off-by: Sergey Ponomarev > --- > networking/httpd_indexcgi.c | 19 --- > 1 file changed, 12

Re: [PATCH 4/5] httpd_indexcgi.c: Remove new lines in HTML

2020-07-31 Thread Denys Vlasenko
On Fri, Jul 10, 2020 at 9:50 PM Sergey Ponomarev wrote: > > Nobody sees them, source code is here, resulted DOM can be seen in web > inspector I do look at it in "View page source", and it looks much worse when all newlines are removed. ___ busybox

Re: [PATCH 1/3] shell: Fix "read -d ''" behavior

2020-07-31 Thread Denys Vlasenko
Applied, thanks! On Mon, Jun 29, 2020 at 6:28 PM Christian Eggers wrote: > > With bash's read builtin it is possible to read from a file (e.g. > device-tree) until the first '\0' character: > > IFS= read -r -d '' VARIABLE < file > > In busybox ash the -d extension is also implemented, but

Re: [PATCH 3/3] ip address: Add support for "valid_lft" and "preferred_lft" options

2020-07-31 Thread Denys Vlasenko
Applied, thanks! On Mon, Jun 29, 2020 at 6:31 PM Christian Eggers wrote: > > Signed-off-by: Christian Eggers > --- > networking/libiproute/ip_common.h | 4 ++ > networking/libiproute/ipaddress.c | 65 +++ > 2 files changed, 62 insertions(+), 7 deletions(-) > > diff

Re: [PATCH 4/5] httpd_indexcgi.c: Remove new lines in HTML

2020-07-31 Thread Sergey Ponomarev
Yes, it looks worse but you can see the resulting DOM tree instead (elements/inspector). TBH as a web developer I almost never looked into raw source and always watch the DOM tree. On Fri, Jul 31, 2020 at 19:29 Denys Vlasenko wrote: > On Fri, Jul 10, 2020 at 9:50 PM Sergey Ponomarev > wrote: >

Re: [PATCH 4/5] httpd_indexcgi.c: Remove new lines in HTML

2020-07-31 Thread Xabier Oneca -- xOneca
Hello Sergey, El vie., 31 jul. 2020 a las 21:52, Sergey Ponomarev () escribió: > > Yes, it looks worse but you can see the resulting DOM tree instead > (elements/inspector). TBH as a web developer I almost never looked into raw > source and always watch the DOM tree. > > On Fri, Jul 31, 2020 at

Re: [PATCH 3/5] httpd_indexcgi.c: Simplify CSS

2020-07-31 Thread Sergey Ponomarev
the colors I selected because they are shorter and simpler. We may keep hex colors instead On Fri, 31 Jul 2020 at 19:25, Denys Vlasenko wrote: > On Fri, Jul 10, 2020 at 9:50 PM Sergey Ponomarev > wrote: > > Divide table to thead, tbody and tfoot as it should be in DOM. > > Add row hover style.

[PATCH] ip rule: add support for fwmark/fwmask for policy routing

2020-07-31 Thread Rui Salvaterra
This adds support for fwmark/fwmask in ip rule which is needed, for example, in OpenWrt's mwan3. Masks are supported since Linux 2.6.19. Fixes: https://bugs.busybox.net/show_bug.cgi?id=11621 Signed-off-by: Rui Salvaterra --- networking/ip.c| 2 +-