Re: [PATCH] Remove CONFIG_LFS for Android since it ignores _LARGEFILE_SOURCE

2011-12-15 Thread Denys Vlasenko
On Thu, Dec 15, 2011 at 2:59 AM, Daniel Fandrich d...@coneharvesters.com wrote: The sanity check added in 1dc80bae make Bionic compiles fail otherwise. Applied, thanks! -- vda ___ busybox mailing list busybox@busybox.net

Re: [PATCH] ifupdown: remove interface from state_list if iface_up fails

2011-12-15 Thread Denys Vlasenko
On Wed, Dec 14, 2011 at 3:49 PM, Lauri Hintsala lauri.hints...@bluegiga.com wrote: Fix the issue where interface is set to the configured state even if configuration has been failed. Add error check to state setting logic. Applied, thanks! -- vda ___

Minimal STUN client for finding external IP

2011-12-15 Thread Alexander Kriegisch
Someone in our project had the idea of using a STUN client like the one at https://sourceforge.net/projects/stun to determine a router's external IP address quickly and efficiently. Actually this is much faster than wget-ting the address from an external site via HTTP request. We tested this on

Re: No libbusybox.so config

2011-12-15 Thread Denys Vlasenko
On Wed, Dec 14, 2011 at 5:15 AM, Mark Constable ma...@renta.net wrote: On 14/12/11 03:36, Denys Vlasenko wrote: I can't seem to be able to get a libbusybox.so lib $ make defconfig $ make menuconfig  --  Busybox Settings  ---  Build Options  ---  [*] Build shared libbusybox  [*]   Produce

[PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is used

2011-12-15 Thread Peter Korsgaard
The memory pointed to by g_query gets overwritten when the index_page is used, causing URL arguments to get dropped when we fall back to /cgi-bin/index.cgi. Work around it by making g_query a deep copy of urlp when CGI support is enabled, rather than silently dropping them. Signed-off-by: Peter

Re: [PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is used

2011-12-15 Thread Paulius Zaleckas
On 12/15/2011 05:44 PM, Peter Korsgaard wrote: The memory pointed to by g_query gets overwritten when the index_page is used, causing URL arguments to get dropped when we fall back to /cgi-bin/index.cgi. Work around it by making g_query a deep copy of urlp when CGI support is enabled, rather

[PATCH] vconfig: Remove /proc/net/vlan/config check

2011-12-15 Thread Paulius Zaleckas
In original implementation /proc/net/vlan/config check only prints warning and does not exit. Busybox version exits if this file is not found and this prevents kernel module autoloading to work. I think it is safe to remove this check since ioctl() call will fail (with proper error code) anyway if

Re: [PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is used

2011-12-15 Thread Paulius Zaleckas
On 12/15/2011 05:50 PM, Paulius Zaleckas wrote: On 12/15/2011 05:44 PM, Peter Korsgaard wrote: The memory pointed to by g_query gets overwritten when the index_page is used, causing URL arguments to get dropped when we fall back to /cgi-bin/index.cgi. Work around it by making g_query a deep

Re: [PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is used

2011-12-15 Thread walter harms
Am 15.12.2011 16:50, schrieb Paulius Zaleckas: On 12/15/2011 05:44 PM, Peter Korsgaard wrote: The memory pointed to by g_query gets overwritten when the index_page is used, causing URL arguments to get dropped when we fall back to /cgi-bin/index.cgi. Work around it by making g_query a deep

Re: Minimal STUN client for finding external IP

2011-12-15 Thread Alexander Kriegisch
I am following up on this topic because Vladislav Grishenko was nice enough to provide me with some C code borrowed from Asterisk. Basically ministun is a basic stand-alone STUN client which determines the external IP (mapped address in STUN speak) and prints it to stdout. On my platform (mipsel)

Re: [PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is used

2011-12-15 Thread Peter Korsgaard
Paulius == Paulius Zaleckas paulius.zalec...@gmail.com writes: Hi, +#if ENABLE_FEATURE_HTTPD_CGI + /* tptr gets overwritten by index_page, so do deep copy + for /cgi-bin/index.cgi */ + g_query = alloca(strlen(tptr) + 1); + strcpy((char

Re: [PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is used

2011-12-15 Thread Peter Korsgaard
walter == walter harms wha...@bfs.de writes: Hi, Why not use strdup() instead? walter Why not use strdupa() instead? Because I wasn't aware of it. I see we aren't using it anywhere in busybox today, how portable is it? -- Bye, Peter Korsgaard

RE: Minimal STUN client for finding external IP

2011-12-15 Thread Vladislav Grishenko
Hi Alex, I've made standalone ministun for the same reasons (get external ip behind nat) in 2009 for one of my projects, but didn't publish it as well. Feel free to use, and yes, it could be even smaller using libbb and/or lowering printout level. Best Regards, Vladislav Grishenko -Original

Re: [PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is used

2011-12-15 Thread Dan Fandrich
On Thu, Dec 15, 2011 at 05:25:01PM +0100, Peter Korsgaard wrote: walter == walter harms wha...@bfs.de writes: walter Why not use strdupa() instead? Because I wasn't aware of it. I see we aren't using it anywhere in busybox today, how portable is it? According to the man page, it's not

[PATCH] udhcpd static route support

2011-12-15 Thread Michael McTernan
Hi, I found support for the classless static route options in udhcpd were partially implemented, so added the bits needed to make it work. I've tested this on an ARM9, where it costs 112 extra bytes in exe size (-Os and -mthumb mode). It parses the config given such as: option staticroutes

Re: [PATCH] httpd: don't drop QUERY_STRING when /cgi-bin/index.cgi is used

2011-12-15 Thread Denys Vlasenko
On Thursday 15 December 2011 16:44, Peter Korsgaard wrote: The memory pointed to by g_query gets overwritten when the index_page is used, Where exactly this happens? Here? - if (urlp[-1] == '/') strcpy(urlp, index_page); causing URL arguments to get dropped when we

Re: [PATCH] vconfig: Remove /proc/net/vlan/config check

2011-12-15 Thread Denys Vlasenko
On Thursday 15 December 2011 17:00, Paulius Zaleckas wrote: In original implementation /proc/net/vlan/config check only prints warning and does not exit. Busybox version exits if this file is not found and this prevents kernel module autoloading to work. I think it is safe to remove this check

Re: [PATCH] udhcpd static route support

2011-12-15 Thread Dan Fandrich
On Thu, Dec 15, 2011 at 10:57:19PM +, Michael McTernan wrote: + case OPTION_STATIC_ROUTES: { + char *bits; + + /* expect a.b.c.d/m format */ + bits = strchr(val, '/'); + if(!bits) { +