Re: [PATCH 3/3] ash: exec: -a option for setting zeroth arg

2017-04-12 Thread Kaarle Ritvanen
On Wed, 12 Apr 2017, Denys Vlasenko wrote: > I committed a change which implements "exec -a" > in a slightly different way. Please try current git. Works for me. Thanks a lot! BR, Kaarle ___ busybox mailing list busybox@busybox.net

Re: [PATCH 3/3] ash: exec: -a option for setting zeroth arg

2017-04-12 Thread Denys Vlasenko
On Tue, Apr 11, 2017 at 11:58 PM, Kaarle Ritvanen wrote: > -execcmd(int argc UNUSED_PARAM, char **argv) > +execcmd(int argc, char **argv) > { > - if (argv[1]) { > + int opt; > + char *argv0 = NULL; > + char *cmdname = NULL; > + > +

Re: [PATCH 2/3] ash: shellexec: rename variable

2017-04-12 Thread Denys Vlasenko
On Tue, Apr 11, 2017 at 11:58 PM, Kaarle Ritvanen wrote: > Signed-off-by: Kaarle Ritvanen > --- > shell/ash.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/shell/ash.c b/shell/ash.c > index

Re: [PATCH 1/3] libbb: GETOPT_RESET macro

2017-04-12 Thread Denys Vlasenko
On Tue, Apr 11, 2017 at 11:58 PM, Kaarle Ritvanen wrote: > Signed-off-by: Kaarle Ritvanen > --- > include/libbb.h| 19 +++ > libbb/getopt32.c | 8 +--- > libbb/vfork_daemon_rexec.c | 28

Re: [PATCH 3/3] ash: exec: -a option for setting zeroth arg

2017-04-12 Thread Kaarle Ritvanen
On Wed, 12 Apr 2017, Kang-Che Sung wrote: > Back in January 2017, a person named Patrick Pief has suggested a similar > patch > to add "exec -a" support: > > http://lists.busybox.net/pipermail/busybox/2017-January/085146.html > > Is your patch same as his or is there any difference? My patch

Re: [PATCH 3/3] ash: exec: -a option for setting zeroth arg

2017-04-12 Thread Kang-Che Sung
Back in January 2017, a person named Patrick Pief has suggested a similar patch to add "exec -a" support: http://lists.busybox.net/pipermail/busybox/2017-January/085146.html Is your patch same as his or is there any difference? ___ busybox mailing list

Re: [PATCH 1/3] libbb: GETOPT_RESET macro

2017-04-12 Thread Bartosz Gołaszewski
2017-04-11 23:58 GMT+02:00 Kaarle Ritvanen : > Signed-off-by: Kaarle Ritvanen > --- > include/libbb.h| 19 +++ > libbb/getopt32.c | 8 +--- > libbb/vfork_daemon_rexec.c | 28