[PATCH] chcon: trivial usage: '--reference' now depends on LONG_OPTS

2017-08-08 Thread Xabier Oneca -- xOneca
Hello, In one of the lastest mega-commits (036585a911a5fe6c2cd77b808dd9150500f37272 getopt32: remove applet_long_options) I've spotted (don't ask how ;) ) that in the chcon trivial usage now '--reference' is unconditionally displayed whether LONG_OPTS is enabled or not. This doesn't match

[PATCH v2 2/2] hush: implement -d DELIM option for `read`

2017-08-08 Thread Johannes Schindelin
The POSIX standard only requires the `read` builtin to handle `-r`: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/read.html However, Bash introduced the option `-d ` to override IFS for just one invocation, and it is quite useful. We already support this in ash, let's add it to hush,

Re: [PATCH] ash/hush: implement -d DELIM option for `read`

2017-08-08 Thread Johannes Schindelin
Hi, On Tue, 8 Aug 2017, Kang-Che Sung wrote: > On Mon, Aug 7, 2017 at 6:18 PM, Johannes Schindelin > wrote: > > The POSIX standard only requires the `read` builtin to handle `-r`: > > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/read.html > > > >

[PATCH v2 1/2] ash: implement -d DELIM option for `read`

2017-08-08 Thread Johannes Schindelin
The POSIX standard only requires the `read` builtin to handle `-r`: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/read.html However, Bash introduced the option `-d ` to override IFS for just one invocation, and it is quite useful. It is also super easy to implement in BusyBox' ash,

[PATCH v2 0/2] Support for `read -d`

2017-08-08 Thread Johannes Schindelin
This feature is used by Git's test suite. That is the incentive. It was also pretty to implement, so why not ;-) Changes since v1: - split into two patches, one for ash, one for hush, to make it easier to drop the hush one if so desired. - hide the feature behind the *_BASH_COMPAT knobs, as

Re: [PATCH] Silence misguided GCC warning about alignment issues

2017-08-08 Thread Ralf Friedl
Johannes Schindelin wrote: When compiling xz_dec_stream.c with GCC 7.1.0, it complains thusly: In function 'dec_stream_footer': error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] if (xz_crc32(s->temp.buf +

Re: [PATCH] Silence misguided GCC warning about alignment issues

2017-08-08 Thread Emmanuel Deloget
Hi Johannes On Tue, Aug 8, 2017 at 1:19 PM, Johannes Schindelin < johannes.schinde...@gmx.de> wrote: > Hi Emmanuel, > > On Mon, 7 Aug 2017, Emmanuel Deloget wrote: > > > And yes, its seems that the get_le32() macro in xz_private.h is a bit > > illegal with respect to strict aliasing, as it casts

Re: [PATCH] Silence misguided GCC warning about alignment issues

2017-08-08 Thread Johannes Schindelin
Hi Emmanuel, On Mon, 7 Aug 2017, Emmanuel Deloget wrote: > And yes, its seems that the get_le32() macro in xz_private.h is a bit > illegal with respect to strict aliasing, as it casts a uint8_t * into a > const uint32_t *. It would seem so. Until you realize that it is used only on s->temp.buf