Re: [PATCH] addgroup , adduser series.

2018-08-06 Thread haroon maqsood
From: busybox on behalf of Tito Sent: Monday, August 6, 2018 10:07 PM To: busybox Subject: Re: [PATCH] addgroup , adduser series. Hi, please don't add your replay to the top but add it to the end of the mail so that the mail

Re: [PATCH] addgroup , adduser series.

2018-08-06 Thread haroon maqsood
Hi, you are right my mistake, i thought of implementing --disabled-login and password . regarding the changes hmm, i agree the fixe(s)( i just tested adduser with no arguments no error was returned. so another fix) should be done indiviually. just taking advice here, if there is a rewrite

Re: [PATCH] addgroup , adduser series.

2018-08-06 Thread Tito
Hi, please don't add your replay to the top but add it to the end of the mail so that the mail could be read from top to bottom. So let us continue the discussions there On 06/08/2018 21:54, haroon maqsood wrote: Hi, i think it might be misunderstanding on my part  about the options. i

Re: [PATCH] addgroup , adduser series.

2018-08-06 Thread haroon maqsood
Hi, i think it might be misunderstanding on my part about the options. i was trying to fix this bug https://bugs.busybox.net/show_bug.cgi?id=10981 and restructure the code a bit, but i might be looking at the wrong version of adduser.c (apologies in advance ). the patch i have so far fixes