[PATCH] testsuite: check CONFIG_DESKTOP before using 'od -t'

2018-11-20 Thread Chen Qi
The '-t' option for od is enabled by CONFIG_DESKTOP. So check this config before using 'od -t' in test cases. Signed-off-by: Chen Qi --- testsuite/echo/echo-prints-dash| 1 + testsuite/echo/echo-prints-non-opts| 1 + testsuite/echo/echo-prints-slash-zero | 2 +-

Re: [Bug 7748] New: ash: fix a memory leak

2018-11-20 Thread Yuki Machida
Hi all, Please merge a patch to upstream of busybox. Following patch is applied to busybobx 03ad7ae08. (Modified with reference to http://lists.busybox.net/pipermail/busybox-cvs/2014-December/034873.html) I confirmed that fix a memory leak. diff --git shell/ash.c shell/ash.c index

Re: [PATCH] ash: reset tokpushback before prompting while parsing heredoc

2018-11-20 Thread Ron Yorston
Christoph Schulz wrote: >I could not reproduce the problem with dash, neither with git dash nor >with older versions (0.5.8, 0.5.9.1, 0.5.10.2, to name a few). >Something must be handled differently. But I haven't compared busybox >ash and dash sources thoroughly either. The same issue is

Re: [PATCH] ash: reset tokpushback before prompting while parsing heredoc

2018-11-20 Thread Christoph Schulz
Hello! Denys Vlasenko wrote on Tue Nov 20 2018 17:47:23 CET: Applied, thanks! (dash is also affected, mind pinging them?) I could not reproduce the problem with dash, neither with git dash nor with older versions (0.5.8, 0.5.9.1, 0.5.10.2, to name a few). Something must be handled

Re: [PATCH] ash: reset tokpushback before prompting while parsing heredoc

2018-11-20 Thread Denys Vlasenko
Applied, thanks! (dash is also affected, mind pinging them?) On Sun, Nov 11, 2018 at 2:05 PM Christoph Schulz wrote: > > The parser reads from an already freed memory location, thereby causing > unpredictable results, in the following situation: > > - ENABLE_ASH_EXPAND_PRMT is enabled > - heredoc

Re: wget code shrink (recent change)

2018-11-20 Thread Xabier Oneca -- xOneca
Hi Raffaello & Denys, First, thank you both very much for your quick response. >> I can't see why that change would generate less asm. Out of curiosity, >> anybody cares to explain? > > Not hard to guess… option_mask32 will already be in a register right after > the if, while it might need to be