Re: closing session in case of pam auth failed

2019-01-21 Thread Xabier Oneca -- xOneca
Hi Alex, ‪El mar., 22 ene. 2019 a las 8:04, ‫אלכסיי סיליוק‬‎ () escribió:‬ > > Hello, i faced that if PAM and CHILD_PROCCESS for login enabled, in case of > authorithation failure, session not closed. > i am added next to my code, may be it will be usable for somebody in future. > i added

closing session in case of pam auth failed

2019-01-21 Thread אלכסיי סיליוק
Hello, i faced that if PAM and CHILD_PROCCESS for login enabled, in case of authorithation failure, session not closed. i am added next to my code, may be it will be usable for somebody in future. i added F_PAM(login_pam_end(pamh);) inside pam_auth_failed block to force session closing @@ -470,8

Re: Issue/bug with wget over https and proxy

2019-01-21 Thread Denys Vlasenko
On Mon, Jan 21, 2019 at 2:53 PM Jakub Ledwoń wrote: > I have env variables set up like this: > http_proxy=http://proxy_ip:8080 > https_proxy=http://proxy_ip:8080 > ftp_proxy=http://proxy_ip:8080 > When I'm trying to use wget on https link behind this proxy, it fails. On > http links it works

Issue/bug with wget over https and proxy

2019-01-21 Thread Jakub Ledwoń
I have env variables set up like this: http_proxy=http://proxy_ip:8080 https_proxy=http://proxy_ip:8080 ftp_proxy=http://proxy_ip:8080 When I'm trying to use wget on https link behind this proxy, it fails. On http links it works without issues. I'm using v1.30.0 version of busybox. > > >

Re: [PATCH] sed: Fix backslash parsing for 'w' command arg

2019-01-21 Thread Denys Vlasenko
Applied, thanks! On Wed, Jan 2, 2019 at 10:10 PM Brian Foley wrote: > > If there's any whitespace between w and the filename, parse_file_cmd > writes to the wrong offset when trying to fix up backslashes. > > This can be seen in the asan build with busybox sed -e 'w 0\\' > > Signed-off-by: Brian

Re: [PATCH] awk: Fix overly permissive func arg list parsing

2019-01-21 Thread Denys Vlasenko
Applied all three patches, thanks! > +testing "awk func arg parsing 1" \ > + "awk 'func f(,) { }' 2>&1" "awk: cmd. line:1: Unexpected token" "" "" Should be "awk: cmd. line:1: Unexpected token\n" -- with \n ___ busybox mailing list

Re: [PATCH] capability: Fix string comparison in cap_name_to_number

2019-01-21 Thread Denys Vlasenko
Applied, thanks! On Fri, Jan 18, 2019 at 9:22 AM Mark Marshall wrote: > > Hi. > > > The attached patch fixes a bug in libbb/capability.c. > > The result of strcasecmp was being used wrongly. > > > This bug was introduced by change > > 44b3f2ffbc01c0a9fcfb5d60af3e292f505ac67c > > > Regards, > >