Re: bb_daemonize_or_rexec(DAEMON_CLOSE_EXTRA_FDS) does not close extra fds

2019-03-14 Thread Bernd Petrovitsch
Hi all! On 14/03/2019 16:35, Arnout Vandecappelle wrote: [...] > I've noticed that bb_daemonize_or_rexec(DAEMON_CLOSE_EXTRA_FDS + > DAEMON_DEVNULL_STDIO) does not actually close all fds. This is what gets > called > by start-stop-daemon -b, so it means that start-stop-daemon will propagate all

volume_id: off by one error detecting FAT16 vs FAT32

2019-03-14 Thread Thomas Frauendorfer
Hello, Busybox detects a FAT file system with 65524 clusters as FAT32 while it should handle it as FAT16. Because of that blkid cannot detect the uuid or label on a FAT with 65524 clusters. The attached patch fixes that mistake. The cluster count values are defined in: Microsoft Extensible

Re: bb_daemonize_or_rexec(DAEMON_CLOSE_EXTRA_FDS) does not close extra fds

2019-03-14 Thread Peter Korsgaard
On Thu, Mar 14, 2019 at 4:35 PM Arnout Vandecappelle wrote: > The problem is that the assumption that open() returns an fd that is larger > than all existing fds is simply wrong. > > I think that there is no other way to close all open fds than to iterate over > /proc/self/fd. But that is of