[PATCH] Makefile.flags: restrict Wno-constant-logical-operand and Wno-string-plus-int options for clang

2020-06-09 Thread Biswapriyo Nath
From 91ae0376f2044bedc062ad1fc30b57528b5c454f Mon Sep 17 00:00:00 2001 From: Biswapriyo Nath Date: Tue, 9 Jun 2020 23:05:12 +0530 Subject: [PATCH] Makefile.flags: restrict Wno-constant-logical-operand and Wno-string-plus-int options for clang these options were added in

Re: [PATCH v2] deluser: check if specified home is a directory before removing it

2020-06-09 Thread Denys Vlasenko
Applied. You want if (stat(pw->pw_dir, ) == 0 && S_ISDIR(st.st_mode)) in this case: the directory may be deleted already, should not bomb out in this case. On Tue, Jun 9, 2020 at 5:52 PM wrote: > > From: Sören Tempel > > On Alpine, some users use /dev/null as a home directory. When removing >

Re: [PATCH] dhcpc: refactor xmalloc_optname_optval to shrink binary size

2020-06-09 Thread Denys Vlasenko
Applied, thanks! On Tue, Jun 9, 2020 at 5:05 PM Martin Lewis wrote: > @@ -272,12 +270,12 @@ static NOINLINE char *xmalloc_optname_optval(uint8_t > *option, const struct dhcp_ > len--; > > nip = 0; > -

[PATCH v2] deluser: check if specified home is a directory before removing it

2020-06-09 Thread soeren
From: Sören Tempel On Alpine, some users use /dev/null as a home directory. When removing such a user with `deluser --remove-home` this causes the /dev/null device file to be removed which is undesirable. To prevent this pitfall, check if the home directory specified for the user is an actual

Re: [PATCH] httpd: allow '-h' to work when daemonized with NOMMU enabled

2020-06-09 Thread Denys Vlasenko
Applied, thanks! On Thu, Apr 30, 2020 at 9:32 PM Ron Yorston wrote: > > Commit d1b75e184 (httpd: permit non-default home directory with NOMMU > enabled) only works when used with the '-f' (foreground) option. > > When '-f' isn't specified and NOMMU is enabled bb_daemonize_or_rexec() > is called

[PATCH] dhcpc: refactor xmalloc_optname_optval to shrink binary size

2020-06-09 Thread Martin Lewis
function old new delta len_of_option_as_string 14 13 -1 dhcp_option_lengths 14 13 -1 udhcp_str2optset 717 715 -2

[PATCH] domain_codec: optimize call to dname_enc

2020-06-09 Thread Martin Lewis
The only call to dname_enc is with cstr = NULL, so most of dname_enc's logic is not used. Therefore, we can directly call convert_dname and shrink the binary size. function old new delta convert_dname -

Re: [PATCH v2] sysctl: fix the problem that no error is reported when access fails

2020-06-09 Thread Denys Vlasenko
Thanks, fixed in a bit different way On Sat, May 16, 2020 at 12:31 PM zhuyan (M) wrote: > > When an general user without authority sets the system configuration, > 0 is returned, but the modification is not successful. It is unreasonable. > > Such as, general user didn't have

Re: [PATCH] unexpand: correct behavior for --first-only --tabs=4

2020-06-09 Thread Denys Vlasenko
Applied, thanks! On Sat, May 30, 2020 at 7:06 PM Mark Edgar wrote: > > Prior to the patch, both -f and --first-only are in all cases either > no-op or ignored. > Without --tabs, --first-only is the default so specifying it is a no-op. > With --tabs, --all is implied, and --first-only is intended

Re: [PATCH] deluser: check if specified home is a directory before removing it

2020-06-09 Thread Tito
On 6/9/20 12:44 PM, soe...@soeren-tempel.net wrote: > From: Sören Tempel > > On Alpine, some users use /dev/null as a home directory. When removing > such a user with `deluser --remove-home` this causes the /dev/null > device file to be removed which is undesirable. To prevent this pitfall, >

[PATCH] deluser: check if specified home is a directory before removing it

2020-06-09 Thread soeren
From: Sören Tempel On Alpine, some users use /dev/null as a home directory. When removing such a user with `deluser --remove-home` this causes the /dev/null device file to be removed which is undesirable. To prevent this pitfall, check if the home directory specified for the user is an actual

AW: BusyBox 1.30.1 fstrim did not take effect

2020-06-09 Thread Walter Harms
fstrim check first with mount (or df or ..) what the mountpoints in your system are. Von: busybox im Auftrag von Tang Jiye Gesendet: Dienstag, 9. Juni 2020 04:40:24 An: busybox@busybox.net Betreff: BusyBox 1.30.1 fstrim did not take effect Hi, I am