Re: [PATCH 3/4] httpd: Support caching via 'ETag:' header

2020-07-11 Thread Sergey Ponomarev
Hi Xabier, thanks for the review. Unfortunately I don't have time anymore so if it is possible just remove the line after merge. As far On Sat, 11 Jul 2020 at 18:46, Xabier Oneca -- xOneca wrote: > Hi Sergey, > > Nice patch. Just one comment below: > > [...] > > diff --git a/networking/httpd.c

Re: [PATCH 3/4] lsscsi: code shrink and refactor

2020-07-11 Thread Markus Gothe
He shouldn't do anything stupid at all to begin with! Now go and sit in the corner! //Markus Sent from my BlackBerry - the most secure mobile device   Original Message   From: xon...@gmail.com Sent: July 11, 2020 17:57 To: martin.lewis@gmail.com Cc: busybox@busybox.net

Re: [PATCH 3/4] lsscsi: code shrink and refactor

2020-07-11 Thread Xabier Oneca -- xOneca
Hi Martin, > Remove the use of strou because scsi device types are signed (as seen in the > kernel's code). > Improve the representation of SCSI_DEVICE_LIST. Maybe you should make those changes in two patches: one that seems nice and is not attracting much attention (improve SCSI_DEVICE_LIST),

Re: [PATCH 3/4] httpd: Support caching via 'ETag:' header

2020-07-11 Thread Xabier Oneca -- xOneca
Hi Sergey, Nice patch. Just one comment below: [...] > diff --git a/networking/httpd.c b/networking/httpd.c > index 97b61fb77..50a837229 100644 > --- a/networking/httpd.c > +++ b/networking/httpd.c > @@ -1699,6 +1725,14 @@ static NOINLINE void send_file_and_exit(const char > *url, int what) >

Re: [PATCH] crontab: Fix -e with editors saving using renaming strategy

2020-07-11 Thread Denys Vlasenko
Applied, thanks On Sat, Jun 13, 2020 at 2:01 AM Gray Wolf wrote: > > Some editors (like vim) use renaming strategy to save file. That means > they save a file to some random name and then rename it to final > location. The advantage is that such save is atomic. > > However, crontab -e holds open