Re: [PATCH] ash: special treatment for 'busybox' in standalone shell mode

2017-07-28 Thread Denys Vlasenko
On Wed, Jul 26, 2017 at 11:31 AM, Ron Yorston wrote: > In standalone shell mode applets can be run from the shell without > having to install symlinks to them. You don't even need to set PATH. > Tab-completion also works. This makes minimal deployments of BusyBox > very easy to

Re: [PATCH] ash: support platforms that don't have '%m' printf specifier

2017-07-28 Thread Denys Vlasenko
On Thu, Jul 27, 2017 at 6:58 PM, Jody Bruchon wrote: > On 2017-07-27 12:16, Xabier Oneca -- xOneca wrote: >> >> Hello: >> >> 2017-07-27 17:48 GMT+02:00 Ron Yorston : >>> >>> Kang-Che Sung wrote: dietlibc supports %m only if WANT_ERROR_PRINTF is

Re: [PATCH] ash: support platforms that don't have '%m' printf specifier

2017-07-28 Thread Denys Vlasenko
On Thu, Jul 27, 2017 at 2:53 PM, Ron Yorston wrote: > The '%m' conversion specifier prints an error message based on the > current value of 'errno'. It is available in the GNU C library, > Cygwin (since 2012), uClibc and musl. > > It is not available in various BSDs, BSD-derived

Re: ash mis-compiles with clang

2017-07-28 Thread Denys Vlasenko
On Fri, Jul 28, 2017 at 1:30 AM, Yunlian Jiang wrote: > The TOT clang has this behavior. I will file a bug for that. Does it have a version number? ___ busybox mailing list busybox@busybox.net

Re: ash mis-compiles with clang

2017-07-27 Thread Denys Vlasenko
On Thu, Jul 27, 2017 at 6:21 PM, Yunlian Jiang <yunl...@google.com> wrote: > Yes, this patch works. > > Thanks > > On Thu, Jul 27, 2017 at 6:32 AM, Denys Vlasenko > <vda.li...@googlemail.com> wrote: >> On Wed, Jul 26, 2017 at 10:40 PM, Yunlian Jiang <yunl...

Re: [PATCH] unzip: fix regression on big-endian machines

2017-07-27 Thread Denys Vlasenko
Applied, thanks! On Tue, Jul 25, 2017 at 8:44 PM, Natanael Copa wrote: > This fixes a regression which was introduced with commit 2a0867a5 > ("unzip: optional support for bzip2 and lzma") and causes unzip to exit > with error when extracting archives: > > unzip:

Re: ash mis-compiles with clang

2017-07-27 Thread Denys Vlasenko
On Wed, Jul 26, 2017 at 10:40 PM, Yunlian Jiang wrote: > Hi, >When I try to build busybox with clang, I got some errors on ash at > runtime. >https://bugs.chromium.org/p/chromium/issues/detail?id=659834 > >It seems that root cause is clang adds the attribute

Re: [PATCH] ash: avoid GLIBC'ism %m

2017-07-25 Thread Denys Vlasenko
On Sun, Jul 23, 2017 at 9:34 PM, Denys Vlasenko <vda.li...@googlemail.com> wrote: > On Sat, Jul 22, 2017 at 8:56 PM, Johannes Schindelin > <johannes.schinde...@gmx.de> wrote: >> On Fri, 21 Jul 2017, Denys Vlasenko wrote: >> >>> On Wed, Jul 19, 2017 at 3:47

Re: [PATCH] ash: avoid GLIBC'ism %m

2017-07-23 Thread Denys Vlasenko
On Sat, Jul 22, 2017 at 8:56 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > On Fri, 21 Jul 2017, Denys Vlasenko wrote: > >> On Wed, Jul 19, 2017 at 3:47 AM, Jody Bruchon <j...@jodybruchon.com> wrote: >> > On 2017-07-18 9:15 PM, Kang-Che Sung wrote:

Re: [PATCH] ash: avoid GLIBC'ism %m

2017-07-21 Thread Denys Vlasenko
On Wed, Jul 19, 2017 at 3:47 AM, Jody Bruchon wrote: > On 2017-07-18 9:15 PM, Kang-Che Sung wrote: >> >> On Wed, Jul 19, 2017 at 2:11 AM, Markus Gothe >> wrote: >>> >>> Actually last time I checked ‘%m’ is POSIX contrary to glibc’s deprecated >>>

Re: About the approximate applet sizes in menuconfig

2017-07-20 Thread Denys Vlasenko
dated somewhen to reflect the code >changes, and I won't know how much maintenance burden will there be. >Sure it can be automated (like size_single_applets.sh), but updating the >Config.in files will probably make you crazy (sorry Denys Vlasenko). size_single_applets.sh does

Re: [PATCH] bootchartd: prevent premature stop by device mapper

2017-07-20 Thread Denys Vlasenko
Applied, thanks! On Wed, Jul 19, 2017 at 9:08 PM, Uwe Geuder (Nomovok Ltd.) wrote: > > kernel thread kdmflush was recognized as display manager kdm, check for > string length > > Signed-off-by: Uwe Geuder (Nomovok Ltd.) > --- >

Re: About the approximate applet sizes in menuconfig

2017-07-20 Thread Denys Vlasenko
On Wed, Jul 19, 2017 at 6:38 PM, Kang-Che Sung wrote: > (https://git.busybox.net/busybox/commit/?id=4eed2c6c5092ed95b8ee6d994106c54a9fc6ed3e) > > I don't like this. I don't like these size info to be put on the titles > of config options. A few reasons: > * It can give a

Re: [PATCH 2/2] arch/{sparc,sparc64}/Makefile: define ARCH_FPIC

2017-07-19 Thread Denys Vlasenko
On Tue, Jul 18, 2017 at 11:40 PM, Thomas Petazzoni <thomas.petazz...@free-electrons.com> wrote: > Hello, > > On Sat, 15 Jul 2017 14:44:21 +0200, Denys Vlasenko wrote: > >> Can you investigate this further? >> LIBBUSYBOX build results in entire busybox code being p

Re: [PATCH] od_bloaty: fix floating point output

2017-07-19 Thread Denys Vlasenko
Applied, thanks! On Wed, Jul 19, 2017 at 11:43 AM, Ron Yorston wrote: > Currently od_bloaty does this: > >$ /bin/echo -en '\x00\x00\x00\x00\x00\x00\x00\x00' | busybox od -f >od: invalid character 'F' in type string 'fF' >$ /bin/echo -en

1.27.1 is released

2017-07-18 Thread Denys Vlasenko
pplet Ben Hutchings: modprobe: read modules.builtin Cristian Ionescu-Idbohrn: appletlib: avoid warning on unused function ingroup unzip: remove now-pointless lseek which returns current position Denys Vlasenko: fix "ifdef ENABLE_foo": should always be "#i

Re: [PATCH] printf: fix format string sanity check

2017-07-18 Thread Denys Vlasenko
Applied, thanks! On Tue, Jul 18, 2017 at 10:33 AM, Ron Yorston wrote: > One of the tests for printf checks for an invalid bare '%' in the > format string: > >$ busybox printf '%' a b c >printf: %: invalid format > > On x86_64 a slightly different test doesn't work

Re: [PATCH 1/2] Makefile: include per-arch Makefile before Makefile.flags

2017-07-15 Thread Denys Vlasenko
Applied this patch, thanks On Fri, Jul 14, 2017 at 11:08 PM, Thomas Petazzoni wrote: > Makefile.flags contains: > > ARCH_FPIC ?= -fpic > ARCH_FPIE ?= -fpie > > However, arch/$(ARCH)/Makefile gets included *after* Makefile.flags, > and therefore doesn't get

Re: [PATCH 2/2] arch/{sparc,sparc64}/Makefile: define ARCH_FPIC

2017-07-15 Thread Denys Vlasenko
On Fri, Jul 14, 2017 at 11:08 PM, Thomas Petazzoni wrote: > Building Busybox on SPARC or SPARC64 with CONFIG_BUILD_LIBBUSYBOX=y > currently fails with: > > miscutils/lib.a(i2c_tools.o): In function `i2c_dev_open': > i2c_tools.c:(.text.i2c_dev_open+0x14):

Re: [PATCH v2 1/2] copyfd: reinstate proper guard around munmap()

2017-07-15 Thread Denys Vlasenko
On Fri, Jul 14, 2017 at 10:25 PM, Johannes Schindelin wrote: > In 4c1392296 (Introduce FEATURE_COPYBUF_KB, 2007-12-02), a feature was > introduced where a large stack was allocated via mmap() No, it is not a stack allocated there. It's a buffer for copying. > But

Re: [PATCH v2 2/2] ash: use JOBS as the compile time option it actually is

2017-07-15 Thread Denys Vlasenko
Applied, thanks On Fri, Jul 14, 2017 at 10:25 PM, Johannes Schindelin wrote: > Using the constant in a regular `if (...)` pretends that this is > anything but a compile time option. Let's use `#if JOBS` instead, > making it *much* clearer what `JOBS` actually is. > >

Re: [PATCH 2/3] inet_common: handle FEATURE_ETC_NETWORKS as a compile-time flag

2017-07-14 Thread Denys Vlasenko
On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin wrote: > This flag is used in #if ... #endif guards elsewhere and there is no > good reason to pretend that it is a runtime flag in just one case. > > This probably was an oversight in a61cb92f2 (make /etc/network

Re: [PATCH 1/3] copyfd: reinstate proper guard around munmap()

2017-07-14 Thread Denys Vlasenko
On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin wrote: > In 4c1392296 (Introduce FEATURE_COPYBUF_KB, 2007-12-02), a feature was > introduced where a large stack was allocated via mmap(), and > consequently released via munmap(). Since this is overkill for small >

Re: [PATCH 3/3] ash: use JOBS as the compile time option it actually is

2017-07-14 Thread Denys Vlasenko
On Fri, Jul 14, 2017 at 4:11 PM, Johannes Schindelin wrote: > Using the constant in a regular `if (...)` pretends that this is > anything but a compile time option. Let's use `#if JOBS` instead, > making it *much* clearer what `JOBS` actually is. > > Incidentally, this

Re: move files using find

2017-07-14 Thread Denys Vlasenko
On Thu, Jul 13, 2017 at 11:52 PM, David Henderson wrote: > Good evening all! I am trying to move files from one location to > another while preserving the path. If I search for a directory, it > seems like I have found the correct syntax: > > find

Re: [PATCH] cat: allow compiling out -n and -b

2017-07-14 Thread Denys Vlasenko
Applied, thanks On Thu, Jul 13, 2017 at 3:35 PM, Kang-Che Sung wrote: > When these options were introduced in d88f94a5df3a2edb8ba56fab5c13674b452f87ab > it provides no config options to compile them out. Now provide one. > > Introduce config FEATURE_CATN. > > Signed-off-by:

Re: [PATCH] libbb: Only setgid/setuid when necessary

2017-07-11 Thread Denys Vlasenko
On Mon, Jul 10, 2017 at 8:14 PM, Steven McDonald <ste...@steven-mcdonald.id.au> wrote: > On Mon, 10 Jul 2017 09:17:09 +0200 > Denys Vlasenko <vda.li...@googlemail.com> wrote: > >> * Don't check for errors: in normal use, they are impossible > > I don't thi

Re: [PATCH] util-linux: Suppress RPC error for recent uclibc

2017-07-10 Thread Denys Vlasenko
On Wed, Jul 5, 2017 at 10:46 AM, Jean-Loup 'clippix' Bogalho wrote: > Since version 1.0.23, uclibc-ng no longer includes a RPC implementation, the > error directive is not relevant for this and above versions. > > In buildroot the libtirpc package should be used instead. > >

Re: [PATCH] libbb: Only setgid/setuid when necessary

2017-07-10 Thread Denys Vlasenko
On Sun, May 21, 2017 at 12:57 AM, Steven McDonald wrote: > This makes 'unshare --user' work correctly in the case where the user's > shell is provided by busybox itself. > > 'unshare --user' creates a new user namespace without any uid mappings. > As a result,

Re: Add special times support to crond

2017-07-08 Thread Denys Vlasenko
On Thu, Jun 22, 2017 at 8:24 PM, Jonathan Kolb wrote: > I recently started using Alpine Linux, and ran into an issue where my > user could no longer use the @reboot cron feature to define its own > startup jobs. Attached is a patch to add support for the named times > found

Re: compile error: in process/free.c]

2017-07-07 Thread Denys Vlasenko
On Thu, Jul 6, 2017 at 10:13 AM, Bo YU wrote: > I am wamt to build rootfs with busybox,but error will report as below: > > > procps/free.c: In function ‘free_main’: > procps/free.c:78:17: error: storage size of ‘info’ isn’t known > procps/free.c:78:17: warning: unused variable

Re: [PATCH] setpriv: remove dependency on libcap headers

2017-07-07 Thread Denys Vlasenko
On Fri, Jul 7, 2017 at 3:40 PM, Patrick Steinhardt wrote: > The setpriv applet is including for the capget(2) and > capset(2) functions. Unfortunately, this header is not provided by > linux-headers, but by libcap instead, which requires users to have them > installed. As these

Re: [PATCH v3 6/6] setpriv: allow modifying ambient capabilities

2017-07-06 Thread Denys Vlasenko
Applied all patches, thanks. On Thu, Jul 6, 2017 at 3:21 PM, Patrick Steinhardt wrote: > With Linux 4.3, a new set of capabilities has been introduced with the > ambient capabilities. These aim to solve the problem that it was > impossible to grant run programs with elevated

Re: missing branch and tag for release 1.27.0

2017-07-06 Thread Denys Vlasenko
On Thu, Jul 6, 2017 at 1:22 PM, Natanael Copa wrote: > Hi, > > Congrats with the 1.27.0 release! > > I just want to point out that the 1_27_stable branch is missing. This > means that there is a broken link for "git" on the front page: >

Re: [PATCH 1/1] makedevs: set path size to match linux

2017-07-06 Thread Denys Vlasenko
On Thu, Jul 6, 2017 at 3:31 AM, Kang-Che Sung <explore...@gmail.com> wrote: > On Thu, Jul 6, 2017 at 8:04 AM, Denys Vlasenko <vda.li...@googlemail.com> > wrote: >> On Tue, Jun 27, 2017 at 3:20 PM, Kang-Che Sung <explore...@gmail.com> wrote: >>> Hello. C

Re: [PATCH 1/1] makedevs: set path size to match linux

2017-07-05 Thread Denys Vlasenko
On Tue, Jun 27, 2017 at 3:20 PM, Kang-Che Sung wrote: > Hello. Can I suggest another way? > How about modifying the `line` buffer so it can be used directly as the name, > and avoid the malloc problem or STRINGIFY(PATH_MAX) altogether. > > My suggestion (warning, this code

Re: [PATCH] dpkg: fix CONFIG_FEATURE_CLEAN_UP handling

2017-07-05 Thread Denys Vlasenko
On Wed, Jul 5, 2017 at 11:53 AM, Peter Korsgaard wrote: > dpkg moved to away from dynamically allocating the hashtables in commit > c87339d584 (dpkg: trivial code shrinkage, and redo G trick correctly) almost > ten years ago, but the cleanup code was never adjusted to match.

Re: 'case' UTF-8 bug

2017-07-05 Thread Denys Vlasenko
On Wed, Jul 5, 2017 at 8:56 PM, Martijn Dekker <mart...@inlv.org> wrote: > Op 05-07-17 om 19:15 schreef Denys Vlasenko: >> Fix is in git, please try and let me know how does it work. > > It fixes the bug I reported, but it introduces a new bug: the presence > of a quote

Re: 'case' UTF-8 bug

2017-07-05 Thread Denys Vlasenko
On Wed, Jul 5, 2017 at 6:15 PM, Denys Vlasenko <vda.li...@googlemail.com> wrote: > I reproduced it on another machine, with this libc: > > $ /lib/libc-2.22.so > GNU C Library (Gentoo 2.22-r4 p13) stable release version 2.22, by > Roland McGrath et al. > > The cause:

Re: 'case' UTF-8 bug

2017-07-05 Thread Denys Vlasenko
On Wed, Jul 5, 2017 at 1:50 AM, Martijn Dekker <mart...@inlv.org> wrote: > Op 04-07-17 om 20:23 schreef Denys Vlasenko: >> Ok. I just tested it again, and it works for me. >> Let's narrow it down more. My libc is: >> >> $ /lib64/libc.so.6 >> GNU C Library

Re: 'case' UTF-8 bug

2017-07-04 Thread Denys Vlasenko
On Tue, Jul 4, 2017 at 8:13 PM, Martijn Dekker <mart...@inlv.org> wrote: > Op 04-07-17 om 19:51 schreef Denys Vlasenko: >> You said earlier that environment makes no difference. > > That was incorrect, sorry about that. > >> For the locale, >> it shoul

Re: 'case' UTF-8 bug

2017-07-04 Thread Denys Vlasenko
On Sun, Jul 2, 2017 at 2:36 PM, Martijn Dekker wrote: Let's find out why it doesn't work for you. Is it environment? >>> [...] >>> >>> Nope, environment makes no difference. >>> >>> Finally found the time to track down the bug on my machine. It is >>> triggered by

Re: [PATCH v2 5/9] setpriv: dump inheritable capability set

2017-07-04 Thread Denys Vlasenko
On Sun, Jul 2, 2017 at 3:42 PM, Patrick Steinhardt wrote: > +static cap_user_header_t cap_header; > +static int cap_u32s; Non-readonly static data is not okay. Find a different way. busybox is trying hard to keep its data+bss as small ias possible: text data bss dec

Re: [PATCH v2 3/9] setpriv: dump user and group info

2017-07-04 Thread Denys Vlasenko
On Sun, Jul 2, 2017 at 3:42 PM, Patrick Steinhardt wrote: > setpriv from util-linux has an option to dump the current state > regarding privilege settings via `--dump`. It prints out information on > the real and effective user and group IDs, supplementary groups, the > no-new-privs

Re: [PATCH v2 2/9] setpriv: prepare option parsing logic for additional opts

2017-07-04 Thread Denys Vlasenko
On Sun, Jul 2, 2017 at 3:42 PM, Patrick Steinhardt wrote: > The current option parsing logic of setpriv only supports the case where > we want to execute a sub-program and have at most one argument. Refactor > handling of options to solve these shortcomings to make it easy to >

Re: Can Busybox support reproducible build?

2017-07-04 Thread Denys Vlasenko
On Tue, Jul 4, 2017 at 5:59 AM, Zhongwenlin wrote: > Hi, > > When I build Busybox 1.18.4, I find build results are different every time. > It seems to be caused by the code DBB_BT="AUTOCONF_TIMESTAMP”in > Makefile.flags, which would put a time stamp into the binary. > >

Re: [PATCH] Re: ash fails to read $HOME/.profile

2017-07-01 Thread Denys Vlasenko
On Tue, Jun 27, 2017 at 9:32 PM, Tito <farmat...@tiscali.it> wrote: > On 06/27/2017 05:53 PM, Denys Vlasenko wrote: >> On Mon, Jun 26, 2017 at 10:11 PM, Tito <farmat...@tiscali.it> wrote: >>> Hi, >>> the attached patch should fix the "as

Re: [PATCH] Re: ash fails to read $HOME/.profile

2017-07-01 Thread Denys Vlasenko
state = 3; > > What about always using the "else" part here and forget about > ENABLE_ASH_EXPAND_PRMT at all? read_profile() uses expandstr() on its argument. This is needed to support this commit: commit 2eb0a7e1b9a579ba34e4780c9ed8e74f38bc6b85 Author: Denys Vlasen

Re: [PATCH] Added support for timezones on dhcp6-client (RFC 4833)

2017-06-28 Thread Denys Vlasenko
On Wed, Jun 28, 2017 at 1:53 AM, tiggersWelt.net (Support) <supp...@tiggerswelt.net> wrote: > Am 27.06.2017 um 18:13 schrieb Denys Vlasenko: > [...] >> Let's unbreak -O OPT instead? IPv4 client adds list of -O options >> to outgoing packets using add_client_options() >

Re: [PATCH] Added support for timezones on dhcp6-client (RFC 4833)

2017-06-27 Thread Denys Vlasenko
On Mon, Jun 26, 2017 at 11:20 PM, tiggersWelt.net (Support) <supp...@tiggerswelt.net> wrote: > Good evening Denys, > > thank you for your effort! > > Am 26.06.2017 um 20:08 schrieb Denys Vlasenko: >> On Wed, Jun 21, 2017 at 4:29 PM, tiggersWelt.net (Support) >>

Re: [PATCH] Re: ash fails to read $HOME/.profile

2017-06-27 Thread Denys Vlasenko
On Mon, Jun 26, 2017 at 10:11 PM, Tito wrote: > Hi, > the attached patch should fix the "ash fails to read $HOME/.profile" bug > when ENABLE_ASH_EXPAND_PRMT is not set. > Kp could you please test if it fixes your problem when > ENABLE_ASH_EXPAND_PRMT is not set? > > Ciao, >

Re: Pgrep -fx not matching anything

2017-06-26 Thread Denys Vlasenko
On Mon, Jun 26, 2017 at 3:46 PM, Hadrien Lacour wrote: > It works now. The only difference with GNU is now the output (not really > important for me and better than GNU; no POSIX standard to follow here): > > $ sleep 1000 & > $ pgrep -flx "sleep 1000" > 24263 sleep

Re: [PATCH] Added support for timezones on dhcp6-client (RFC 4833)

2017-06-26 Thread Denys Vlasenko
On Wed, Jun 21, 2017 at 4:29 PM, tiggersWelt.net (Support) wrote: > static const char opt_req[] = { > (D6_OPT_ORO >> 8), (D6_OPT_ORO & 0xff), > - 0, 6, > + 0, 10, > (D6_OPT_DNS_SERVERS >> 8), (D6_OPT_DNS_SERVERS & 0xff), >

Re: Pgrep -fx not matching anything

2017-06-26 Thread Denys Vlasenko
Fixed in git just now, please try. On Tue, Jun 20, 2017 at 4:34 PM, Hadrien Lacour wrote: > Hello, > I'm having a bit of trouble using pgrep -fx; here's a simple example: > $ uname -a > Linux gentoo 4.9.33-gentoo #1 SMP Sun Jun 18 01:43:49 CEST 2017 x86_64 AMD >

Re: [PATCH] Implement -k (keep input files) for various (de)compressors.

2017-06-15 Thread Denys Vlasenko
On Fri, Jun 2, 2017 at 3:40 PM, Ari Sundholm wrote: > This is generally useful in many contexts where the normal utilities are > not available and compressed files are being used a lot. > > Bloat-o-meter: > > function old new

Re: [PATCH 2/2] unshare: fix help screen typo

2017-06-14 Thread Denys Vlasenko
Applied, thanks! On Sat, May 13, 2017 at 5:25 AM, Assaf Gordon wrote: > "-r/--map-root-user" implies "-U/--user", not "-u/--uts". > > Signed-off-by: Assaf Gordon > --- > util-linux/unshare.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [PATCH v3] setpriv: new applet

2017-06-14 Thread Denys Vlasenko
On Fri, May 19, 2017 at 4:48 AM, Assaf Gordon wrote: > Add a minimal 'setpriv' implementation supporting the NO_NEW_PRIVS bit. > As upstream only supports long options (--nnp/--no-new-privs), > A non-standard "-N" option is also added for the applet. > > Typical usage: > >

Re: [PATCH] iproute: support for filtering by and printing of scope

2017-06-13 Thread Denys Vlasenko
On Wed, May 31, 2017 at 1:36 PM, André Draszik wrote: > This patch adds filtering by and printing of 'scope' to the > ip route command, taken from the upstream ip command. Applied, thanks! ___ busybox mailing list busybox@busybox.net

Re: [PATCH] tar: add IF_FEATURE_* checks

2017-06-13 Thread Denys Vlasenko
Applied, thanks! On Fri, Jun 2, 2017 at 10:47 AM, wrote: > From: Ming Liu > > A following linking error was observed: > | == > | archival/lib.a(tar.o): In function `tar_main': > | archival/tar.c:1168: undefined reference to

Re: [PATCH] ash: fix incorrect path in describe_command

2017-05-26 Thread Denys Vlasenko
On Fri, May 26, 2017 at 9:31 AM, Youfu Zhang wrote: > $ PATH=/extra/path:/usr/sbin:/usr/bin:/sbin:/bin \ >> busybox sh -xc 'command -V ls; command -V ls; command -Vp ls; command -vp ls' > + command -V ls > ls is /bin/ls > + command -V ls > ls is a tracked alias for /bin/ls >

Re: udhcpc changes in 1.25.0 that didn't seem to be mentioned?

2017-05-26 Thread Denys Vlasenko
On Tue, May 23, 2017 at 10:39 AM, Natanael Copa wrote: > This issue is affecting Alpine Linux too. From the setup script we will > start network in the background while user creates the root password. > However, udhcpc will not print information on the screen about the >

Re: [PATCH] ls: fix support for long options when FEATURE_LS_COLOR is deselected

2017-05-26 Thread Denys Vlasenko
On Fri, May 26, 2017 at 1:38 PM, Laurent Bercot wrote: > Declaration of ls_longopts and initialization of applet_long_options > were incorrectly guarded with ENABLE_FEATURE_LS_COLOR; that yielded a > "ls: NO_OPT: \xff" error message when long options were selected and >

Re: [PATCH] add/remove-shell: prevent world writable /etc/shells

2017-05-26 Thread Denys Vlasenko
On Wed, May 10, 2017 at 6:40 PM, Natanael Copa wrote: > add-shell will not preserve the current permissions, and if umask is 0 > it will create the /etc/shells world writable. To reproduce: > > umask 0; add-shell /bin/bash; ls -l /etc/shells > > As a workaround we add the

Re: ash buildin "read" interrupted on SIGCHLD

2017-05-22 Thread Denys Vlasenko
On Tue, May 9, 2017 at 11:14 AM, Guido Classen wrote: > Hi, > > I've observed some strange behavior in ash buildin "read" when > a SIGCHLD arrives in current busybox. > > old behavior on busybox 1.24.2 ash (same behavior also on Debian bash and > dash) > >sleep 1&

Re: Resubmitting a patch

2017-05-15 Thread Denys Vlasenko
On Fri, May 12, 2017 at 6:52 PM, James Byrne wrote: > Hi, > > I submitted a patch to this mailing list on December 15, 2016 which updated > sv, runsv and svlogd by pulling in all the upstream changes and fixes to > match version 2.1.2 of runit. > > I didn't receive

Re: busybox unzip fails with empty zip arhcive

2017-05-02 Thread Denys Vlasenko
On Mon, May 1, 2017 at 10:40 PM, Grant Edwards wrote: > The Busybox 'unzip' utility returns a failure status and prints an > error message when it's given an properly formatted (but empty) zip > archive. > >$ hexdump -C empty.zip > 50 4b 05 06 00 00 00

Re: [PATCH 2/2] time: implement -a and -o

2017-04-28 Thread Denys Vlasenko
Applied both, thanks! On Mon, Apr 24, 2017 at 6:08 PM, Tommi Rantala wrote: > From: Tommi Rantala > > Add support for -a and -o options, similar to GNU time. > > Signed-off-by: Tommi Rantala > --- > miscutils/time.c |

Re: [PATCH] add exec -a support (preliminary)

2017-04-18 Thread Denys Vlasenko
Fixed in current git. On Sat, Mar 18, 2017 at 1:06 PM, Patrick Pief <p.p...@zoho.com> wrote: > On Wed, 01 Feb 2017 15:22:39 +0100 Patrick Pief <p.p...@zoho.com> wrote > > > On Wed, 01 Feb 2017 07:30:46 +0100 Denys Vlasenko > <vda.li...@googlemail.

Re: [PATCH] add lsscsi implementation

2017-04-18 Thread Denys Vlasenko
Applied. But the code was rather awful. On Sat, Apr 8, 2017 at 7:35 PM, Markus Gothe wrote: > That’s one of those things that happens when you use existing code as a > boilerplate. > I’ve fixed it in the attached file. > > > On 07 Apr 2017, at 23:25 , Emmanuel Deloget

Re: warning: this 'if' clause does not guard...

2017-04-17 Thread Denys Vlasenko
fixed, thanks! On Sat, Apr 15, 2017 at 3:33 PM, Cristian Ionescu-Idbohrn wrote: > coreutils/factor.c: In function 'factor_main': > coreutils/factor.c:204:5: warning: this 'if' clause does not guard... > [-Wmisleading-indentation] > if (*end != '\0'); >

Re: [PATCH 3/3] ash: exec: -a option for setting zeroth arg

2017-04-12 Thread Denys Vlasenko
On Tue, Apr 11, 2017 at 11:58 PM, Kaarle Ritvanen wrote: > -execcmd(int argc UNUSED_PARAM, char **argv) > +execcmd(int argc, char **argv) > { > - if (argv[1]) { > + int opt; > + char *argv0 = NULL; > + char *cmdname = NULL; > + > +

Re: [PATCH 2/3] ash: shellexec: rename variable

2017-04-12 Thread Denys Vlasenko
On Tue, Apr 11, 2017 at 11:58 PM, Kaarle Ritvanen wrote: > Signed-off-by: Kaarle Ritvanen > --- > shell/ash.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/shell/ash.c b/shell/ash.c > index

Re: [PATCH 1/3] libbb: GETOPT_RESET macro

2017-04-12 Thread Denys Vlasenko
On Tue, Apr 11, 2017 at 11:58 PM, Kaarle Ritvanen wrote: > Signed-off-by: Kaarle Ritvanen > --- > include/libbb.h| 19 +++ > libbb/getopt32.c | 8 +--- > libbb/vfork_daemon_rexec.c | 28

Re: [PATCH] Add help text for 'uniq -i'

2017-04-05 Thread Denys Vlasenko
applied, thanks! On Thu, Mar 30, 2017 at 6:29 PM, Jody Bruchon wrote: > Looks like I missed the help text in the last patch. This time I've attached > it in a way that shouldn't mangle the tabs. > > ___ > busybox mailing list >

Re: [PATCH 1/1] switch_root: Fix undefined fd and minor tweak

2017-04-05 Thread Denys Vlasenko
On Fri, Mar 31, 2017 at 7:34 AM, Rafał Miłecki wrote: > On 03/30/2017 06:19 PM, Andrei Gherzan wrote: >> >> On Fri, Mar 24, 2017 at 3:56 PM, Andrei Gherzan >> wrote: >>> >>> Signed-off-by: Andrei Gherzan >>> --- >>>

Re: mdev change no longer supporting v2.6.2x kernels by using /sys/dev

2017-04-05 Thread Denys Vlasenko
On Fri, Mar 24, 2017 at 11:25 AM, Richard Moore wrote: >>> "Richard" == Richard Moore writes: >> >> > Hi, >> > Would it be possible to please make the recent mdev change in v1.26 an >> > option? >> >> > * mdev (mdev: create devices from /sys/dev) commit

Re: [PATCH] uniq: add -i option to ignore case

2017-03-30 Thread Denys Vlasenko
Patch looks good, but it is tab-damaged. Fixed that and applied. Thanks. On Thu, Mar 30, 2017 at 5:12 PM, Jody Bruchon wrote: > > > ___ > busybox mailing list > busybox@busybox.net >

Re: [PATCH] udhcpc6 ll-address-, options- and release-/renew-fix

2017-03-27 Thread Denys Vlasenko
On Wed, Mar 8, 2017 at 12:15 PM, tiggersWelt.net (Support) wrote: > this is my first post on the list and my first set of patches I wrote > for busybox, so please forgive me if I'm missing something. > > We are currently trying to build an IPv6-only-environment with

Re: Busybox httpd sends output of stderr to the Website

2017-03-26 Thread Denys Vlasenko
On Sat, Mar 25, 2017 at 9:04 AM, Laurent Bercot wrote: >> Unless they do want _remote user_ to see the message. >> >> For example, if you start a shell over a tcp connection >> ("poor man's telnet"), you do want to see shell error messages >> when you work in that shell,

Re: [PATCH] vi: avoid touching a new file with ZZ when no editing has been done

2017-03-24 Thread Denys Vlasenko
On Mon, Feb 13, 2017 at 4:00 AM, Yousong Zhou wrote: > This is the behaviour observed with standard vim and busybox vi of at > least 1.22.1. It was changed with commit "32afd3a vi: some > simplifications" which happened before 1.23.0. > > Mistyping filename on command line

Re: Busybox httpd sends output of stderr to the Website

2017-03-24 Thread Denys Vlasenko
On Thu, Mar 23, 2017 at 11:45 AM, Steve Bennett wrote: > >> On 23 Mar 2017, at 5:51 PM, Dirk Lohse wrote: >> >> A workaround for me is to not use inetd mode. But the reason for this >> behavior should be found and fixed - I think. >> >> Dirk >> > >

Re: [PATCH] quote arguments in xtrace output

2017-03-24 Thread Denys Vlasenko
On Sun, Mar 19, 2017 at 8:51 PM, Martijn Dekker <mart...@inlv.org> wrote: > Op 19-03-17 om 20:18 schreef Denys Vlasenko: >> Is it in dash git already? >> >> Can you ping me when it reaches dash git? > > Official dash development is completely dead at the mom

Re: [PATCH 1/1] switch_root: When console doesn't exist don't bail out

2017-03-24 Thread Denys Vlasenko
Applied, thanks On Fri, Mar 24, 2017 at 12:44 AM, Andrei Gherzan wrote: > Busybox is very often used in initramfs at the end of which usually > there is a switch_root to the actual rootfs. There are many cases where > the console kernel argument is either just a placeholder

Re: init - sysvinit vs BusyBox

2017-03-23 Thread Denys Vlasenko
On Sun, Mar 19, 2017 at 9:03 PM, Shay Hofman wrote: > A novice question - > > Is it possible to tweak and change busybox on an existing embedded device? > To be exact I'm referring to Dlink home router device which has a very > limited and stripped down busybox os. > Very

Re: [PATCH] add paste implementation

2017-03-23 Thread Denys Vlasenko
On Tue, Mar 21, 2017 at 7:00 PM, Maxime Coste wrote: > Hello, > > Any update on this ? > > Here is the latest version of the patch, still waiting on a clear decision > regarding loop variable definition location. Applied this version. Please review. Thanks! /* vi: set sw=4

Re: [PATCH] quote arguments in xtrace output

2017-03-19 Thread Denys Vlasenko
Is it in dash git already? Can you ping me when it reaches dash git? On Sat, Mar 18, 2017 at 6:45 AM, Martijn Dekker wrote: > The xtrace (set -x) output in ash is a bit of a pain, because arguments > containing whitespace aren't quoted. This can make it impossible to tell >

Re: Leading dash in inittab and FEATURE_INIT_SCTTY

2017-03-19 Thread Denys Vlasenko
On Sun, Mar 19, 2017 at 6:20 PM, Patrick Pief wrote: > Since FEATURE_INIT_SCTTY seems to have an additional effect on inittab entries > with a leading dash it might be good idea to also mention this possible > behavior in the example inittab. Which example inittab? There are

Re: [RFC 1/2] Add hidden option FEATURE_HAVE_SEAMLESS_COMPRESSION

2017-03-19 Thread Denys Vlasenko
On Thu, Mar 16, 2017 at 3:53 AM, Kang-Che Sung <explore...@gmail.com> wrote: > On Tue, Mar 14, 2017 at 1:42 AM, Denys Vlasenko > <vda.li...@googlemail.com> wrote: >> This change make future entries in config affect the past. >> In menuconfig, this makes items in

Re: [PATCH] dd: call fsync() only once before exiting if conv=fsync is specified

2017-03-16 Thread Denys Vlasenko
Applied, thanks On Tue, Mar 14, 2017 at 5:44 PM, Rostislav Skudnov wrote: > Signed-off-by: Rostislav Skudnov > --- > coreutils/dd.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/coreutils/dd.c b/coreutils/dd.c >

Re: Automatic deletion of loopback device upon umount?

2017-03-16 Thread Denys Vlasenko
On Wed, Mar 15, 2017 at 7:16 PM, Denys Vlasenko <vda.li...@googlemail.com> wrote: > On Wed, Mar 15, 2017 at 3:16 AM, Denys Vlasenko > <vda.li...@googlemail.com> wrote: >> On Tue, Mar 7, 2017 at 6:12 PM, Mirko Vogt <busy...@nanl.de> wrote: >>>> "fo

Re: Automatic deletion of loopback device upon umount?

2017-03-15 Thread Denys Vlasenko
On Wed, Mar 15, 2017 at 3:16 AM, Denys Vlasenko <vda.li...@googlemail.com> wrote: > On Tue, Mar 7, 2017 at 6:12 PM, Mirko Vogt <busy...@nanl.de> wrote: >>> "foo" is a cramfs filesystem file which might help illustrate the issue >>> >>> 1) loopbac

Re: Automatic deletion of loopback device upon umount?

2017-03-14 Thread Denys Vlasenko
On Tue, Mar 7, 2017 at 6:12 PM, Mirko Vogt wrote: >> "foo" is a cramfs filesystem file which might help illustrate the issue >> >> 1) loopback mount "foo" to mount /bar >> 2) umount /bar >> 3) append new files and re-generate the "foo" cramfs image >> 4) loopback mount "foo" to

Re: Bug in runit: chpst -n -N -u doesn't work

2017-03-13 Thread Denys Vlasenko
Applied, thanks. (Deweloper is not an acceptable name for git authorship...) On Thu, Mar 2, 2017 at 11:05 PM, Deweloper wrote: > Hi, > > busybox's chpst first switches user/group and then tries to call nice(). > Once the root priviledges are dropped, process

Re: [PATCH 2/2] vi: don't touch file with :x when modified_count == 0

2017-03-13 Thread Denys Vlasenko
On Wed, Feb 22, 2017 at 2:11 PM, Yousong Zhou wrote: > Along with it, there are other changes > > - Check for uppercase X is removed as the expression will be always false and >:X itself is another totally different command in standard vim > - The status line will

Re: BusyBox v1.4.2, telnet show "Login Incorrect" error message

2017-03-13 Thread Denys Vlasenko
On Mon, Feb 20, 2017 at 1:27 PM, Vesta wrote: > BusyBox v1.4.2 on an embedded device running Linux v2.6.18. Can you try a newer version? Current one is 1.26.2 ___ busybox mailing list busybox@busybox.net

Re: [PATCH] Before calling execvp(), reset needs to flush stdout.

2017-02-17 Thread Denys Vlasenko
Applied, thanks On Thu, Feb 16, 2017 at 3:45 PM, Glenn Matthews (glmatthe) wrote: > Before calling execvp(), reset needs to flush stdout. > > Otherwise the reset sequence gets dropped on the floor. > --- > AUTHORS | 3 +++ > console-tools/reset.c | 2 ++ > 2

Re: [PATCH] modprobe: simplify code (printf in do_modprobe())

2017-02-12 Thread Denys Vlasenko
This would print extra trailing space. On Thu, Feb 9, 2017 at 4:02 PM, Kang-Che Sung wrote: > Signed-off-by: Kang-Che Sung > --- > modutils/modprobe.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/modutils/modprobe.c

Re: [PATCH 3/3] modprobe-small: define and use DEPMOD_OPT_n (option mask)

2017-02-12 Thread Denys Vlasenko
Applied, thanks On Thu, Feb 9, 2017 at 3:48 PM, Kang-Che Sung wrote: > Signed-off-by: Kang-Che Sung > --- > modutils/modprobe-small.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/modutils/modprobe-small.c

Re: [PATCH 1/3] modprobe-small: document '-n' in depmod usage

2017-02-12 Thread Denys Vlasenko
Applied, thanks On Thu, Feb 9, 2017 at 3:48 PM, Kang-Che Sung wrote: > Signed-off-by: Kang-Che Sung > --- > modutils/modprobe-small.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/modutils/modprobe-small.c

Re: timeout setting for login

2017-02-08 Thread Denys Vlasenko
On Tue, Feb 7, 2017 at 5:18 PM, Patrick Pief <p.p...@zoho.com> wrote: > On Mon, 06 Feb 2017 20:33:39 +0100 Denys Vlasenko > <vda.li...@googlemail.com> wrote > > Traditionally, Unix logins are not handled by running "login" > > program in a lo

<    5   6   7   8   9   10   11   12   13   14   >