Re: [PATCH] Add -t noproc,tmpfs options to mount/umount

2007-04-04 Thread Roy Marples
On Wed, 4 Apr 2007 21:44:04 +0200 Bernhard Fischer [EMAIL PROTECTED] wrote: a) put common funcs into libbb/*.c, see loop.c as an example. b) both strncmp as well as strlen are most likely much bloatier than needed. Let me point to current trunk's coreutils/dd.c and there the block below what

Re: [Bug?] init.c: problems if kernel gets console=null via cmdline

2007-07-04 Thread Roy Marples
On Wed, 4 Jul 2007 20:58:11 +0200 Harald Küthe [EMAIL PROTECTED] wrote: Try this: in init.c, add else clause as shown below: static void console_init(void) { struct serial_struct sr; char *s; s = getenv(CONSOLE); if (!s) s = getenv(console);

Re: find / rm corrupting memory

2008-01-25 Thread Roy Marples
On Fri, 2008-01-25 at 22:55 +, Denis Vlasenko wrote: Can you post your .config? Attached. Thanks Roy # # Automatically generated make config: don't edit # Busybox version: 1.9.0 # Fri Jan 25 15:33:01 2008 # CONFIG_HAVE_DOT_CONFIG=y # # Busybox Settings # # # General Configuration #

[PATCH] mount should respect _netdev in /etc/fstab

2008-01-25 Thread Roy Marples
Hi List. Some people need to say which normal filesystems are network mounted, by using _netdev as an fstab option. Attached is a patch that allows this. Thanks Roy diff -ur busybox-1.9.0.orig/util-linux/mount.c busybox-1.9.0/util-linux/mount.c --- busybox-1.9.0.orig/util-linux/mount.c

find / rm corrupting memory

2008-01-25 Thread Roy Marples
Hi List. I'm trying to track down a memory corruption when using the following /tmp/bb $ touch a b /tmp/bb $ find . -type f -exec rm -rf -- {} \; /tmp/bb $ touch a b c /tmp/bb $ find . -type f -exec rm -rf -- {} \; rm: invalid option -- BusyBox v1.9.0 (2008-01-25 14:43:46 GMT) multi-call

Re: find / rm corrupting memory

2008-01-25 Thread Roy Marples
On Friday 25 January 2008 16:05:06 Mike Frysinger wrote: it helps to know what shell you're actually using and your config file The config file is whatever the Gentoo ebuild makes, just without start-stop-daemon built in. So that would also be the ash shell. Thanks Roy

Re: find / rm corrupting memory

2008-01-26 Thread Roy Marples
On Saturday 26 January 2008 17:01:26 walter harms wrote: Roy Marples wrote: Hi List. I'm trying to track down a memory corruption when using the following /tmp/bb $ touch a b /tmp/bb $ find . -type f -exec rm -rf -- {} \; /tmp/bb $ touch a b c /tmp/bb $ find . -type f -exec rm -rf

Re: find / rm corrupting memory

2008-01-28 Thread Roy Marples
On Sun, 2008-01-27 at 22:05 +, Denis Vlasenko wrote: On Saturday 26 January 2008 07:19, Roy Marples wrote: On Fri, 2008-01-25 at 22:55 +, Denis Vlasenko wrote: Can you post your .config? Attached. Aha. CONFIG_FEATURE_PREFER_APPLETS=y! Can you test something for me? Go

Re: find / rm corrupting memory

2008-01-29 Thread Roy Marples
On Mon, 2008-01-28 at 22:56 +, Denis Vlasenko wrote: Applied to svn, can you test it now? Works for me! Thanks Roy ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

[PATCH] Allow kbd_mode to choose tty

2008-01-30 Thread Roy Marples
Hi kbd_mode upstream has added the -C option so that options can be applied to a specific tty instead of just the console. I've added this to busybox kbd_mode applet, and hopefully cleaned up existing option parsing a little. I'm uncertain if I got opt_complementary right - basically all options

fsck -A goes into infinite loop and kills all processes

2008-01-31 Thread Roy Marples
Which isn't good. I get wait: No more child process?!? a zillion times down the screen, hit ctrl-c and then boom, everything dies. Debugging is . tricky as such and I can't see anything obviously wrong. I think you need 1 partition to check in /etc/fstab. I have quite a few on all my

Re: fsck -A goes into infinite loop and kills all processes

2008-01-31 Thread Roy Marples
On Thu, 2008-01-31 at 12:52 -0500, Paul Fox wrote: Which isn't good. I get wait: No more child process?!? a zillion times down the screen, hit ctrl-c and then boom, everything dies. Debugging is . tricky as such and I can't see anything obviously wrong. do you have

[PATCH] fsck -A goes into infinite loop and kills all processes

2008-01-31 Thread Roy Marples
On Thu, 2008-01-31 at 18:17 +, Roy Marples wrote: On Thu, 2008-01-31 at 12:52 -0500, Paul Fox wrote: Which isn't good. I get wait: No more child process?!? a zillion times down the screen, hit ctrl-c and then boom, everything dies. Debugging is . tricky

Re: PATCH: udhcpc -- don't request set of options by default

2008-04-02 Thread Roy Marples
On Tuesday 01 April 2008 23:37:38 L. Gabriel Somlo wrote: On Wed, Apr 02, 2008 at 12:14:14AM +0200, Denys Vlasenko wrote: Imagine that I have *two* interfaces, both sit on DHCP configured networks (*different* networks). Here one deconfig-ed iface will happily nuke /etc/resolv.conf

Re: start-stop-daemon: stopping daemons on unionfs fails

2008-04-06 Thread Roy Marples
On Sunday 06 April 2008 14:40:08 pieterg wrote: Stopping a daemon with the -x argument fails on unionfs. The reason is that pid_is_exec (debianutils/start_stop_daemon.c) looks where the /proc/pid/exe symlink points to, but that is not necessarily the real location of the executable in the

Re: Nameif broken

2008-04-10 Thread Roy Marples
On Thursday 10 April 2008 03:03:21 Denys Vlasenko wrote: Appended is a patch to fix nameif, I've also extended the cleanup-code to match the new data structure and did some minor code shrinks. - *skip_non_whitespace(line_ptr) = '\0'; + *strpbrk(line_ptr, \t\n:)

[PATCH 1/2] start-stop-daemon --test

2008-04-30 Thread Roy Marples
start-stop-daemon should implement --test option. This is used to check if the daemon is running or not. Thanks Roy --- a/debianutils/start_stop_daemon.c 2008-04-19 04:50:30.0 +0100 +++ b/debianutils/start_stop_daemon.c 2008-04-30 11:08:46.0 +0100 @@ -32,6 +32,7 @@ char

[PATCH 2/2] start-stop-daemon - find processes better

2008-04-30 Thread Roy Marples
start-stop-daemon uses stat to match running binaries. This is not good as the binary in question could be moved or deleted during an upgrade. This patch instead checks how the daemon was started and mirrors how Gentoo's start-stop-daemon implementation works. Thanks Roy diff -ur

Re: [PATCH 1/2] start-stop-daemon --test

2008-04-30 Thread Roy Marples
On Wednesday 30 April 2008 12:15:36 Roy Marples wrote: start-stop-daemon should implement --test option. This is used to check if the daemon is running or not. Refactored against current svn. function old new delta start_stop_daemon_main

Re: [PATCH 2/2] start-stop-daemon - find processes better

2008-04-30 Thread Roy Marples
On Wednesday 30 April 2008 12:59:30 Bernhard Fischer wrote: On Wed, Apr 30, 2008 at 12:18:05PM +0100, Roy Marples wrote: start-stop-daemon uses stat to match running binaries. This is not good as the binary in question could be moved or deleted during an upgrade. This patch instead checks

Re: [PATCH 2/2] start-stop-daemon - find processes better

2008-04-30 Thread Roy Marples
On Wednesday 30 April 2008 14:37:31 Denys Vlasenko wrote: On Wednesday 30 April 2008 13:40, Joakim Tjernlund wrote: On Wed, 2008-04-30 at 12:18 +0100, Roy Marples wrote: start-stop-daemon uses stat to match running binaries. This is not good as the binary in question could be moved

Re: [PATCH 1/2] start-stop-daemon --test

2008-04-30 Thread Roy Marples
On Wednesday 30 April 2008 14:57:53 Denys Vlasenko wrote: On Wednesday 30 April 2008 13:15, Roy Marples wrote: start-stop-daemon should implement --test option. This is used to check if the daemon is running or not. + test = (opt OPT_TEST); It already is in a variable. Lets use

Re: [PATCH 2/2] start-stop-daemon - find processes better

2008-04-30 Thread Roy Marples
On Wednesday 30 April 2008 15:20:27 Roy Marples wrote: Sure Refactored against svn function old new delta check755 847 +92 start_stop_daemon_main 10121034

Re: [PATCH 2/2] start-stop-daemon - find processes better

2008-04-30 Thread Roy Marples
On Wednesday 30 April 2008 16:25:10 Joakim Tjernlund wrote: But the intent of start-stop-daemon is to start and stop daemons. s-s-d --stop --exec /usr/sbin/ntpd I would that expect it to stop the currently running ntpd process regardless of if the binary itself still exists or not. Don't

Re: [PATCH 2/2] start-stop-daemon - find processes better

2008-05-01 Thread Roy Marples
On Thursday 01 May 2008 08:53:44 Denys Vlasenko wrote: Hereby I am informing all interested parties that I am totally confused now. I am not using ssd and I need your help in making a decent documentation how it work (or supposed to) The Debian man page was never that clear either. I

Re: [PATCH 2/2] start-stop-daemon - find processes better

2008-05-01 Thread Roy Marples
On Thursday 01 May 2008 12:39:16 you wrote: Roy, the above all makes sense and your patch looks good too. One minor thing, I don't think you need the + if (execname) + xstat(execname, execstat); anymore or am I missing something? Checking the existance of the binary to start?

Re: [PATCH 2/2] start-stop-daemon - find processes better

2008-05-01 Thread Roy Marples
On Thursday 01 May 2008 14:18:40 Denys Vlasenko wrote: -a,--startas pathname Start process specified by pathname WRONG? it seems to just set argv[0]. It's not a pathname, it's just a name (arbitrary) Correct. It's a crap option. Gentoo silently remaps it to --exec Are you

Re: udhcpc and IPv6

2008-05-16 Thread Roy Marples
On Thursday 15 May 2008 22:30:00 dallas wrote: Does anyone know if udhcpc has been upgraded to fully support IPv6 yet? I'm eager to hear from anyone who has direct experience using it with IPv6. I would appreciate any advice you can provide. udhcp is IPv4 only. You should look at ISC DHCP-4

Re: [PATCH] libbb print_flags() -380 bytes

2008-06-06 Thread Roy Marples
On Friday 06 June 2008 19:58:34 Natanael Copa wrote: Bernhard Fischer wrote: Index: include/libbb.h === --- include/libbb.h(revision 3) +++ include/libbb.h(working copy) @@ -1304,7 +1304,14 @@ /* sh */

Re: udhcpc in 1.10.3 doesnt like my WLAN card

2008-06-19 Thread Roy Marples
On Thursday 19 June 2008 19:58:19 Denys Vlasenko wrote: On Thursday 19 June 2008 14:43, Cristian Ionescu-Idbohrn wrote: The problem seems to be that your wlan-card does not see/catch the dhcp-offer. Cristian, this is not true. In tcpdump I see This is the packet from us: and this is the

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-01 Thread Roy Marples
On Tuesday 01 July 2008 09:27:22 Andreas Wetzel wrote: hi again, in start-stop-daemon, if --background is given, i think we should completely detach the called process, including closing all extra file-descriptors. for non-mmu, this seems to be the case. but if BB_MMU is set, we do not set

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-01 Thread Roy Marples
On Tuesday 01 July 2008 13:03:00 Denys Vlasenko wrote: I would expect this to work echo password | start-stop-daemon --start --exec /usr/sbin/pppd --background -- plugins passwdfd 0 Your patch would break that yes? It already does not work, if I read code correctly (bb_daemonize()

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-01 Thread Roy Marples
On Tuesday 01 July 2008 13:01:56 Denys Vlasenko wrote: ssd: do not stat -x EXECUTABLE, it is not needed anymore Then userland won't catch an error with ssd --background when the file does not exit :/ Please re-consider this. Thanks Roy ___ busybox

Re: [PATCH] start-stop-daemon: close extra fds on --background

2008-07-01 Thread Roy Marples
On Tuesday 01 July 2008 13:44:52 Denys Vlasenko wrote: On Tuesday 01 July 2008 12:25, Roy Marples wrote: On Tuesday 01 July 2008 13:01:56 Denys Vlasenko wrote: ssd: do not stat -x EXECUTABLE, it is not needed anymore Then userland won't catch an error with ssd --background when the file

Re: Applet proposal - gratuitous ARP daemon

2008-07-02 Thread Roy Marples
On Wednesday 02 July 2008 01:23:38 William Hegardt wrote: I've written a small gratuitous ARP daemon that could be modified to become a busybox applet and contributed if there's any interest. It periodically scans the list of network interfaces and sends out gratuitous ARP packets on each

Re: udhcpc and Infiniband support

2008-07-11 Thread Roy Marples
On Friday 11 July 2008 21:28:00 Frank Leers wrote: So, is udhcpc supported over Infiniband? Currently, no. However dhcpcd-3.2 [1] and upwards do support DHCP over Infiniband. dhcpcd-4 should as well, as the part of the code hasn't changed, but no-one's tested this. I don't have the hardware,

Re: Ответ: [patch] fix for autodocifier.pl uninitialized value in join

2008-09-01 Thread Roy Marples
On Mon, 2008-09-01 at 17:55 +, Vladimir Dronnikov wrote: And -D option for install, please :^) I can't compile buildroot using BB coreutils... Would be better for builtroot upstream to not use GNU extensions for install so that they can install without error on BSD systems. Also, that would

Re: Ответ: Ответ: [patch] fix for autodocifier.pl uninitialized value in join

2008-09-01 Thread Roy Marples
On Mon, 2008-09-01 at 19:32 +, Vladimir Dronnikov wrote: I wish someone heard you, Roy. install -D is used heavily by buildroot, but I'm not so advanced in Makefiles to cope this by myself. And buildrooters seem to be quite happy with current state of things. I have to spoil my build

Re: Backslashed escape sequences

2008-09-20 Thread Roy Marples
On Sat, 2008-09-20 at 01:46 +0200, Denys Vlasenko wrote: Seems like a discrepancy between bash and coreutils. All manpages I can find do not mention \e. Let's not torture ourself yet trying to mimic both at once, especially that \x1b and \033 work. echo is just not portable. You should use

Re: Backslashed escape sequences

2008-09-21 Thread Roy Marples
On Saturday 20 September 2008 17:51:51 Denys Vlasenko wrote: On Saturday 20 September 2008 04:56, Marc W. Abel wrote: Correct -- I missed the -e in the example. Can you push bash and coreutils (echo and prints utilities in particular) to decide what is the right thing to do? busybox will

Re: Backslashed escape sequences

2008-09-22 Thread Roy Marples
On Mon, 2008-09-22 at 10:30 -0500, Rob Landley wrote: No, busybox has adopted a few shells, of which ash is probably the most POSIX compliant one. busybox has never adopted bash. Bash as a codebase to use, no. Bash as a de-facto Linux standard against which to compare its shell behavior,

Re: Backslashed escape sequences

2008-09-22 Thread Roy Marples
On Monday 22 September 2008 17:57:03 Alain M. wrote: This Bash subject is really controversial. As was well explained by Rob, non-bash behaviour will break many things, and apparently so will the reverse. How is this controversial? Expecting /bin/sh to behave like bash is just as silly as

Re: Backslashed escape sequences

2008-09-22 Thread Roy Marples
On Monday 22 September 2008 22:50:10 Denys Vlasenko wrote: Admit it, both things are important: * Following standards is important when you write code, otherwise it will be difficult to support it Agreed :) * Being able to support some extensions dialects of a particular shell is

Re: Backslashed escape sequences

2008-09-22 Thread Roy Marples
On Mon, 22 Sep 2008 18:15:37 -0500 Rob Landley [EMAIL PROTECTED] wrote: To give a trivial example, I've attached a patch for gen_initramfs_list.sh (untested) that should allow it to work for busybox ash. By your argument, you could have #!/usr/bin/perl and expect it to run your python

setfont/kbd_mode - which console?

2008-11-04 Thread Roy Marples
Hi List Sometime ago I submitted patches for busybox setfont and kbd_mode to support the -C device option, which specified the console device to take action upon. Either they didn't get accepted for whatever reason, or lost somewhere in the ether. Either way, the old patches no longer apply.

Re: setfont/kbd_mode - which console?

2008-11-04 Thread Roy Marples
On Tuesday 04 November 2008 15:46:56 Bernhard Reutner-Fischer wrote: Given these stats you should add a get_console_fd_from_name_or_die(const char *dev) instead of adding penalties for the NULL arg everywhere. That saves a futher 30 bytes. uberlaptop busybox-1.12.1 # ./scripts/bloat-o-meter

Re: setfont/kbd_mode - which console?

2008-11-05 Thread Roy Marples
On Tuesday 04 November 2008 17:22:54 Bernhard Reutner-Fischer wrote: On Tue, Nov 04, 2008 at 04:52:42PM +, Roy Marples wrote: On Tuesday 04 November 2008 15:46:56 Bernhard Reutner-Fischer wrote: Given these stats you should add a get_console_fd_from_name_or_die(const char *dev) instead

Re: setfont/kbd_mode - which console?

2008-11-08 Thread Roy Marples
Denys Vlasenko wrote: On Tuesday 04 November 2008 16:03, Roy Marples wrote: On Tuesday 04 November 2008 14:58:30 Roy Marples wrote: So, in an attempt yet again to get OpenRC to boot cleanly using busybox here's a patch that enables -C device for kbd_mode and setfont. The patch is done so

Re: setfont/kbd_mode - which console?

2008-11-08 Thread Roy Marples
Denys Vlasenko wrote: Ok, I made kbd_mode accept -C TTY. Please check current svn. Looks good! Thanks Roy ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: Console/terminal mixup with bb-1.13

2008-11-24 Thread Roy Marples
On Sun, 2008-11-23 at 20:46 +0100, Harald Küthe wrote: /* Make sure init can't be blocked by writing to stderr */ fcntl(STDERR_FILENO, F_SETFL, fcntl(STDERR_FILENO, F_GETFL) | O_NONBLOCK); Can you confirm that just removing these lines from 1.13.0 makes it work? If yes,

Re: mount -a remounts tmpfs entries: bug or feature?

2008-11-24 Thread Roy Marples
On Mon, 24 Nov 2008 12:46:10 +0300, Vladimir Dronnikov [EMAIL PROTECTED] wrote: Personally, I'd like to be able to mount valid stuff the way I wish. For a manual mount, I agree. But I think 'mount -a' should mount everything from /etc/fstab, unless it is already mounted. I fear mount

Re: mount -a remounts tmpfs entries: bug or feature?

2008-11-24 Thread Roy Marples
On Mon, 24 Nov 2008 15:10:30 +0300, Vladimir Dronnikov [EMAIL PROTECTED] wrote: ...rathole when mount becomes _stateful_ utility. Do we need more quirks...? It's not a quirk, it's needed :) BSD man pages state that -a will ignore entries that already appear to be mounted. core. Although

Re: How does udhcpc determine dhcp timeout?

2008-11-24 Thread Roy Marples
On Mon, 2008-11-24 at 23:04 +0100, Denys Vlasenko wrote: On Monday 24 November 2008 19:32, Donovan Jay-MGIA2023 wrote: This electronic transmission (and any attached documentation) is for the sole use of the individual or entity to whom it is addressed. It is confidential. Any further

Re: mount -a remounts tmpfs entries: bug or feature?

2008-11-24 Thread Roy Marples
On Tue, 2008-11-25 at 03:04 +0100, Denys Vlasenko wrote: On Monday 24 November 2008 10:21, Ralf Friedl wrote: Vladimir Dronnikov wrote: run 'mount -a' over and over you get stacking mounts Personally, I'd like to be able to mount valid stuff the way I wish. So BB behaves

Re: svn commit: trunk/busybox

2008-12-23 Thread Roy Marples
On Tue, 2008-12-23 at 03:23 -0600, Rob Landley wrote: Man format is obsolete. Everybody who actually understands that weird set of nested macro packages is over 50 years old. The mandoc format is very much alive and kicking. I understand it quite well and am very much under 50 years of age.

Re: bash-like arrays with busybox / ash

2009-03-12 Thread Roy Marples
Guenter wrote: Hi all, I just suprisingly found that latest busybox 1.13.3 seems not yet support arrays like bash does, f.e. something like: #!/bin/ash url='http://' files=(`wget -q -O - $url`) for ((i=0; i${#files[*]}; i++)); do echo $i - ${files[$i]} done returns: ./getlist: line 3:

Re: bash-like arrays with busybox / ash

2009-03-12 Thread Roy Marples
Guenter wrote: Here's what I have now, and this works basically, though still need to understand the set construct: set -- one two three Sets the position parameters $1 $2 and $3 to one two three respectively set -- hello world foo bar $1=hello world $2=foo $3=bar somefunc() { echo $1