[PATCH] addgroup code cleanup, size reduction and feature enhancement

2007-03-27 Thread Tito
# ./busybox_old addgroup prova tito [EMAIL PROTECTED]:~/Desktop/busybox.new# ./busybox_old addgroup prova dina addgroup: prova: group already in use 3) the above mentioned feature was re-added as optional function enabled by ENABLE_FEATURE_ADDUSER_TO_GROUP. Nowif called with two non

[PATCH] new features for deluser/delgroup

2007-04-14 Thread Tito
84 165 +81 The patch is tested and seems to work for me it applies cleanly to svn revision 18446. Critics and review are as always welcome. ;-) Please apply if you like it. Ciao, Tito --- scripts/defconfig.orig 2007-04-13 13:58:03.0 +0200 +++ scripts/defconfig

Re: Build broken

2007-04-17 Thread Tito
On Monday 16 April 2007 21:51:41 Denis Vlasenko wrote: On Sunday 15 April 2007 14:09, Tito wrote: Hi, current svn r 18452 doesn't compile. :-( Should be fixed now. Yell if it doesn't -- vda Yes, thanks! Works for me. I see only a few warnings now: findutils/find.c: In function

Re: /etc/busybox.conf confusion [secutiry?]

2007-04-27 Thread Tito
uid=1000(tito) gid=1000(tito) groups=7(lp),20(dip),24(cdrom),25(floppy),29(audio),46(plugdev),111(admin),113(fuse),1000(tito),1002(vboxusers),1003(halt) [EMAIL PROTECTED]:~$ /usr/bin/passwd ruid = 1000 /*debug */ busybox.conf readable /*debug */ found su /*debug */ found passwd /*debug */ requested

Re: [patch] New-applet howto. (and new applet)

2007-05-08 Thread Tito
On Tuesday 08 May 2007 21:32:28 Tito wrote: On Tuesday 08 May 2007 19:52:31 Denis Vlasenko wrote: On Tuesday 08 May 2007 15:15, Thomas Lundquist wrote: On Tue, May 08, 2007 at 12:39:55AM +0200, Denis Vlasenko wrote: string is optional, thus should be [string]. This also takes

Re: [patch] New-applet howto. (and new applet)

2007-05-09 Thread Tito
On Wednesday 09 May 2007 01:25:21 Denis Vlasenko wrote: On Tuesday 08 May 2007 22:22, Tito wrote: On Tuesday 08 May 2007 21:32:28 Tito wrote: On Tuesday 08 May 2007 19:52:31 Denis Vlasenko wrote: On Tuesday 08 May 2007 15:15, Thomas Lundquist wrote: On Tue, May 08, 2007 at 12:39

Re: hexdump: No help available in busybox v1.4.2

2007-06-04 Thread Tito
CONFIG_FEATURE_VERBOSE_USAGE=y # CONFIG_FEATURE_COMPRESS_USAGE is not set Fixed in later versions. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: hexdump: No help available in busybox v1.4.2

2007-06-05 Thread Tito
On Tuesday 05 June 2007 09:20:48 you wrote: Tito, I just noticed that hexdump --help results in hexdump: invalid option -- - BusyBox v1.4.2 (2007-06-04 14:02:54 CEST) multi-call binary No help available. Other applets do have a usage text! CONFIG_SHOW_USAGE=y

[PATCH] mini port scanner for busybox

2007-06-13 Thread Tito
ssh 25 tcp opensmtp 53 tcp opendomain 80 tcp openwww 443 tcp openhttps 873 tcp openrsync 0 stealth, 1018 closed, 6 open ports Have fun, Ciao Tito --- busybox.orig/networking/Config.in 2007-05-26 23:23:37.0 +0200 +++ busybox

Re: [PATCH] mini port scanner for busybox

2007-06-14 Thread Tito
On Thursday 14 June 2007 14:31:33 Bernhard Fischer wrote: On Wed, Jun 13, 2007 at 11:54:05PM +0200, Tito wrote: Hi, this patch adds a very simple port scanner based on connect() to busybox. I developed it for fun and to improve my skills. Include it if you like it. Critics, hints

Re: [PATCH] mini port scanner for busybox - V2

2007-06-14 Thread Tito
On Thursday 14 June 2007 10:37:54 Denis Vlasenko wrote: Hi Tito, On Wednesday 13 June 2007 23:54, Tito wrote: Hi, this patch adds a very simple port scanner based on connect() to busybox. I developed it for fun and to improve my skills. Include it if you like it. Critics, hints

Re: [PATCH] mini port scanner for busybox - V3

2007-06-14 Thread Tito
On Thursday 14 June 2007 21:00:41 Denis Vlasenko wrote: On Thursday 14 June 2007 16:41, Luciano Rocha wrote: On Thu, Jun 14, 2007 at 04:12:20PM +0200, Tito wrote: +static int my_gettimeofday(void) +{ + struct timeval now; + + if (gettimeofday(now, NULL)) + return 0

Latest change in correct_password.c

2007-06-14 Thread Tito
euro cents. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: Latest change in correct_password.c

2007-06-15 Thread Tito
) */ Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: [PATCH] mini port scanner for busybox - V4

2007-06-15 Thread Tito
On Thursday 14 June 2007 23:27:04 Denis Vlasenko wrote: On Thursday 14 June 2007 16:12, Tito wrote: It's good that you added these comments, but explanation is not clear enough (at least for me). Care to improve? -- vda Here a new version of the patch with improved

Re: [PATCH] mini port scanner for busybox - V5

2007-06-16 Thread Tito
On Friday 15 June 2007 23:16:51 Tito wrote: On Thursday 14 June 2007 23:27:04 Denis Vlasenko wrote: On Thursday 14 June 2007 16:12, Tito wrote: It's good that you added these comments, but explanation is not clear enough (at least for me). Care to improve? -- vda

Re: [PATCH] mini port scanner for busybox - V4

2007-06-16 Thread Tito
On Saturday 16 June 2007 15:39:58 Denis Vlasenko wrote: On Friday 15 June 2007 23:16, Tito wrote: Looks good to me, added some of the TODOs and changed all the time to msec. Please check if i fully understood your code. Sorry no time for a patch right now, sending the file I've changed

Re: [PATCH] mini port scanner for busybox - V6

2007-06-17 Thread Tito
On Saturday 16 June 2007 18:31:00 Denis Vlasenko wrote: On 6/16/07, Tito [EMAIL PROTECTED] wrote: On Saturday 16 June 2007 15:39:58 Denis Vlasenko wrote: On Friday 15 June 2007 23:16, Tito wrote: Looks good to me, added some of the TODOs and changed all the time to msec. Please

Re: task/process managment does not work

2007-06-21 Thread Tito
it is no problem with ps and top. I wonder however why it does not work straight after boot-up and I have to do mount explicitly. Maybe you can add a line to your /etc/fstab proc/proc procdefaults0 0 Ciao, Tito #!../../../bin/ash ?? Write /bin/ash. You don't know what

Re: [rfc] xioctl()

2007-06-23 Thread Tito
On Saturday 23 June 2007 20:10:39 Bernhard Fischer wrote: On Sat, Jun 23, 2007 at 01:31:19PM -0400, Mike Frysinger wrote: On Saturday 23 June 2007, Mike Frysinger wrote: +int xioctl(int fd, int request, unsigned long arg) +{ + int ret = ioctl(fd, request, arg); + if (ret !=

Re: [rfc] xioctl()

2007-06-23 Thread Tito
On Saturday 23 June 2007 22:37:32 you wrote: On Saturday 23 June 2007, Tito wrote: On Saturday 23 June 2007 22:11:53 Tito wrote: On Saturday 23 June 2007 20:10:39 Bernhard Fischer wrote: On Sat, Jun 23, 2007 at 01:31:19PM -0400, Mike Frysinger wrote: On Saturday 23 June 2007, Mike

Re: [rfc] xioctl()

2007-06-24 Thread Tito
On Sunday 24 June 2007 16:25:20 walter harms wrote: Tito wrote: On Sunday 24 June 2007 14:59:42 walter harms wrote: perhaps this can be fixed using a macro like: #define xioctl(fd,req,...) bb_ioctl(#req,fd,req,__VA_ARGS__) static int bb_ioctl(const char *estr, int fd, int

[PATCH] devfsd code style patch

2007-06-25 Thread Tito
Hi, i was trying to reduce the size of devfsd and clean up the code, but before doing this I would like this code style patch to be applied. There are no code changes only style and formatting changes. Ciao, Tito BTW: If there is somebody still using devfsd and willing to test my

Re: [PATCH] size reduction and code clean up for devfsd.c

2007-06-27 Thread Tito
--enable-threads=posix --enable-nls --program-suffix=-4.1 --enable-__cxa_atexit --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-checking=release i486-linux-gnu Thread model: posix gcc version 4.1.2 (Ubuntu 4.1.2-0ubuntu4) Ciao, Tito

[PATCH] more devfsd clean up and size reduction

2007-06-30 Thread Tito
before and i'm not quite sure if i've done things right. and apply the patch if you like it. Ciao, Tito --- miscutils/devfsd.c.orig 2007-06-30 13:49:56.0 +0200 +++ miscutils/devfsd.c 2007-06-30 14:02:17.0 +0200 @@ -234,11 +234,8 @@ static char *write_old_sd_name(char

[PATCH RFC] avoid libbb/correct_password.c to disclose info about system

2007-07-02 Thread Tito
information about the state of the system. I think it should instead fake an incorrect login. A patch is attached, comments and critics are welcome. This is only compile tested. Ciao, Tito BTW.: scripts/bloat-o-meter busybox_old busybox_unstripped function

Re: problem to build busybox in cygwin

2007-07-03 Thread Tito
]: *** [scripts/kconfig/mconf] Error 1 make: *** [menuconfig] Error 2 so how I can solve this problem please Maybe by installing the gettext library (runtime and dev files)? Ciao, Tito Best Regards Hamid Khateb

Re: whither 1.00's passwd -p ... ?

2007-07-03 Thread Tito
that a user will be warned that his/her password is about to expire. -x, --maxdays MAX_DAYS Set the maximum number of days a password remains valid. After MAX_DAYS, the password is required to be changed. Ciao, Tito

[PATCH 1/7] bb_ioctl implementation

2007-07-10 Thread Tito
of changes so that it needs more love and testing than the others. This patches are mostly only compiled tested. Critics, hints and help from the list is as always welcome. Ciao, Tito --- busybox.orig/include/libbb.h 2007-07-05 08:20:25.0 +0200 +++ busybox/include/libbb.h 2007-07-09 21:27

[PATCH 2/7] bb_ioctl implementation

2007-07-10 Thread Tito
This is the bb_ioctl patch for console-tools. Ciao, Tito --- busybox.orig/console-tools/chvt.c 2007-05-26 23:23:40.0 +0200 +++ busybox/console-tools/chvt.c 2007-07-09 21:39:51.0 +0200 @@ -26,9 +26,7 @@ fd = get_console_fd(); num = xatoul_range(argv[1], 1, 63); - if ((-1

[PATCH 3/7] bb_ioctl implementation

2007-07-10 Thread Tito
This is the bb_ioctl patch for loginutils. Ciao, Tito --- busybox.orig/loginutils/getty.c 2007-05-26 23:23:54.0 +0200 +++ busybox/loginutils/getty.c 2007-07-09 21:54:43.0 +0200 @@ -281,8 +281,7 @@ * 5 seconds seems to be a good value. */ - if (ioctl(0, TCGETS, tp) 0

[PATCH 4/7] bb_ioctl implementation

2007-07-10 Thread Tito
This is the bb_ioctl patch for miscutils. Ciao, Tito --- busybox.orig/miscutils/devfsd.c 2007-07-02 16:39:41.0 +0200 +++ busybox/miscutils/devfsd.c 2007-07-05 23:19:33.0 +0200 @@ -234,7 +234,6 @@ static char *write_old_sd_name(char *, unsigned, unsigned, const char

[PATCH 5/7] bb_ioctl implementation

2007-07-10 Thread Tito
This is the bb_ioctl patch for miscutils/hdparm. Ciao, Tito --- busybox.orig/miscutils/hdparm.c 2007-05-30 14:41:29.0 +0200 +++ busybox/miscutils/hdparm.c 2007-07-08 10:52:20.0 +0200 @@ -200,8 +200,8 @@ #define MULTIPLE_SETTING_VALID 0x0100 /* 1=multiple sector setting is valid

[PATCH 7/7] bb_ioctl implementation

2007-07-10 Thread Tito
This is the bb_ioctl patch for util-linux. Ciao, Tito --- busybox.orig/util-linux/fbset.c 2007-05-26 23:23:58.0 +0200 +++ busybox/util-linux/fbset.c 2007-07-06 23:24:36.0 +0200 @@ -385,8 +385,7 @@ } fh = xopen(fbdev, O_RDONLY); - if (ioctl(fh, FBIOGET_VSCREENINFO, var

Re: [PATCH 1/7] bb_ioctl implementation - improved

2007-07-11 Thread Tito
On Wednesday 11 July 2007 13:48:52 Alex Landau wrote: Tito [EMAIL PROTECTED] wrote: Hi, this series of 7 patches is a first attempt to add an ioctl api to libbb and to use it in all applets where: if ( ioctl() 0 [!= 0]) bb_perror_msg{and_die}(); or similar code is used. [snip

Re: [PATCH] vi read-only mode bugfix and enhancement

2007-07-18 Thread Tito
an idea Ciao, Tito BTW, any idea why strNcmp? Can it really be viewsomething? I'm no expert on vi... -- vda ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: [PATCH] add chpasswd applet

2007-07-19 Thread Tito
-run chpasswd.patch patching file include/applets.h patch: malformed patch at line 20:  USE_CHGRP(APPLET_NOEXEC(chgrp, chgrp, _BB_DIR_BIN, _BB_SUID_NEVER, chgrp)) Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin

Re: [PATCH] add chpasswd applet

2007-07-19 Thread Tito
On Thursday 19 July 2007 15:49:44 Alexander Shishkin wrote: On 7/19/07, Tito [EMAIL PROTECTED] wrote: Hi, would you mind to send the patch as attachment and in diff -uN format. I'm experiencing some difficulties to apply and test it. Oh, sorry about this. I always get a bit too carried

Re: Fwd: [PATCH] add chpasswd applet -- use passwd instead

2007-07-19 Thread Tito
On Thursday 19 July 2007 22:37:43 Alexander Shishkin wrote: On 7/19/07, Tito [EMAIL PROTECTED] wrote: Hi, Hi, attached you will find a drop in replacement for chpasswd.c with some more busyboxification (use of getopt32 and syslogging capabilities of bb_*_msg_* functions) and some

Re: Fwd: [PATCH] add chpasswd applet

2007-07-20 Thread Tito
On Friday 20 July 2007 23:22:56 Denis Vlasenko wrote: On Thursday 19 July 2007 21:37, Alexander Shishkin wrote: On 7/19/07, Tito [EMAIL PROTECTED] wrote: Hi, Hi, attached you will find a drop in replacement for chpasswd.c with some more busyboxification (use of getopt32

Re: Fwd: [PATCH] chpasswd applet size reduction and bugfix

2007-07-20 Thread Tito
On Saturday 21 July 2007 00:12:47 Tito wrote: On Friday 20 July 2007 23:22:56 Denis Vlasenko wrote: On Thursday 19 July 2007 21:37, Alexander Shishkin wrote: On 7/19/07, Tito [EMAIL PROTECTED] wrote: Hi, Hi, attached you will find a drop in replacement for chpasswd.c

Re: How do I add a user to multiple groups?

2007-07-28 Thread Tito
sys addgroup root tty Ciao, Tito Thanks, Dallas ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

[PATCH] fix addgroup command line parsing

2007-07-29 Thread Tito
(); + /* check if group and user exist */ xuname2uid(argv[0]); /* unknown user: exit */ xgroup2gid(argv[1]); /* unknown group: exit */ Only little tested. Please apply if you like it. Ciao, Tito ___ busybox

Re: [PATCH] applet-request: expand

2007-08-06 Thread Tito
, Tito --- busybox.orig/include/applets.h 2007-08-03 14:17:54.0 +0200 +++ busybox/include/applets.h 2007-08-05 20:57:48.0 +0200 @@ -134,6 +134,7 @@ USE_ENVDIR(APPLET_ODDNAME(envdir, chpst, _BB_DIR_USR_BIN, _BB_SUID_NEVER, envdir)) USE_ENVUIDGID(APPLET_ODDNAME(envuidgid, chpst

Re: [PATCH] applet-request: expand

2007-08-07 Thread Tito
(as long as we don't try to do the expand -t list files stuff) but before attempting it I would like the current code to be better tested, debugged and optimized, as it is mostly untested. Ciao, Tito ___ busybox mailing list busybox@busybox.net http

Re: [PATCH] applet-request: expand

2007-08-09 Thread Tito
On Monday 06 August 2007 23:00:56 Tito wrote: Hi, this is a first attempt to implement a stripped down version of expand. This version is only little tested so it may contain all sort of bugs. Hints, critics and help in testing and improving it is welcome. bloat-o-meter (after make

[PATCH] new expand / unexpand applets

2007-08-12 Thread Tito
/down: 1152/0) Total: 1152 bytes Ciao, Tito --- busybox.latest/include/applets.h 2007-08-07 21:19:36.0 +0200 +++ busybox/include/applets.h 2007-08-12 23:10:17.0 +0200 @@ -134,6 +134,7 @@ USE_ENVDIR(APPLET_ODDNAME(envdir, chpst, _BB_DIR_USR_BIN, _BB_SUID_NEVER, envdir

Re: udhcpd get DNS address dynamic

2007-08-17 Thread Tito
On Friday 17 August 2007 17:13:43 Tito wrote: On Friday 17 August 2007 02:08:24 kylix wrote: Hi,all I want to build a DHCP server on my embedded linux system. My busybox version is v1.3. when udhcpd running, it will get the configure infomation from udhcpd.conf

Re: [RFC] tail.c size reduction

2007-09-03 Thread Tito
On Monday 03 September 2007 21:13:16 Denys Vlasenko wrote: On Sunday 02 September 2007 20:20, Tito wrote: Hi to all, this is a drop in replacement for tail.c. It is a result of a few sleepless nights of hacking that started by looking at and trying to understand mjn3's code

Re: Busybox and user/group problem

2007-09-19 Thread Tito
) by vda File length: 2952 byte(s) Diff to previous 17095 (colored) chown: fix handling of user.group notation It seem that the glue between the system and user and group config file doesn't work ! All ideas are welcome Ciao, Tito

Busybox in the news

2007-09-20 Thread Tito
://www.softwarefreedom.org/news/2007/sep/20/busybox/complaint.pdf Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: pgrep/pkill

2007-09-28 Thread Tito
) { /* sets the pointer to NULL after it has been freed.*/ void **pp = (void **)ptr; if (*pp == NULL) return; free(*pp); *pp = NULL; } just my 0,2 cent. ;-) Ciao, Tito ___ busybox mailing list busybox

Re: pgrep/pkill

2007-09-29 Thread Tito
On Friday 28 September 2007 21:14:45 Ralf Friedl wrote: Tito wrote: Maybe this version could be more useful. void xfree(void *ptr) { /* sets the pointer to NULL after it has been freed.*/ void **pp = (void **)ptr; if (*pp == NULL) return

Re: Patch for adduser: Create a system user

2007-10-24 Thread Tito
check, could not be less than min */ if (p-pw_uid max) return 2; return 0; } This is only a proof of concept and is only compile tested. If it works for you, your patch could be easily integrated. Ciao, Tito ___ busybox

Re: Patch for adduser: Create a system user

2007-10-24 Thread Tito
On Wednesday 24 October 2007 22:41:48 Ralf Friedl wrote: Tito wrote: maybe this could fix the problem you report: ... /* create new gid always = uid and re-check if the uid is free */ while (getgrgid(p-pw_uid) getpwuid(p-pw_uid)) p-pw_uid

[PATCH] adduser can create duplicate users

2007-10-27 Thread Tito
) return 2; return 0; } Ciao, Tito --- loginutils/adduser.c.orig 2007-10-27 08:57:23.0 +0200 +++ loginutils/adduser.c 2007-10-27 15:54:25.0 +0200 @@ -20,11 +20,6 @@ { enum { min = 500, max = 65000 }; FILE *passwd; - /* We are using reentrant fgetpwent_r

[PATCH] who.c minor size reduction

2007-11-11 Thread Tito
runlevel ~? Nov 11 10:06:20 LOGIN tty1 03:17 Nov 11 10:06:47 tito tty2 00:01 Nov 11 13:22:31 LOGIN tty3 03:17 Nov 11 10:06:47 LOGIN tty4 03:17 Nov 11 10:06:47 LOGIN tty5 03:17 Nov 11 10:06:47 LOGIN tty6 03:17

Re: [PATCH] who.c minor size reduction

2007-11-13 Thread Tito
On Tuesday 13 November 2007 18:22:34 Denys Vlasenko wrote: On Sunday 11 November 2007 05:29, Tito wrote: Hi, this size reduces size of who.c by removing a variable. The patch is tested and works for me. Bloat o meter says: scripts/bloat-o-meter busybox_old busybox_unstripped

Re: DNS problem

2007-11-15 Thread Tito
/lib/libnss_nisplus.so.2 /lib/libnss_files.so.2 /lib/libnss_nis.so.2 /lib/libresolv-2.6.1.so /lib/libresolv.so.2 - libresolv-2.6.1.so Just an idea Ciao, Tito Best Regards Mirek ___ busybox mailing list busybox@busybox.net http

Re: tar segfaults (busybox 1.8.1)

2007-11-16 Thread Tito
[EMAIL PROTECTED]:~/Desktop/busybox# ls -la test.tar -rw-r--r-- 1 root root 2560 2007-11-16 14:15 test.tar I cannot say if this fix is correct or if maybe it should be done the other way by increasing the size of char magic to 8. Just my 0,02 EUR cents :-) Ciao, Tito

Re: tar segfaults (busybox 1.8.1)

2007-11-16 Thread Tito
On Friday 16 November 2007 19:48:08 Denys Vlasenko wrote: On Friday 16 November 2007 05:19, Tito wrote: On Friday 16 November 2007 13:34:25 Alexander Griesser wrote: [EMAIL PROTECTED]:~/busybox/busybox-1.8.1$ ./busybox tar cf test.tar a s d *** buffer overflow detected ***: ./busybox

Re: tar segfaults (busybox 1.8.1)

2007-11-16 Thread Tito
On Friday 16 November 2007 19:48:08 you wrote: u s t a r sp sp nul BTW: shouldn't it be: char magic[5]/* as there is no null termination of the string */ char version[3] /* as the string is null terminated */ Just an idea. Ciao, Tito

Re: tar segfaults (busybox 1.8.1)

2007-11-16 Thread Tito
On Friday 16 November 2007 21:34:25 Denys Vlasenko wrote: On Friday 16 November 2007 12:24, Alexander Griesser wrote: Tito schrieb: by compiling the latest svn i get this warning: CC archival/tar.o archival/tar.c: In function ‘writeFileToTarball’: archival/tar.c:183: warning

Re: renice +N broken?

2007-12-10 Thread Tito
the '+' and then feeding it to xatoi_ could help... Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: slow USB HD

2007-12-16 Thread Tito
?...) The lsusb command could give you more info about the usb device. All in all I suspect that this has not much to do with busybox tough Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: [PATCH] coreutils tac (was: coreutils tac)

2007-12-28 Thread Tito
On Saturday 29 December 2007 03:18:13 Denys Vlasenko wrote: On Friday 28 December 2007 21:36, Tito wrote: just for fun I've created an alternative version of tac using only linked lists in memory. Probably the size is smaller but I haven't checked it yet as I would like to hear first

Re: [PATCH] coreutils tac (was: coreutils tac)

2008-01-06 Thread Tito
(temp_list, line);  } this was the test file i used (attached): 055 056 057 000 057 056 055 010 result is: GNU tac tac prova4 789987 busybox ./busybox tac prova4 789987 Ciao, TIto -- vda 789987 /* vi: set sw=4 ts=4: */ /* * tac implementation for busybox * * Copyright

Re: syslogd

2008-01-06 Thread Tito
not... But shmget() succeeded and that's strange. Anyway, any help will be greatly appreciated. Thanks, Alex Alex, you attached a man page rather than the patch. :-) Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman

Re: New version of tac.c

2008-01-09 Thread Tito
On Wednesday 09 January 2008 11:11:04 Natanael Copa wrote: On Tue, 2008-01-08 at 22:42 +0100, Tito wrote: Hi, this new version of tac.c handles embedded nulls in a correct way. I tested it in comparison with the real tac on most of the files of my hard disk with the attached script

Re: New version of tac.c

2008-01-10 Thread Tito
. :-) Just an idea. Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: ps and username size

2008-01-10 Thread Tito
) ... groupadd: q is not a valid group name adduser: `/usr/sbin/groupadd -g 1006 q' returned error code 3. Exiting. Just an idea. Ciao, Tito ___ busybox mailing list busybox@busybox.net http

Re: ps and username size

2008-01-10 Thread Tito
On Thursday 10 January 2008 23:22:52 Cristian Ionescu-Idbohrn wrote: On Thu, 10 Jan 2008, Tito wrote: OTOH it doesn't solve the problem of a possible ambiguity between username and uid as names composed only of digits are legal. What I meant was: either (default) truncated usernames

Re: busybox-1.9.0 / fdisk -l segfaults

2008-01-22 Thread Tito
sectors/track, 30401 cylinders Units = cylinders of 16065 * 512 = 8225280 bytes Ciao, Tito On Tuesday 22 January 2008 18:04:38 walter harms wrote: i did a quick check on my desktop (glibc). and it works as expected does only fdisk -l segfault or also fdisk -l /dev/xxx ? re, wh

Re: New applet: sendmail

2008-02-02 Thread Tito
if there are similar options that take arguments. IMHO the best solution is to use two independent getopt32 calls. Ciao, Tito You see, if we launch, say, sendmail then the first call to getopt32 would fail [showing bb_usage()] on any fetchmail_specific_options and even on sendmail_specific_options

Re: New applet: sendmail

2008-02-02 Thread Tito
if it is worth the effort tough. :-) Ciao, Tito So let it be 2 calls. Thanx for discussion. -- Vladimir 2008/2/2, Tito [EMAIL PROTECTED]: On Saturday 02 February 2008 21:06:52 Vladimir Dronnikov wrote: Hi, maybe check the applet_name at startup and then if (applet_name[0

Re: rewrite: watch.c

2008-02-22 Thread Tito
for malloc errors and is portable on systems that don't have asprintf...   asprintf(cmd,%s,*argv );         while (*++argv)             asprintf(cmd,%s %s,cmd,*argv ); while (1) { Just my 2 cents. ;-) Ciao, Tito BTW, coding style in some places is bad: strftime(header + width

Re: busybox 1.9.1 syslogd segfaults on startup

2008-02-23 Thread Tito
); /* It is unspecified whether the truncated hostname * will be null-terminated. Idiots! */ G.localHostName[64 -1] = '\0'; *strchrnul(G.localHostName, '.') = '\0'; This used to work in devfsd.c. Maybe there is a need for a bb_gethostname() Ciao, Tito

Re: rewrite: watch.c

2008-02-23 Thread Tito
On Saturday 23 February 2008 13:33:44 walter harms wrote: Tito wrote: On Friday 22 February 2008 19:13:51 walter harms wrote: hi list, this simplifies the coding of the watch utility. I does not save much bytes but it thing it is easier to read now. I have changed the date time

Re: xgethostname()

2008-02-23 Thread Tito
On Saturday 23 February 2008 18:16:27 walter harms wrote: Tito wrote: On Saturday 23 February 2008 02:50:11 Clem Taylor wrote: I'm trying to switch from an old busybox 1.5.0.svn (2007-11-19) to busybox 1.9.1 and syslogd segfaults on startup: #0 0x2ab609cc in strcpy () from /lib/libc.so

Re: xgethostname()

2008-02-24 Thread Tito
On Sunday 24 February 2008 14:25:04 walter harms wrote: Tito wrote: On Saturday 23 February 2008 18:16:27 walter harms wrote: Tito wrote: On Saturday 23 February 2008 02:50:11 Clem Taylor wrote: snip hi Tito, are you sure about HOST_NAME_MAX ? according to my includes sizeof

Re: rewrite: watch.c (last turn i hope)

2008-02-24 Thread Tito
On Sunday 24 February 2008 15:23:01 walter harms wrote: As tito pointed out the xasprintf() alloced everytime so it needs a free() or you system will leak memory with every step. i realy hope this is the last version. re, wh Hi, why don't you move both the xasprintf and the free

Re: xgethostname()

2008-02-24 Thread Tito
but preventing chrashes like the one above Wait a second. I do not understand how it crashes in the first place. I suspect that gethostname somehow fails and strchrnul chokes on G.localHostName starting with nul but this is just an idea. Ciao, Tito char *xgethostname() { char *buf=NULL

Re: xgethostname()

2008-02-24 Thread Tito
On Sunday 24 February 2008 20:08:00 Denys Vlasenko wrote: On Sunday 24 February 2008 15:03, Tito wrote: are you sure about HOST_NAME_MAX ? according to my includes sizeof(uname.nodename) = _UTSNAME_NODENAME_LENGTH = _UTSNAME_LENGTH = 65 and MAXHOSTNAMELEN= 64 while

Re: [PATCH] safe_gethostname

2008-02-25 Thread Tito
On Monday 25 February 2008 16:48:57 Denys Vlasenko wrote: On Monday 25 February 2008 00:46, Tito wrote: Hi, this is a preliminary patch that adds the new libbb function safe_gethostname and converts all occurrences of gethostname to it. +char *safe_gethostname(void

Re: [PATCH] safe_gethostname

2008-02-25 Thread Tito
On Monday 25 February 2008 21:40:10 Denys Vlasenko wrote: On Monday 25 February 2008 21:02, Tito wrote: Why 256? Leftover of my first attempt with a static buffershould be 255 in this case. I mean, why not sizeof()? I think sizeof never lies. If fields are indeed

Re: LPR fixup

2008-02-26 Thread Tito
like this? /* Force the output to be unbuffered.*/ setbuf(stdout, (char *) 0); Ciao, Tito Plz, do apply. -- Vladimir ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: Encryption

2008-03-01 Thread Tito
to be secured. if someone is sniffing traffic and the traffic is encrypted, then the attacker merely needs to go to the public FTP and fetch the files themselves. -mike Hi, maybe the problem is to post a file on a public ftp server in a way that its contents are not public..? Ciao, Tito

[PATCH RESEND] check user and group names for illegal chars in adduser and addgroup

2008-03-19 Thread Tito
Hi, Denis maybe this patch slipped through, so i'm resending it to know your opinion about it. Ciao, TIto Hi, this patch adds the new function xcheck_name() void xcheck_name(const char *name) { int i = 0; do { if (!isalnum(*name) !(*name

Re: [PATCH] Fix ioctl() wrappers for 64-bit systems

2008-04-11 Thread Tito
request, ...); Couldn't this changes be made platform dependent with some voodoo magic at compile time? Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: [PATCH] udhcpc: give up on repeated errors

2008-05-20 Thread Tito
, ;-) Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

[RFC] strrstr function in libbb failes on some corner cases

2008-06-15 Thread Tito
-- (add/remove: 0/0 grow/shrink: 1/0 up/down: 20/0) Total: 20 bytes The strrstr function at the moment is used only in depmod so the depmod author should check if this new implementation is suitable to be used. Hints, critics and improvements are ,as always, welcome. Ciao, Tito

Re: [RFC] strrstr function in libbb failes on some corner cases

2008-06-15 Thread Tito
On Sunday 15 June 2008 23:21:43 Bernhard Fischer wrote: On Sun, Jun 15, 2008 at 11:06:17PM +0200, Tito wrote: Hi, while inspecting the last changes in busybox code I hit some issues in libbb/strrstr.c. The strrtstr function fails on some corner cases of a little test program I wrote

Re: [RFC] strrstr function in libbb failes on some corner cases

2008-06-16 Thread Tito
On Monday 16 June 2008 06:33:35 you wrote: On Sunday 15 June 2008 23:06, Tito wrote: Hi, while inspecting the last changes in busybox code I hit some issues in libbb/strrstr.c. The strrtstr function fails on some corner cases of a little test program I wrote (and bombs out on NULL

Re: [RFC] strrstr function in libbb failes on some corner cases

2008-06-16 Thread Tito
On Monday 16 June 2008 09:47:31 Bernhard Fischer wrote: On Mon, Jun 16, 2008 at 08:45:18AM +0200, Tito wrote: On Monday 16 June 2008 06:33:35 you wrote: There was one more reason to avoid strlen, but it was just my personal stupid paranoia: as we don't know the lenght of the strings

Re: [RFC] strrstr function in libbb failes on some corner cases

2008-06-17 Thread Tito
On Tuesday 17 June 2008 09:43:54 Bernhard Fischer wrote: On Mon, Jun 16, 2008 at 09:48:07PM +0200, Tito wrote: On Monday 16 June 2008 09:47:31 Bernhard Fischer wrote: On Mon, Jun 16, 2008 at 08:45:18AM +0200, Tito wrote: On Monday 16 June 2008 06:33:35 you wrote: char* strrstr(const

[PATCH] fix last corner case in strrstr.c

2008-06-17 Thread Tito
is that it is probably a little more cpu intensive :) Please apply if you like it. Ciao, Tito --- libbb/strrstr_orig.c 2008-06-17 16:11:06.0 +0200 +++ libbb/strrstr.c 2008-06-17 21:33:51.0 +0200 @@ -13,19 +13,16 @@ * The strrstr() function finds the last occurrence

Re: busybox ping not able to reach public IP

2008-07-02 Thread Tito
Ciao, Tito ___ busybox mailing list busybox@busybox.net http://busybox.net/cgi-bin/mailman/listinfo/busybox

Re: Ответ: LIBBB: parse_config()

2008-07-08 Thread Tito
: ./test config.cfg option=1 option=2 option=corner-case1 option=corner-case3 option=corner-case2 option=after_new_lines option 3 option 33 3 3 option abracadabra option=multiline-option Just my 0,2 centsin the hope it could be somehow useful :-) Ciao, Tito /* Lines starting

Re: Ответ: Ответ: LIBBB: parse_config()

2008-07-09 Thread Tito
-month, new_head-day_of_week, new_head-cmd); new_head-link = *old_head; *old_head = new_head; } free(option_list); } This obviously is only pseudo code not tested nor compile tested, just an idea. Comments, hints, critics are welcome Ciao, Tito

Re: Ответ: Ответ: LIBBB: parse_config()

2008-07-09 Thread Tito
On Wednesday 09 July 2008 18:01:17 Tito wrote: On Wednesday 09 July 2008 14:35:50 Rob Landley wrote: On Tuesday 08 July 2008 16:40:14 Vladimir Dronnikov wrote: Cool! But we need to not just process continuations and comments but also to parse the line into some (possibly variable

  1   2   3   4   5   6   7   >