Re: [PATCH] ash/hush: implement -d DELIM option for `read`

[Johannes Schindelin]

Hi,

On Tue, 8 Aug 2017, Kang-Che Sung wrote:

> On Mon, Aug 7, 2017 at 6:18 PM, Johannes Schindelin
>  wrote:
> > The POSIX standard only requires the `read` builtin to handle `-r`:
> > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/read.html
> >
> > However, Bash introduced the option `-d ` to override IFS for
> > just one invocation, and it is quite useful.
> >
> > It is also super easy to implement in BusyBox' ash, so let's do that.
> >
> > The motivation: This option is used by Git's test suite.
> >
> > Signed-off-by: Johannes Schindelin 
> 
> Can you wrap the change within a macro conditional like #if BASH_READ_D ?

I can! And I did! It made the patch a little less readable, though.

Ciao,
Johannes
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH] ash/hush: implement -d DELIM option for `read`

[Kang-Che Sung]

On Mon, Aug 7, 2017 at 6:18 PM, Johannes Schindelin
 wrote:
> The POSIX standard only requires the `read` builtin to handle `-r`:
> http://pubs.opengroup.org/onlinepubs/9699919799/utilities/read.html
>
> However, Bash introduced the option `-d ` to override IFS for
> just one invocation, and it is quite useful.
>
> It is also super easy to implement in BusyBox' ash, so let's do that.
>
> The motivation: This option is used by Git's test suite.
>
> Signed-off-by: Johannes Schindelin 

Can you wrap the change within a macro conditional like #if BASH_READ_D ?
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox