Re: ifup dependency

[David Henderson]

On 9/26/16, Denys Vlasenko  wrote:
> On Mon, Sep 26, 2016 at 8:56 AM, Peter Korsgaard 
> wrote:
>>> "Bernhard" == Bernhard Reutner-Fischer 
>>> writes:
>>
>>  > On 17 September 2016 08:07:01 CEST, Peter Korsgaard
>>  wrote:
>>  >>> "David" == David Henderson  writes:
>>  >>
>>  >> > Hey Peter, thanks for the reply.  I was more or less referring to
>>  >> > should the 'menuconfig' portion of BB automatically add that in as
>> a
>>  >> > dependency if ifup/down has been selected, and not should I add
>> this
>>  >> > applet into my BB compile.  I was just letting the community know
>>  >> > about the "problem".
>>  >>
>>  >> Yes indeed, I think CONFIG_IFUPDOWN should select CONFIG_RUN_PARTS.
>>
>>  > No it should not. It's perfectly fine to use another run-parts. The
>>  > help-text should mention that any run-parts has to be installed
>>  > though.
>>
>> True.
>
> It's already in the help since about 2003:
>
> config IFUPDOWN
> bool "ifupdown"
> default y
> help
>   Activate or deactivate the specified interfaces. This applet
> makes
>   use of either "ifconfig" and "route" or the "ip" command to
> actually
>   configure network interfaces. Therefore, you will probably also
> want
>   to enable either IFCONFIG and ROUTE, or enable
>   FEATURE_IFUPDOWN_IP and the various IP options.
>   Of course you could use non-busybox versions of these programs,
> so
>   against my better judgement (since this will surely result in
> plenty
>   of support questions on the mailing list), I do not force you to
>   enable these additional options. It is up to you to supply either
>   "ifconfig", "route" and "run-parts" or the "ip" command, either
>   via busybox or via standalone utilities.
>
>
>
> It's possible to add that sometimes udhcpc, bootpc, pon, poff,
> start-stop-daemon, wvdial, and run-parts can be used,
> but the list gets somewhat unwieldy.

This re-affirms my suggestion about some type of a popup.  People
typically look at the help for info on what a particular applet may
do, not what its requirements are.  It would be better to have a popup
to alert the user that "Hey you either need to enable the BB
supplemental binaries required for this to work, or supply your own -
see the help for details."  Again, I didn't look at the help because I
knew what the commands did.

Dave
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: ifup dependency

[Peter Korsgaard]

> "Denys" == Denys Vlasenko  writes:

Hi,

 >> > No it should not. It's perfectly fine to use another run-parts. The
 >> > help-text should mention that any run-parts has to be installed
 >> > though.
 >> 
 >> True.

 > It's already in the help since about 2003:

 > config IFUPDOWN
 > bool "ifupdown"
 > default y
 > help
 >   Activate or deactivate the specified interfaces. This applet makes
 >   use of either "ifconfig" and "route" or the "ip" command to 
 > actually
 >   configure network interfaces. Therefore, you will probably also 
 > want
 >   to enable either IFCONFIG and ROUTE, or enable
 >   FEATURE_IFUPDOWN_IP and the various IP options.
 >   Of course you could use non-busybox versions of these programs, so
 >   against my better judgement (since this will surely result in 
 > plenty
 >   of support questions on the mailing list), I do not force you to
 >   enable these additional options. It is up to you to supply either
 >   "ifconfig", "route" and "run-parts" or the "ip" command, either
 >   via busybox or via standalone utilities.


heh, indeed.

 > It's possible to add that sometimes udhcpc, bootpc, pon, poff,
 > start-stop-daemon, wvdial, and run-parts can be used,
 > but the list gets somewhat unwieldy.

yes, keeping it like this is imho ok.

-- 
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: ifup dependency

[Denys Vlasenko]

On Mon, Sep 26, 2016 at 8:56 AM, Peter Korsgaard  wrote:
>> "Bernhard" == Bernhard Reutner-Fischer  writes:
>
>  > On 17 September 2016 08:07:01 CEST, Peter Korsgaard  
> wrote:
>  >>> "David" == David Henderson  writes:
>  >>
>  >> > Hey Peter, thanks for the reply.  I was more or less referring to
>  >> > should the 'menuconfig' portion of BB automatically add that in as a
>  >> > dependency if ifup/down has been selected, and not should I add this
>  >> > applet into my BB compile.  I was just letting the community know
>  >> > about the "problem".
>  >>
>  >> Yes indeed, I think CONFIG_IFUPDOWN should select CONFIG_RUN_PARTS.
>
>  > No it should not. It's perfectly fine to use another run-parts. The
>  > help-text should mention that any run-parts has to be installed
>  > though.
>
> True.

It's already in the help since about 2003:

config IFUPDOWN
bool "ifupdown"
default y
help
  Activate or deactivate the specified interfaces. This applet makes
  use of either "ifconfig" and "route" or the "ip" command to actually
  configure network interfaces. Therefore, you will probably also want
  to enable either IFCONFIG and ROUTE, or enable
  FEATURE_IFUPDOWN_IP and the various IP options.
  Of course you could use non-busybox versions of these programs, so
  against my better judgement (since this will surely result in plenty
  of support questions on the mailing list), I do not force you to
  enable these additional options. It is up to you to supply either
  "ifconfig", "route" and "run-parts" or the "ip" command, either
  via busybox or via standalone utilities.



It's possible to add that sometimes udhcpc, bootpc, pon, poff,
start-stop-daemon, wvdial, and run-parts can be used,
but the list gets somewhat unwieldy.
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: ifup dependency

[David Henderson]

Good morning all!  Thanks for the replies guys.  And that is a good
point Bernhard.  Something in the help would probably be a good idea.
Also, what about a popup alert (if possible) since some may not read
the help if they are just adding those applets as I did.  There was no
reason for me to look at the help since I knew what the commands did.
Thoughts?

Thanks,
Dave


On 9/26/16, Peter Korsgaard  wrote:
>> "Bernhard" == Bernhard Reutner-Fischer 
>> writes:
>
>  > On 17 September 2016 08:07:01 CEST, Peter Korsgaard 
> wrote:
>  >>> "David" == David Henderson  writes:
>  >>
>  >> > Hey Peter, thanks for the reply.  I was more or less referring to
>  >> > should the 'menuconfig' portion of BB automatically add that in as a
>  >> > dependency if ifup/down has been selected, and not should I add this
>  >> > applet into my BB compile.  I was just letting the community know
>  >> > about the "problem".
>  >>
>  >> Yes indeed, I think CONFIG_IFUPDOWN should select CONFIG_RUN_PARTS.
>
>  > No it should not. It's perfectly fine to use another run-parts. The
>  > help-text should mention that any run-parts has to be installed
>  > though.
>
> True.
>
> --
> Bye, Peter Korsgaard
>
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: ifup dependency

[Peter Korsgaard]

> "Bernhard" == Bernhard Reutner-Fischer  writes:

 > On 17 September 2016 08:07:01 CEST, Peter Korsgaard  
 > wrote:
 >>> "David" == David Henderson  writes:
 >> 
 >> > Hey Peter, thanks for the reply.  I was more or less referring to
 >> > should the 'menuconfig' portion of BB automatically add that in as a
 >> > dependency if ifup/down has been selected, and not should I add this
 >> > applet into my BB compile.  I was just letting the community know
 >> > about the "problem".
 >> 
 >> Yes indeed, I think CONFIG_IFUPDOWN should select CONFIG_RUN_PARTS.

 > No it should not. It's perfectly fine to use another run-parts. The
 > help-text should mention that any run-parts has to be installed
 > though.

True.

-- 
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: ifup dependency

[Bernhard Reutner-Fischer]

On 17 September 2016 08:07:01 CEST, Peter Korsgaard  wrote:
>> "David" == David Henderson  writes:
>
> > Hey Peter, thanks for the reply.  I was more or less referring to
> > should the 'menuconfig' portion of BB automatically add that in as a
> > dependency if ifup/down has been selected, and not should I add this
> > applet into my BB compile.  I was just letting the community know
> > about the "problem".
>
>Yes indeed, I think CONFIG_IFUPDOWN should select CONFIG_RUN_PARTS.

No it should not. It's perfectly fine to use another run-parts. The help-text 
should mention that any run-parts has to be installed though.

thanks,


___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: ifup dependency

[Peter Korsgaard]

> "David" == David Henderson  writes:

 > Hey Peter, thanks for the reply.  I was more or less referring to
 > should the 'menuconfig' portion of BB automatically add that in as a
 > dependency if ifup/down has been selected, and not should I add this
 > applet into my BB compile.  I was just letting the community know
 > about the "problem".

Yes indeed, I think CONFIG_IFUPDOWN should select CONFIG_RUN_PARTS.

-- 
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: ifup dependency

[David Henderson]

Hey Peter, thanks for the reply.  I was more or less referring to
should the 'menuconfig' portion of BB automatically add that in as a
dependency if ifup/down has been selected, and not should I add this
applet into my BB compile.  I was just letting the community know
about the "problem".

Dave


On 9/16/16, Peter Korsgaard  wrote:
>> "David" == David Henderson  writes:
>
>  > Good afternoon all, I had re-compiled my busybox to add in the some
>  > commands including the ifup/down.  When I attempted to run that
>  > applet, it said that 'run-parts' was not installed.  Should this
>  > applet the automatically added to the config when the ifup/down
>  > commands were added?
>
> As the errors executing run-parts aren't ignored, I would say yes.
>
> --
> Bye, Peter Korsgaard
>
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

Re: ifup dependency

[Peter Korsgaard]

> "David" == David Henderson  writes:

 > Good afternoon all, I had re-compiled my busybox to add in the some
 > commands including the ifup/down.  When I attempted to run that
 > applet, it said that 'run-parts' was not installed.  Should this
 > applet the automatically added to the config when the ifup/down
 > commands were added?

As the errors executing run-parts aren't ignored, I would say yes.

-- 
Bye, Peter Korsgaard
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

ifup dependency

[David Henderson]

Good afternoon all, I had re-compiled my busybox to add in the some
commands including the ifup/down.  When I attempted to run that
applet, it said that 'run-parts' was not installed.  Should this
applet the automatically added to the config when the ifup/down
commands were added?

Thanks,
Dave
___
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox