Re: [PATCH 2/4] Revert 2aeb201 "libbb: new option FEATURE_ETC_SERVICES"

2021-09-09 Thread Sergey Ponomarev
And nobody will use the FEATURE_ETC_SERVICES because it's useless and potentially breaks clients. FTP is always 21 no matter what is written in /etc/services. So let's just inline it as it's made in GNU wget. We have two cases: 1. "Well known port" i.e. that we know for sure in compile time FTP,

Re: [PATCH 2/4] Revert 2aeb201 "libbb: new option FEATURE_ETC_SERVICES"

2021-09-09 Thread Denys Vlasenko
Why? Just do not select FEATURE_ETC_SERVICES. On Wed, Aug 25, 2021 at 10:14 PM Sergey Ponomarev wrote: > > Don't lookup /etc/services for well known ports. > In the commit was added a new function bb_lookup_std_port(). > The function is in fact not needed and we may assume that it is always >

[PATCH 2/4] Revert 2aeb201 "libbb: new option FEATURE_ETC_SERVICES"

2021-08-25 Thread Sergey Ponomarev
Don't lookup /etc/services for well known ports. In the commit was added a new function bb_lookup_std_port(). The function is in fact not needed and we may assume that it is always disabled. Nobody changes ports in the /etc/services i.e. if we know a port it will always remain the same. The file