Re: [PATCH 3/4] Don't use bb_lookup_port() for well known ports

2021-09-09 Thread Sergey Ponomarev
Agree, we must use the bb_lookup_port(0 in telnet. But speaking about the FTP client it doesn't make sense because there are no other port names that work with ftp. cat /etc/services | grep ftp ftp-data20/tcp ftp 21/tcp tftp69/udp sftp115/tcp ftps-data

Re: [PATCH 3/4] Don't use bb_lookup_port() for well known ports

2021-09-09 Thread Denys Vlasenko
On Wed, Aug 25, 2021 at 10:15 PM Sergey Ponomarev wrote: > The bb_lookup_port() function may resolve port by its name. > But for FTP or TFTP no any names are expected because they work only with one > protocol. > E.g. it doesn't make any sense to execute ftpget -P http. This change does not

[PATCH 3/4] Don't use bb_lookup_port() for well known ports

2021-08-25 Thread Sergey Ponomarev
The bb_lookup_port() function may resolve port by its name. But for FTP or TFTP no any names are expected because they work only with one protocol. E.g. it doesn't make any sense to execute ftpget -P http. All other programs like traceroute are just use xatou16(). Note that the bb_lookup_port()